New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 803696 link

Starred by 2 users
Status: Fixed
Owner:
erikc...@chromium.org
Closed: Jan 2018
Cc:
ssid@chromium.org
█ mariakho...@chromium.org
dskiba@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Add plumbing to re-enable renderer/GPU OOP HP tests on Android

Project Member Reported by erikc...@chromium.org, Jan 19 2018 
The tests flakily fail because a heap dump is requested before the client process is connected. We can add some plumbing to the mojo services that will allow us to check for the number/type of connected processes, which will allow our tests to not flakily fail.

https://chromium-review.googlesource.com/c/chromium/src/+/874796
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee0a007b220b006ebfbf3a75a98a20ee13dea7ea

commit ee0a007b220b006ebfbf3a75a98a20ee13dea7ea
Author: erikchen <erikchen@chromium.org>
Date: Fri Jan 19 21:52:04 2018

Remove flakiness from OOPHP renderer tests. Add tests back to android.

Previously, there was a race between starting profiling for a renderer process,
and acquiring a heap dump from the renderer process. This CL adds some logic to
wait for the renderer to start. This CL also re-adds the GPU test, as no
flakiness has been observed there.

Bug:  803696 
Change-Id: I6ddc00dcf42e9d2c4292dcec50f77033de26ad7d
Reviewed-on: https://chromium-review.googlesource.com/876304
Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530623}
[modify] https://crrev.com/ee0a007b220b006ebfbf3a75a98a20ee13dea7ea/chrome/android/javatests/src/org/chromium/chrome/browser/profiling_host/ProfilingProcessHostAndroidTest.java
[modify] https://crrev.com/ee0a007b220b006ebfbf3a75a98a20ee13dea7ea/chrome/browser/profiling_host/memlog_browsertest.cc
[modify] https://crrev.com/ee0a007b220b006ebfbf3a75a98a20ee13dea7ea/chrome/browser/profiling_host/profiling_test_driver.cc
[modify] https://crrev.com/ee0a007b220b006ebfbf3a75a98a20ee13dea7ea/chrome/browser/profiling_host/profiling_test_driver.h

Comment 2 by erikc...@chromium.org, Jan 31 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment