yamaguchi@ - Could you please take a look at this regression in M64?

On M65 dev build (10302.0.0, 65.0.3319.0), the UI for password protected dialog box looks as per the attached screenshot. Please confirm if this UI is expected for M65?

Deleted: M65_behavior.png 254 KB

	M65_behavior.png 254 KB View Download

Re: #2 about M65 update
The style has been updated for this time, as tracked by Issue 768731.
The text messaging was modified per request by the UX last time.

However, to me, it looks like losing necessary information by recent changes.
Currently messaging can be interpreted as requiring user's login password because it only says "your password" and it's not clear that it means the passphrase of the file being opened in a zip archive.

> String: "Enter your password to gain access"
> 
> Preferred string: "Enter your password" < could you or someone on your team make this change?
>
> Reason: "to gain access" adds unnecessary words and complicates the string. "Enter your password" is a common string that can be leveraged from translation memory. "To gain access" is not.


IMHO I'd suggest """ Enter the passphrase to open this file. """ or so.

mcirimele@, will you take a look again?

> Step 1 & 2: 'This file is password protected' dialog box is not shown.
Does this mean the file could be opened without entering the passphrase for it?
If so, I think this is likely  Issue 803752 . It happens when the ZIP file was opened in the last session and was not manually unmounted.

> Step 1 & 2: 'This file is password protected' dialog box is not shown.
> Step 3: Unable to unmount the zip file. Observing 'Cannot unmount volume' dailog box.

Now I have found the common root cause.
The extension crashes by creating two shadow roots.
( Issue 780381  regressed.)
Looks like the ZIP unpacker extension is not the latest at least when flashing the latest official build. fukino@, will you take a look?

Uncaught DOMException: Failed to execute 'createShadowRoot' on 'Element': Shadow root cannot be created on a host which already hosts a shadow tree.
    at HTMLElement.shadowFromTemplate (chrome-extension://oedeeodfidgoollimchfdnbmhcpnklnd/third-party/polymer.js:10032:25)
    at HTMLElement.parseDeclaration (chrome-extension://oedeeodfidgoollimchfdnbmhcpnklnd/third-party/polymer.js:10004:25)
    at HTMLElement.parseDeclarations (chrome-extension://oedeeodfidgoollimchfdnbmhcpnklnd/third-party/polymer.js:9985:28)
    at HTMLElement.makeElementReady (chrome-extension://oedeeodfidgoollimchfdnbmhcpnklnd/third-party/polymer.js:9885:12)
    at HTMLElement.bindFinished (chrome-extension://oedeeodfidgoollimchfdnbmhcpnklnd/third-party/polymer.js:9656:12)
    at processBindings (chrome-extension://oedeeodfidgoollimchfdnbmhcpnklnd/third-party/polymer.js:7015:10)
    at cloneAndBindInstance (chrome-extension://oedeeodfidgoollimchfdnbmhcpnklnd/third-party/polymer.js:7112:5)
    at cloneAndBindInstance (chrome-extension://oedeeodfidgoollimchfdnbmhcpnklnd/third-party/polymer.js:7099:7)
    at HTMLTemplateElement.createInstance (chrome-extension://oedeeodfidgoollimchfdnbmhcpnklnd/third-party/polymer.js:6763:21)
    at HTMLElement.instanceTemplate (chrome-extension://oedeeodfidgoollimchfdnbmhcpnklnd/third-party/polymer.js:9613:26)
chrome.runtime.getManifest().version
"0.76"

Chrome 64.0.3282.101 (Official Build)
Platform 10176.54.0

On my test device, it updated to 0.76.1 and then 0.76.3 after waiting for while and rebooting 2 times.

Older version of ZIP unpacker can be installed just after the device is flashed.
It is the cause of this issue.

I changed the configuration of server side to make sure that the latest version is installed.
mkarkada@, could you test it again?

Hi yamaguchi, when tried opening the files within the zip archive, just that the password protected dialog box was not shown. But those files can not be viewed.

@fukino, updated my device to the same official beta build (10176.54.0, 64.0.3282.101) to cross-check this issue. I could see password protected dialog. Tested on peppy device.

mkarkada@, thank you for the confirmation!
The issue is gone now on the same device, right?
If so, I'll mark this issue as Fixed.

Hi fukino, this issue is not seen on the original devices eve and caroline too. Issue can be marked as fixed.

To add a point to comment in #3, will the string related changes be taken care in this bug? Is so, then this bug cannot be closed.

Thank you!

yamaguchi@, could you file a separate bug for the issue in comment #3 and mark this issue Fixed? Thanks!

Filed  Issue 804679  "Zip Archiver: Password input dialog UI".

Verified on M64 official beta build (10176.54.0, 64.0.3282.101) eve, caroline, peppy devices.