New issue
Advanced search Search tips

Issue 803684 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 545318



Sign in to add a comment

[css-typed-om] Implement CSSNumericValue.type()

Project Member Reported by shend@chromium.org, Jan 19 2018

Issue description

Comment 1 by shend@chromium.org, Jan 23 2018

Owner: shend@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af3f076ab039f478e0e82a6317832ef27e440345

commit af3f076ab039f478e0e82a6317832ef27e440345
Author: Darren Shen <shend@chromium.org>
Date: Wed Jan 24 23:59:28 2018

[css-typed-om] Implement CSSNumericValue.type().

This patch implements CSSNumericValue.type(), which exposes the type
of a CSSNumericValue in the form of a dictionary.

We changed a lot of tests because we originally couldn't inspect the
type of a CSSNumericValue via JavaScript, so we mainly wrote unit tests.
Now we can directly test the types in web platform tests.

WIP API:
https://github.com/w3c/css-houdini-drafts/pull/546/files

Bug:  803684 
Change-Id: Ie86a81c42cab34cd01286a3066be6bc9fda50fce
Reviewed-on: https://chromium-review.googlesource.com/880422
Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531751}
[add] https://crrev.com/af3f076ab039f478e0e82a6317832ef27e440345/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/numeric-objects/add-two-types.tentative.html
[add] https://crrev.com/af3f076ab039f478e0e82a6317832ef27e440345/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/numeric-objects/create-a-type.tentative.html
[add] https://crrev.com/af3f076ab039f478e0e82a6317832ef27e440345/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/numeric-objects/cssMathInvert-type.html
[add] https://crrev.com/af3f076ab039f478e0e82a6317832ef27e440345/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/numeric-objects/cssMathNegate-type.html
[add] https://crrev.com/af3f076ab039f478e0e82a6317832ef27e440345/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/numeric-objects/cssnumericvalue-multiply-two-types.tentative.html
[delete] https://crrev.com/a65df2750abc5f6d5ee368b3c80c907f96ff0ae6/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/numeric-objects/numeric-typing.tentative.html
[add] https://crrev.com/af3f076ab039f478e0e82a6317832ef27e440345/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/numeric-objects/resources/testhelper.js
[modify] https://crrev.com/af3f076ab039f478e0e82a6317832ef27e440345/third_party/WebKit/LayoutTests/http/tests/worklet/webexposed/global-interface-listing-paint-worklet-expected.txt
[modify] https://crrev.com/af3f076ab039f478e0e82a6317832ef27e440345/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/af3f076ab039f478e0e82a6317832ef27e440345/third_party/WebKit/Source/core/core_idl_files.gni
[add] https://crrev.com/af3f076ab039f478e0e82a6317832ef27e440345/third_party/WebKit/Source/core/css/cssom/CSSNumericType.idl
[modify] https://crrev.com/af3f076ab039f478e0e82a6317832ef27e440345/third_party/WebKit/Source/core/css/cssom/CSSNumericValue.cpp
[modify] https://crrev.com/af3f076ab039f478e0e82a6317832ef27e440345/third_party/WebKit/Source/core/css/cssom/CSSNumericValue.h
[modify] https://crrev.com/af3f076ab039f478e0e82a6317832ef27e440345/third_party/WebKit/Source/core/css/cssom/CSSNumericValue.idl
[modify] https://crrev.com/af3f076ab039f478e0e82a6317832ef27e440345/third_party/WebKit/Source/core/css/cssom/CSSNumericValueType.cpp
[modify] https://crrev.com/af3f076ab039f478e0e82a6317832ef27e440345/third_party/WebKit/Source/core/css/cssom/CSSNumericValueType.h
[modify] https://crrev.com/af3f076ab039f478e0e82a6317832ef27e440345/third_party/WebKit/Source/core/css/cssom/CSSNumericValueTypeTest.cpp
[modify] https://crrev.com/af3f076ab039f478e0e82a6317832ef27e440345/third_party/WebKit/Source/core/css/cssom/CSSUnitValueTest.cpp

Comment 3 by shend@chromium.org, Jan 29 2018

Status: Fixed (was: Started)

Sign in to add a comment