New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 803681 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 0
Type: Bug



Sign in to add a comment

platform_AddPrinter.epson fails with "valid_config - Could not setup valid printer 2"

Project Member Reported by derat@chromium.org, Jan 19 2018

Issue description

platform_AddPrinter just failed on http://uberchromegw/i/chromeos.chrome/builders/tricky-tot-chrome-pfq-informational/builds/7730 and http://uberchromegw/i/chromeos.chrome/builders/peach_pit-tot-chrome-pfq-informational/builds/9371.

Both failures' INFO logs end with the following:

01/18 15:03:44.170 INFO |platform_AddPrinte:0155| download component:epson-inkjet-printer-escpr
01/18 15:03:44.930 INFO |platform_AddPrinte:0111| add printer from ppd:/tmp/Epson-WF-3620_Series-epson-escpr-en.ppd
01/18 15:03:45.225 WARNI|              test:0637| The test failed with the following exception
Traceback (most recent call last):
  File "/usr/local/autotest/common_lib/test.py", line 631, in _exec
    _call_test_function(self.execute, *p_args, **p_dargs)
  File "/usr/local/autotest/common_lib/test.py", line 831, in _call_test_function
    return func(*args, **dargs)
  File "/usr/local/autotest/common_lib/test.py", line 495, in execute
    dargs)
  File "/usr/local/autotest/common_lib/test.py", line 362, in _call_run_once_with_retry
    postprocess_profiled_run, args, dargs)
  File "/usr/local/autotest/common_lib/test.py", line 400, in _call_run_once
    self.run_once(*args, **dargs)
  File "/usr/local/autotest/tests/platform_AddPrinter/platform_AddPrinter.py", line 173, in run_once
    self.add_a_printer(self.ppd_file)
  File "/usr/local/autotest/tests/platform_AddPrinter/platform_AddPrinter.py", line 119, in add_a_printer
    'printer %d' % result)
TestFail: valid_config - Could not setup valid printer 2
01/18 15:03:45.372 INFO |           browser:0212| Closing browser (pid=11167) ...
01/18 15:03:45.376 INFO |    cros_interface:0564| (Re)starting the ui (logs the user out)
01/18 15:03:47.480 INFO |           browser:0226| Browser is closed.
01/18 15:03:47.481 ERROR|              test:0645| Ignoring exception during cleanup() phase:
01/18 15:03:47.496 ERROR|         traceback:0013| Traceback (most recent call last):
01/18 15:03:47.512 ERROR|         traceback:0013|   File "/usr/local/autotest/common_lib/test.py", line 643, in _exec
01/18 15:03:47.528 ERROR|         traceback:0013|     _cherry_pick_call(self.cleanup, *args, **dargs)
01/18 15:03:47.543 ERROR|         traceback:0013|   File "/usr/local/autotest/common_lib/test.py", line 746, in _cherry_pick_call
01/18 15:03:47.558 ERROR|         traceback:0013|     return func(*p_args, **p_dargs)
01/18 15:03:47.571 ERROR|         traceback:0013|   File "/usr/local/autotest/tests/platform_AddPrinter/platform_AddPrinter.py", line 80, in cleanup
01/18 15:03:47.585 ERROR|         traceback:0013|     os.remove(self.printing_log_path)
01/18 15:03:47.597 ERROR|         traceback:0013| OSError: [Errno 2] No such file or directory: '/tmp/printing_request.log'
01/18 15:03:47.615 ERROR|              test:0649| Now raising the earlier <class 'autotest_lib.client.common_lib.error.TestFail'> error
 

Comment 1 by ka...@chromium.org, Jan 19 2018

Owner: skau@chromium.org
Thanks for filing the bug.
+skau@

Hi Sean and Xiaochu,
I haven't seen AddPrinter test failing with this reason (valid_config - Could not setup valid printer 2).
Last instances of "valid_config - Could not setup valid printer 3" were from mid-December before tests were stabilized in issue 768622.

The few instances logs are at 
rikku: https://pantheon.corp.google.com/storage/browser/chromeos-autotest-results/170723044-chromeos-test/chromeos4-row2-rack3-host18/
peach_pit: https://pantheon.corp.google.com/storage/browser/chromeos-autotest-results/170724387-chromeos-test/chromeos6-row2-rack11-host4/

Cc: briannorris@chromium.org justincarlson@chromium.org

Comment 3 by derat@chromium.org, Jan 19 2018

The next tricky run just failed with the same error, so this looks like it may be venturing beyond the designation of "flaky": http://uberchromegw/i/chromeos.chrome/builders/tricky-tot-chrome-pfq-informational/builds/7731
Cc: -wutao@chromium.org valleau@chromium.org
Something of a shot in the dark, but I would guess https://chromium-review.googlesource.com/c/chromium/src/+/861956 may be involved

+valleau@chromium.org

Comment 5 by ka...@chromium.org, Jan 19 2018

Summary: platform_AddPrinter.epson fails with "valid_config - Could not setup valid printer 2" (was: platform_AddPrinter fails with "valid_config - Could not setup valid printer 2")
It is the .epson(and not .generic) test. Not sure if matters.

Both fail jobs at
http://cautotest-prod/afe/#tab_id=view_job&object_id=170739214
http://cautotest-prod/afe/#tab_id=view_job&object_id=170723044

Comment 6 by derat@chromium.org, Jan 19 2018

And caroline too now: http://uberchromegw/i/chromeos.chrome/builders/caroline-tot-chrome-pfq-informational/builds/787

Please let me know if you'll be able to fix this soon or not.

Comment 7 by derat@chromium.org, Jan 19 2018

Labels: -Pri-1 Build-PFQ-Failures Pri-0

Comment 8 by skau@chromium.org, Jan 19 2018

I'm going to move epson out of the CQ and back to perbuild.  The epson test requires talking to omaha.

Comment 9 by skau@chromium.org, Jan 19 2018

Yep.  2 is INVALID_PPD[1].  That's because the component hasn't been downloaded.

[1] https://chromium.googlesource.com/chromiumos/platform/system_api/+/master/dbus/debugd/dbus-constants.h
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/da10febf36d4434dc8958fb73d1adf8f0053254b

commit da10febf36d4434dc8958fb73d1adf8f0053254b
Author: Sean Kau <skau@chromium.org>
Date: Fri Jan 19 02:37:19 2018

autotest: Move platform_AddPrinter.epson out of cq

platform_AddPrinter.epson requires talking downloading
the epson component. This can fail and cause periodic
failures in the waterfall.

BUG= chromium:803681 
TEST=None
TBR=derat@chromium.org,kalin@chromium.org

Change-Id: I063ba38bd4fdf487808f1be2f90b72e701161ef6
Reviewed-on: https://chromium-review.googlesource.com/874783
Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Xiaochu Liu <xiaochu@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Sean Kau <skau@chromium.org>
Tested-by: Sean Kau <skau@chromium.org>
Trybot-Ready: Sean Kau <skau@chromium.org>

[modify] https://crrev.com/da10febf36d4434dc8958fb73d1adf8f0053254b/client/site_tests/platform_AddPrinter/control.epson

I merged a component updater change today. It could be the issue. I'm reverting that CL here: https://chromium-review.googlesource.com/c/chromium/src/+/875167
Owner: xiaochu@chromium.org
I added an optional boolean parameter to our Load component API in that CL. For some reason, it is set by default false if caller misses this boolean parameter. I'm working on a fix to this in chrome.
Project Member

Comment 13 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f53149065b6141c97c6ffe9d3cdfd6264a94f1b7

commit f53149065b6141c97c6ffe9d3cdfd6264a94f1b7
Author: Xiaochu Liu <xiaochu@chromium.org>
Date: Fri Jan 19 22:08:28 2018

component updater Load API by default loads image

PopBool sets its parameter to be false on a failure (dbus optional
parameter is missing).
I reset the mount variable to be true on a failure return of PopBool.

BUG= chromium:803681 
TEST=test_that -b ${BOARD} 100.127.0.229 platform_AddPrinter.epson

Change-Id: Ibc8981df635b121057b6e43dc3fe3dc7b317fd75
Reviewed-on: https://chromium-review.googlesource.com/876654
Commit-Queue: Xiaochu Liu <xiaochu@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530628}
[modify] https://crrev.com/f53149065b6141c97c6ffe9d3cdfd6264a94f1b7/chromeos/dbus/services/component_updater_service_provider.cc

Project Member

Comment 14 by bugdroid1@chromium.org, Jan 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b0b64147a207acab3f55c56dad2d470d27833ccf

commit b0b64147a207acab3f55c56dad2d470d27833ccf
Author: Xiaochu Liu <xiaochu@chromium.org>
Date: Tue Jan 23 06:07:16 2018

platform_AddPrinter: report detailed (correct) errors

This CL supports reporting errors on component errors, printer setup
errors and printing errors accurately.

It calls UnloadComponent to clean up the component. Unfortunately
dbus_send python wrapper module does not handle dbus API return value
with empty list. So I fallback to use dbus-send command directly. I will
modify this API to return a boolean result and come back to use the
wrapper.

BUG= chromium:803681 
TEST=test_that -b kefka <IP> platform_AddPrinter.epson

Change-Id: I1846f22c5af71aa0dad6473785b57d00a2d3b50f
Reviewed-on: https://chromium-review.googlesource.com/877479
Commit-Ready: Xiaochu Liu <xiaochu@chromium.org>
Tested-by: Xiaochu Liu <xiaochu@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>

[modify] https://crrev.com/b0b64147a207acab3f55c56dad2d470d27833ccf/client/site_tests/platform_AddPrinter/platform_AddPrinter.py

Status: Fixed (was: Assigned)

Sign in to add a comment