After [1], it is no longer required to build libc++abi against libunwind. We should remove the dependency altogether, but leave the libunwind build files for fuchsia to use. [1] https://chromium.googlesource.com/chromium/llvm-project/libcxxabi/+/7512331622d78a262298560330e4a39d69892203
The following revision refers to this bug: https://chromium.googlesource.com/chromium/buildtools/+/e514b423cd416a52c3b8ac41c6ee984a7be7779f commit e514b423cd416a52c3b8ac41c6ee984a7be7779f Author: Tom Anderson <thomasanderson@chromium.org> Date: Fri Jan 19 23:43:25 2018 Remove libunwind arm dependency from libc++abi The dependency is still needed on fuchsia though. AFAICT, this is because libc++ and libc++abi are the only targets that get built with exceptions enabled, and fuchsia doesn't link against any libraries that provides stack unwinding symbols, but Linux does (glibc). BUG= 803679 R=thakis Change-Id: If2865422431564a4b5dba1eb8868bc2474922904 [modify] https://crrev.com/e514b423cd416a52c3b8ac41c6ee984a7be7779f/third_party/libunwind/BUILD.gn [modify] https://crrev.com/e514b423cd416a52c3b8ac41c6ee984a7be7779f/third_party/libc++abi/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/buildtools/+/dd61138d23904d36208480406ac8595ba6a2d516 commit dd61138d23904d36208480406ac8595ba6a2d516 Author: Tom Anderson <thomasanderson@chromium.org> Date: Mon Jan 22 23:39:36 2018 Add libunwind include path to libunwind config CL [1] is going to remove the libunwind include path from the global config. It's only needed for the libunwind build itself. [1] https://chromium-review.googlesource.com/c/chromium/src/+/875330 BUG= 803679 TBR=thakis Change-Id: Ib05a0324d7f0519935cf25bb441dcdfdba11071c [modify] https://crrev.com/dd61138d23904d36208480406ac8595ba6a2d516/third_party/libunwind/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/buildtools/+/cac097d5c2b80bd1f91640fb6463f8dcd59731ae commit cac097d5c2b80bd1f91640fb6463f8dcd59731ae Author: Tom Anderson <thomasanderson@chromium.org> Date: Fri Jan 26 22:16:58 2018 Roll lib{cxx,cxxabi,unwind} Revisions in this roll: https://chromium.googlesource.com/external/llvm.org/libcxx/+log/8864da5e7823f79f801512ec4dbcca89feff7a23..27c341db41bc9df5c6f19cde65f002d6f1c2eb3c https://chromium.googlesource.com/external/llvm.org/libcxxabi/+log/9a02f50fc1d2acde806c69085ad979a685cb0694..e1601db2504857d44db88a5d4e2ca50b32bbb7d9 https://chromium.googlesource.com/external/llvm.org/libunwind/+log/98762d639111593699b509ab6bc20ebed0e41352..86ab23972978242b6f9e27cebc239f3e8428b1af BUG= 803679 TBR=pcc Change-Id: Idfcc2f4c90a7b0ac838af279ab612ea1cf3df3ed [modify] https://crrev.com/cac097d5c2b80bd1f91640fb6463f8dcd59731ae/DEPS
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea4edeec4194c6e751d3be2d5fa262a2475f6c47 commit ea4edeec4194c6e751d3be2d5fa262a2475f6c47 Author: Tom Anderson <thomasanderson@chromium.org> Date: Sun Jan 28 01:31:48 2018 Remove libunwind arm dependency from libc++abi (src-side changes) The buildtools roll includes these revisions: https://chromium.googlesource.com/chromium/buildtools/+log/437a616be5b2056336ed3ca5c33c41f7788ede09..a2cbf26d9ed33836bc3e412b4dc0df259e4a1525 BUG= 803679 R=thakis@chromium.org Change-Id: Ie398be7d8ef52d6a733f52043300449b3d35e947 Reviewed-on: https://chromium-review.googlesource.com/875330 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#532259} [modify] https://crrev.com/ea4edeec4194c6e751d3be2d5fa262a2475f6c47/DEPS [modify] https://crrev.com/ea4edeec4194c6e751d3be2d5fa262a2475f6c47/build/config/c++/c++.gni [modify] https://crrev.com/ea4edeec4194c6e751d3be2d5fa262a2475f6c47/build/config/posix/BUILD.gn [modify] https://crrev.com/ea4edeec4194c6e751d3be2d5fa262a2475f6c47/build/nocompile.gni
Comment 1 by bugdroid1@chromium.org
, Jan 19 2018