New issue
Advanced search Search tips

Issue 803661 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug


Sign in to add a comment

Roll clang again

Project Member Reported by p...@chromium.org, Jan 18 2018

Issue description

Need r321982 for issue 760259.
 

Comment 1 by p...@chromium.org, Jan 18 2018

Cc: vtsyrklevich@chromium.org
vtsyrklevich@ mentioned that he wanted a clang roll for some cfi-icall fixes.
Blocking: 795807
Need r322139 for  issue 795807 .

Comment 3 by p...@chromium.org, Jan 19 2018

Cc: hmchen@chromium.org

Comment 4 by r...@chromium.org, Jan 19 2018

Blocking: 800169
I want r322905 for  issue 800169 

Comment 5 by r...@chromium.org, Jan 23 2018

We also want Bob's r323164 LLD change to preserve the import library file timestamp when re-linking a DLL. I don't think we filed a crbug for that, it's just part of the general incremental linking bug in LLVM: https://bugs.llvm.org/show_bug.cgi?id=35917

Comment 6 by p...@chromium.org, Jan 24 2018

Blocking: 801780
r323362 should help a little with issue 801780.

Comment 7 by thakis@chromium.org, Jan 25 2018

Blocking: 783370

Comment 8 by p...@chromium.org, Jan 30 2018

Blockedon: 807402

Comment 9 by p...@chromium.org, Jan 30 2018

Blockedon: 807405
We'd also like r323825 for bug 751218.

Comment 11 by p...@chromium.org, Jan 31 2018

Need r323844 for  issue 807405 .
Blocking: 784620
We need r323892 for  issue 784620 .
Cc: liaoyuke@chromium.org
Correction to c#12, we need r323923.

Comment 15 by h...@chromium.org, Feb 1 2018

Blockedon: 807994

Comment 16 by h...@chromium.org, Feb 1 2018

Owner: h...@chromium.org
Status: Assigned (was: Untriaged)
I've started looking at the ToT bots. So far:

tot ubsan is red, not a blocker,  crbug.com/807631 
totlinuxthinlto, pcc is on it,  crbug.com/807402 
android x64 failing, infra problems? not blocking,  crbug.com/807966 
android asan failing, probably not blocking,  crbug.com/807967 
android cfi, not usually green so not blocking,  crbug.com/807969 
totmac failing to build libcxx, blocking,  crbug.com/807994 

Will now work my way over to the Windows side..

Comment 17 by h...@chromium.org, Feb 1 2018

Blockedon: 808011

Comment 18 by h...@chromium.org, Feb 1 2018

Blockedon: -808011

Comment 19 by h...@chromium.org, Feb 1 2018

Blockedon: 808030

Comment 20 by h...@chromium.org, Feb 1 2018

Blockedon: 808033

Comment 21 by h...@chromium.org, Feb 2 2018

Blockedon: 808433

Comment 22 by h...@chromium.org, Feb 5 2018

Blockedon: 809050

Comment 23 by h...@chromium.org, Feb 7 2018

Blockedon: 809916

Comment 24 by h...@chromium.org, Feb 8 2018

Status: Started (was: Assigned)
All the blockers are accounted for, and don't seem to actually be blocking the roll. Trying one here: https://chromium-review.googlesource.com/c/chromium/src/+/903927
Project Member

Comment 25 by bugdroid1@chromium.org, Feb 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca5066b992b8a05e6a3df042f2c0e1766e13a565

commit ca5066b992b8a05e6a3df042f2c0e1766e13a565
Author: Hans Wennborg <hans@chromium.org>
Date: Fri Feb 09 12:48:33 2018

Roll clang 321529:324578

This changes the Clang version number from 6.0.0 to 7.0.0.

Bug:  803661 

Change-Id: Ib717cadcb3873d6dc3e49267629f7ffc1acf1df7
Reviewed-on: https://chromium-review.googlesource.com/903927
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535693}
[modify] https://crrev.com/ca5066b992b8a05e6a3df042f2c0e1766e13a565/build/toolchain/toolchain.gni
[modify] https://crrev.com/ca5066b992b8a05e6a3df042f2c0e1766e13a565/tools/clang/scripts/update.py

Comment 26 by h...@chromium.org, Feb 19 2018

Status: Fixed (was: Started)
The roll has stuck.

Perf report: https://chromeperf.appspot.com/group_report?rev=535693

Sign in to add a comment