cros/swarming recipe incorrectly inserts --buildbot on many builds. |
||
Issue descriptionhttps://ci.chromium.org/p/chromeos/builds/b8957125038381727760 /b/swarming/w/ir/kitchen-workdir/chromite/scripts/cbuildbot_launch --buildroot /b/swarming/w/ir/cache/cbuild --buildbot --branch master --buildbucket-id 8957125038381727760 --git-cache-dir /b/swarming/w/ir/cache/git --goma_dir /b/swarming/w/ir/cache/goma_client --goma_client_json /creds/service_accounts/service-account-goma-client.json kevin-paladin-tryjob Notice that "--buildbot" was passed in for a general tryjob. That is dangerous, and should not be.
,
Jan 19 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/b4a5a928ed3f08c4f76b4ae10b7dad00874cc2d6 commit b4a5a928ed3f08c4f76b4ae10b7dad00874cc2d6 Author: Don Garrett <dgarrett@google.com> Date: Fri Jan 19 01:52:07 2018
,
Jan 19 2018
Just launched a new tryjob, and it did NOT include --buildbot. So.. fixed, even though there is one more small cleanup CL incoming.
,
Jan 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/bc47afefdf50afcdd9abde3d8ff1204340e25acd commit bc47afefdf50afcdd9abde3d8ff1204340e25acd Author: Don Garrett <dgarrett@google.com> Date: Fri Jan 19 23:14:58 2018 cros/swarming: Remove unnecessary default arg. Now that the internal recipes have been updated, there is no need for this default. BUG= chromium:803652 Change-Id: I36e76987fc68a2747c408614be9a7d70142502c9 Reviewed-on: https://chromium-review.googlesource.com/875410 Reviewed-by: Nodir Turakulov <nodir@chromium.org> Commit-Queue: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/bc47afefdf50afcdd9abde3d8ff1204340e25acd/scripts/slave/README.recipes.md [modify] https://crrev.com/bc47afefdf50afcdd9abde3d8ff1204340e25acd/scripts/slave/recipe_modules/chromite/api.py |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Jan 19 2018