New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 803648 link

Starred by 1 user
Status: Fixed
Owner:
█ hongjunchoi@chromium.org
Last visit > 30 days ago
Closed: Jan 2018
Cc:
reillyg@chromium.org
kpaulhamus@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Add accessor/factory methods for boolean CBOR simple value types

Project Member Reported by hongjunchoi@chromium.org, Jan 18 2018 
Add CBORValue::FromBoolean() and CBORValue::GetBool() for simpler API calls dealing with boolean CBOR simple values.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b6fbff35cd8e4d508f08e1cd93b4aa0a0dc402c

commit 7b6fbff35cd8e4d508f08e1cd93b4aa0a0dc402c
Author: Jun Choi <hongjunchoi@chromium.org>
Date: Mon Jan 22 19:54:01 2018

Add methods for creating boolean simple values

Add helper methods and static factory methods for creating/accessing
boolean CBOR simple values.

Bug:  803648 
Change-Id: If0297d149ee1b58022fcf6b92e521b28e5f9faff
Reviewed-on: https://chromium-review.googlesource.com/875196
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530958}
[modify] https://crrev.com/7b6fbff35cd8e4d508f08e1cd93b4aa0a0dc402c/components/cbor/cbor_values.cc
[modify] https://crrev.com/7b6fbff35cd8e4d508f08e1cd93b4aa0a0dc402c/components/cbor/cbor_values.h
[modify] https://crrev.com/7b6fbff35cd8e4d508f08e1cd93b4aa0a0dc402c/components/cbor/cbor_values_unittest.cc

Comment 2 by hongjunchoi@chromium.org, Jan 23 2018

Status: Fixed (was: Untriaged)
►

Sign in to add a comment