Add controller tooltips |
|||||
Issue descriptionWe need to label the controller when it is focused to let the user know what will happen when you press certain buttons.
,
Jan 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/224aa1b2b81a61b42256faf5c91f5b726cd24833 commit 224aa1b2b81a61b42256faf5c91f5b726cd24833 Author: Ian Vollick <vollick@chromium.org> Date: Mon Jan 22 15:20:01 2018 [vr] Controller Tooltip Tweaks Adds a "back" label that appears when in editing mode, fixes the position of the callout lines relative to the controller, and corrects bounding box issues when using text shadows. Bug: 803638 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I357831bf4358f71d095b723b6af27ea4e7d21eec Reviewed-on: https://chromium-review.googlesource.com/878382 Reviewed-by: Yash Malik <ymalik@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#530862} [modify] https://crrev.com/224aa1b2b81a61b42256faf5c91f5b726cd24833/chrome/app/generated_resources.grd [modify] https://crrev.com/224aa1b2b81a61b42256faf5c91f5b726cd24833/chrome/browser/vr/elements/text.cc [modify] https://crrev.com/224aa1b2b81a61b42256faf5c91f5b726cd24833/chrome/browser/vr/elements/ui_element_name.cc [modify] https://crrev.com/224aa1b2b81a61b42256faf5c91f5b726cd24833/chrome/browser/vr/elements/ui_element_name.h [modify] https://crrev.com/224aa1b2b81a61b42256faf5c91f5b726cd24833/chrome/browser/vr/elements/ui_texture.cc [modify] https://crrev.com/224aa1b2b81a61b42256faf5c91f5b726cd24833/chrome/browser/vr/testapp/vr_test_context.cc [modify] https://crrev.com/224aa1b2b81a61b42256faf5c91f5b726cd24833/chrome/browser/vr/ui_scene_constants.h [modify] https://crrev.com/224aa1b2b81a61b42256faf5c91f5b726cd24833/chrome/browser/vr/ui_scene_creator.cc [modify] https://crrev.com/224aa1b2b81a61b42256faf5c91f5b726cd24833/chrome/browser/vr/ui_unittest.cc
,
Jan 22 2018
,
Jan 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2e608605aefbecc9ea1400d07b3c152fa2fd8272 commit 2e608605aefbecc9ea1400d07b3c152fa2fd8272 Author: Ian Vollick <vollick@chromium.org> Date: Tue Jan 23 16:13:46 2018 [vr] Use correct controller tooltip when in voice input mode. I missed a mode where we need to label the app button on the controller. This CL also wires the middle mouse button to Ui::OnAppButtonClicked in the test app. Bug: 803638 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ifbc126189b2ba0b2c59a73ca740635b3998c4241 Reviewed-on: https://chromium-review.googlesource.com/881205 Reviewed-by: Yash Malik <ymalik@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#531253} [modify] https://crrev.com/2e608605aefbecc9ea1400d07b3c152fa2fd8272/chrome/browser/vr/testapp/vr_test_context.cc [modify] https://crrev.com/2e608605aefbecc9ea1400d07b3c152fa2fd8272/chrome/browser/vr/ui_scene_creator.cc [modify] https://crrev.com/2e608605aefbecc9ea1400d07b3c152fa2fd8272/chrome/browser/vr/ui_unittest.cc
,
Feb 7 2018
,
Feb 7 2018
,
Mar 7 2018
Added test case "Controller Tooltips" to "VR Browsing manual test plan". Verified the on 66.0.3359.10 that the tooltips appear as expected. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Jan 19 2018