New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 803638 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-XR
Proj-XR-VR



Sign in to add a comment

Add controller tooltips

Project Member Reported by vollick@chromium.org, Jan 18 2018

Issue description

We need to label the controller when it is focused to let the user know what will happen when you press certain buttons.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7332d07490f42ab4fa9ee1a958d9b4e07531b025

commit 7332d07490f42ab4fa9ee1a958d9b4e07531b025
Author: Ian Vollick <vollick@chromium.org>
Date: Fri Jan 19 15:43:42 2018

[vr] Add controller tooltips

The tooltips are only visible when the controller has been in the
viewport for longer than a minimum threshold of time. The "exit" button
is only labeled when in fullscreen mode.

Bug:  803638 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ia5e742a97e7a89c74fc0570e15ff2b5035ace524
Reviewed-on: https://chromium-review.googlesource.com/875172
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Yash Malik <ymalik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530516}
[modify] https://crrev.com/7332d07490f42ab4fa9ee1a958d9b4e07531b025/chrome/app/generated_resources.grd
[modify] https://crrev.com/7332d07490f42ab4fa9ee1a958d9b4e07531b025/chrome/browser/android/vr_shell/vr_controller.cc
[modify] https://crrev.com/7332d07490f42ab4fa9ee1a958d9b4e07531b025/chrome/browser/android/vr_shell/vr_controller.h
[modify] https://crrev.com/7332d07490f42ab4fa9ee1a958d9b4e07531b025/chrome/browser/android/vr_shell/vr_shell_gl.cc
[modify] https://crrev.com/7332d07490f42ab4fa9ee1a958d9b4e07531b025/chrome/browser/android/vr_shell/vr_shell_gl.h
[modify] https://crrev.com/7332d07490f42ab4fa9ee1a958d9b4e07531b025/chrome/browser/vr/BUILD.gn
[modify] https://crrev.com/7332d07490f42ab4fa9ee1a958d9b4e07531b025/chrome/browser/vr/elements/text.cc
[modify] https://crrev.com/7332d07490f42ab4fa9ee1a958d9b4e07531b025/chrome/browser/vr/elements/text.h
[modify] https://crrev.com/7332d07490f42ab4fa9ee1a958d9b4e07531b025/chrome/browser/vr/elements/ui_element.cc
[modify] https://crrev.com/7332d07490f42ab4fa9ee1a958d9b4e07531b025/chrome/browser/vr/elements/ui_element_name.cc
[modify] https://crrev.com/7332d07490f42ab4fa9ee1a958d9b4e07531b025/chrome/browser/vr/elements/ui_element_name.h
[modify] https://crrev.com/7332d07490f42ab4fa9ee1a958d9b4e07531b025/chrome/browser/vr/elements/ui_texture.cc
[modify] https://crrev.com/7332d07490f42ab4fa9ee1a958d9b4e07531b025/chrome/browser/vr/elements/ui_texture.h
[modify] https://crrev.com/7332d07490f42ab4fa9ee1a958d9b4e07531b025/chrome/browser/vr/model/color_scheme.cc
[modify] https://crrev.com/7332d07490f42ab4fa9ee1a958d9b4e07531b025/chrome/browser/vr/model/color_scheme.h
[add] https://crrev.com/7332d07490f42ab4fa9ee1a958d9b4e07531b025/chrome/browser/vr/model/controller_model.cc
[modify] https://crrev.com/7332d07490f42ab4fa9ee1a958d9b4e07531b025/chrome/browser/vr/model/controller_model.h
[modify] https://crrev.com/7332d07490f42ab4fa9ee1a958d9b4e07531b025/chrome/browser/vr/platform_controller.h
[modify] https://crrev.com/7332d07490f42ab4fa9ee1a958d9b4e07531b025/chrome/browser/vr/test/ui_pixel_test.cc
[modify] https://crrev.com/7332d07490f42ab4fa9ee1a958d9b4e07531b025/chrome/browser/vr/testapp/vr_test_context.cc
[modify] https://crrev.com/7332d07490f42ab4fa9ee1a958d9b4e07531b025/chrome/browser/vr/testapp/vr_test_context.h
[modify] https://crrev.com/7332d07490f42ab4fa9ee1a958d9b4e07531b025/chrome/browser/vr/ui.cc
[modify] https://crrev.com/7332d07490f42ab4fa9ee1a958d9b4e07531b025/chrome/browser/vr/ui_input_manager.cc
[modify] https://crrev.com/7332d07490f42ab4fa9ee1a958d9b4e07531b025/chrome/browser/vr/ui_input_manager.h
[modify] https://crrev.com/7332d07490f42ab4fa9ee1a958d9b4e07531b025/chrome/browser/vr/ui_input_manager_unittest.cc
[modify] https://crrev.com/7332d07490f42ab4fa9ee1a958d9b4e07531b025/chrome/browser/vr/ui_scene_constants.h
[modify] https://crrev.com/7332d07490f42ab4fa9ee1a958d9b4e07531b025/chrome/browser/vr/ui_scene_creator.cc
[modify] https://crrev.com/7332d07490f42ab4fa9ee1a958d9b4e07531b025/chrome/browser/vr/ui_unittest.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/224aa1b2b81a61b42256faf5c91f5b726cd24833

commit 224aa1b2b81a61b42256faf5c91f5b726cd24833
Author: Ian Vollick <vollick@chromium.org>
Date: Mon Jan 22 15:20:01 2018

[vr] Controller Tooltip Tweaks

Adds a "back" label that appears when in editing mode, fixes the
position of the callout lines relative to the controller, and corrects
bounding box issues when using text shadows.

Bug:  803638 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I357831bf4358f71d095b723b6af27ea4e7d21eec
Reviewed-on: https://chromium-review.googlesource.com/878382
Reviewed-by: Yash Malik <ymalik@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530862}
[modify] https://crrev.com/224aa1b2b81a61b42256faf5c91f5b726cd24833/chrome/app/generated_resources.grd
[modify] https://crrev.com/224aa1b2b81a61b42256faf5c91f5b726cd24833/chrome/browser/vr/elements/text.cc
[modify] https://crrev.com/224aa1b2b81a61b42256faf5c91f5b726cd24833/chrome/browser/vr/elements/ui_element_name.cc
[modify] https://crrev.com/224aa1b2b81a61b42256faf5c91f5b726cd24833/chrome/browser/vr/elements/ui_element_name.h
[modify] https://crrev.com/224aa1b2b81a61b42256faf5c91f5b726cd24833/chrome/browser/vr/elements/ui_texture.cc
[modify] https://crrev.com/224aa1b2b81a61b42256faf5c91f5b726cd24833/chrome/browser/vr/testapp/vr_test_context.cc
[modify] https://crrev.com/224aa1b2b81a61b42256faf5c91f5b726cd24833/chrome/browser/vr/ui_scene_constants.h
[modify] https://crrev.com/224aa1b2b81a61b42256faf5c91f5b726cd24833/chrome/browser/vr/ui_scene_creator.cc
[modify] https://crrev.com/224aa1b2b81a61b42256faf5c91f5b726cd24833/chrome/browser/vr/ui_unittest.cc

Cc: gordonbrander@chromium.org
Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e608605aefbecc9ea1400d07b3c152fa2fd8272

commit 2e608605aefbecc9ea1400d07b3c152fa2fd8272
Author: Ian Vollick <vollick@chromium.org>
Date: Tue Jan 23 16:13:46 2018

[vr] Use correct controller tooltip when in voice input mode.

I missed a mode where we need to label the app button on the controller.

This CL also wires the middle mouse button to Ui::OnAppButtonClicked in
the test app.

Bug:  803638 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ifbc126189b2ba0b2c59a73ca740635b3998c4241
Reviewed-on: https://chromium-review.googlesource.com/881205
Reviewed-by: Yash Malik <ymalik@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531253}
[modify] https://crrev.com/2e608605aefbecc9ea1400d07b3c152fa2fd8272/chrome/browser/vr/testapp/vr_test_context.cc
[modify] https://crrev.com/2e608605aefbecc9ea1400d07b3c152fa2fd8272/chrome/browser/vr/ui_scene_creator.cc
[modify] https://crrev.com/2e608605aefbecc9ea1400d07b3c152fa2fd8272/chrome/browser/vr/ui_unittest.cc

Labels: Test-Manual
Labels: Test-Manual
Labels: -Test-Manual Test-Complete
Status: Verified (was: Fixed)
Added test case "Controller Tooltips" to "VR Browsing manual test plan".
Verified the on 66.0.3359.10 that the tooltips appear as expected.

Sign in to add a comment