Autoroll profiles for chrome on Android |
||||
Issue descriptionNow that AFDO profiles have landed for Chrome on Android (and we seem mostly happy with them), we should autoroll them. Autorolling shouldn't be too difficult, since these profiles are generated and validated by our Chrome OS friends. At a minimum, we can just set up a cronjob with `git push` access to clank that checks for new profiles and pushes something similar to the changes in profiles/newest.txt in https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/549380 if there's a new one. Ideally, we'd also do a sanity check (e.g. +CQ?), in order to be sure that nothing is horribly broken by the new profile. Clang bugs, while pretty rare, are not out of the question, in my experience. :)
,
Jan 23 2018
-restrict-view, since we're upstreaming all of this now. Looks like the +CQ approach will be easily doable.
,
Jan 23 2018
,
Jan 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9919631e216f0c36a766e1be65edb0c548dbdb48 commit 9919631e216f0c36a766e1be65edb0c548dbdb48 Author: George Burgess IV <gbiv@chromium.org> Date: Wed Jan 24 22:31:04 2018 Let anyone update the Android profile version Including autorollers. This also removes an entry for the now-deleted android.ensure file. Bug: 803632 Test: None Change-Id: I481b0e2822aee2ac0b6d919aa0ee4a84954f12ed Reviewed-on: https://chromium-review.googlesource.com/884233 Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#531720} [modify] https://crrev.com/9919631e216f0c36a766e1be65edb0c548dbdb48/chrome/android/OWNERS
,
Jan 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/daecbaf6c371c584547d1b8ac510b652614e2346 commit daecbaf6c371c584547d1b8ac510b652614e2346 Author: George Burgess <gbiv@chromium.org> Date: Thu Jan 25 00:14:58 2018 Revert "Let anyone update the Android profile version" This reverts commit 9919631e216f0c36a766e1be65edb0c548dbdb48. Reason for revert: breaking presubmits: https://ci.chromium.org/buildbot/tryserver.chromium.linux/chromium_presubmit/644296 Original change's description: > Let anyone update the Android profile version > > Including autorollers. > > This also removes an entry for the now-deleted android.ensure file. > > Bug: 803632 > Test: None > Change-Id: I481b0e2822aee2ac0b6d919aa0ee4a84954f12ed > Reviewed-on: https://chromium-review.googlesource.com/884233 > Reviewed-by: Tommy Nyquist <nyquist@chromium.org> > Commit-Queue: George Burgess <gbiv@chromium.org> > Cr-Commit-Position: refs/heads/master@{#531720} TBR=nyquist@chromium.org,gbiv@chromium.org Change-Id: I815260d16013dd8ebf56069e6335409f9e1cd7c4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 803632 Reviewed-on: https://chromium-review.googlesource.com/884981 Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#531756} [modify] https://crrev.com/daecbaf6c371c584547d1b8ac510b652614e2346/chrome/android/OWNERS
,
Jan 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/27ba93d5ec2f9701fae722ebae44291f6ef0e4f2 commit 27ba93d5ec2f9701fae722ebae44291f6ef0e4f2 Author: George Burgess IV <gbiv@chromium.org> Date: Thu Jan 25 01:49:00 2018 Reland "Let anyone update the Android profile version" This relands commit 9919631e216f0c36a766e1be65edb0c548dbdb48, which was reverted in daecbaf6c371c584547d1b8ac510b652614e2346, hopefully with 100% less presubmit breakage. :) Original change's description: > Let anyone update the Android profile version > > Including autorollers. > > This also removes an entry for the now-deleted android.ensure file. > > Bug: 803632 > Test: None > Change-Id: I481b0e2822aee2ac0b6d919aa0ee4a84954f12ed > Reviewed-on: https://chromium-review.googlesource.com/884233 > Reviewed-by: Tommy Nyquist <nyquist@chromium.org> > Commit-Queue: George Burgess <gbiv@chromium.org> > Cr-Commit-Position: refs/heads/master@{#531720} Bug: 803632 Test: None Change-Id: I4f0beac1a43b87f1b23476ed787e4a2bb791ce1f Reviewed-on: https://chromium-review.googlesource.com/885005 Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#531778} [modify] https://crrev.com/27ba93d5ec2f9701fae722ebae44291f6ef0e4f2/chrome/android/OWNERS [add] https://crrev.com/27ba93d5ec2f9701fae722ebae44291f6ef0e4f2/chrome/android/profiles/OWNERS
,
Feb 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/17a080eca576cfe3b29ab9509779536649c093da commit 17a080eca576cfe3b29ab9509779536649c093da Author: George Burgess IV <gbiv@chromium.org> Date: Fri Feb 02 19:27:42 2018 Add an autoroller for Android's AFDO profiles Android recently enabled AFDO. Having an autoroller to check for and apply new profiles seems better than hoping I'll remember to do so. Bug: 803632 Test: Ran locally; nop. Forced upload; got https://crrev.com/c/884481 Change-Id: Ifa6964978ee77b36fe5cd2019a4fbf18a5a24002 Reviewed-on: https://chromium-review.googlesource.com/884484 Commit-Queue: George Burgess <gbiv@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org> [add] https://crrev.com/17a080eca576cfe3b29ab9509779536649c093da/scripts/slave/recipes/android/afdo_auto_roller.expected/no_old_branch_to_delete.json [add] https://crrev.com/17a080eca576cfe3b29ab9509779536649c093da/scripts/slave/recipes/android/afdo_auto_roller.py [add] https://crrev.com/17a080eca576cfe3b29ab9509779536649c093da/scripts/slave/recipes/android/afdo_auto_roller.expected/remote_newer_rev.json [add] https://crrev.com/17a080eca576cfe3b29ab9509779536649c093da/scripts/slave/recipes/android/afdo_auto_roller.expected/remote_newer.json [add] https://crrev.com/17a080eca576cfe3b29ab9509779536649c093da/scripts/slave/recipes/android/afdo_auto_roller.expected/remote_much_newer.json [modify] https://crrev.com/17a080eca576cfe3b29ab9509779536649c093da/scripts/slave/README.recipes.md [add] https://crrev.com/17a080eca576cfe3b29ab9509779536649c093da/scripts/slave/recipes/android/afdo_auto_roller.expected/remote_same.json
,
Feb 6 2018
Blocked on https://bugs.chromium.org/p/skia/issues/detail?id=7582 . On the bright side, I have the autoroller script, so doing a roll a few times each week is very little effort for me.
,
Feb 12 2018
And https://bugs.chromium.org/p/skia/issues/detail?id=7582 is fixed. Leaving this open until I revert 17a080eca576cfe3b29ab9509779536649c093da, which I'll do after getting an autoroll email for >3345.
,
Feb 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/ca284c6308179cd8a3f594d4effc7dc23bbb6036 commit ca284c6308179cd8a3f594d4effc7dc23bbb6036 Author: George Burgess IV <gbiv@chromium.org> Date: Thu Feb 15 00:12:22 2018 Revert "Add an autoroller for Android's AFDO profiles" Apparently our skia friends were willing to do this for us (https://bugs.chromium.org/p/skia/issues/detail?id=7582). Thus, this autoroller is no longer necessary. This reverts commit 17a080eca576cfe3b29ab9509779536649c093da. Bug: 803632 Test: `./recipes.py test run` Change-Id: Ib63c429876e05f0940d8ce3714c80975f7223d58 Reviewed-on: https://chromium-review.googlesource.com/919768 Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> [delete] https://crrev.com/f384cd150738f5f23bafd5315ba6470f83fa9838/scripts/slave/recipes/android/afdo_auto_roller.expected/no_old_branch_to_delete.json [delete] https://crrev.com/f384cd150738f5f23bafd5315ba6470f83fa9838/scripts/slave/recipes/android/afdo_auto_roller.py [delete] https://crrev.com/f384cd150738f5f23bafd5315ba6470f83fa9838/scripts/slave/recipes/android/afdo_auto_roller.expected/remote_newer_rev.json [delete] https://crrev.com/f384cd150738f5f23bafd5315ba6470f83fa9838/scripts/slave/recipes/android/afdo_auto_roller.expected/remote_newer.json [delete] https://crrev.com/f384cd150738f5f23bafd5315ba6470f83fa9838/scripts/slave/recipes/android/afdo_auto_roller.expected/remote_much_newer.json [modify] https://crrev.com/ca284c6308179cd8a3f594d4effc7dc23bbb6036/scripts/slave/README.recipes.md [delete] https://crrev.com/f384cd150738f5f23bafd5315ba6470f83fa9838/scripts/slave/recipes/android/afdo_auto_roller.expected/remote_same.json
,
Feb 15 2018
ᕕ( ᐛ )ᕗ |
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Jan 22 2018