New issue
Advanced search Search tips

Issue 803631 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task



Sign in to add a comment

Deprecate |currentNavItem| from CRWWebController

Project Member Reported by danyao@chromium.org, Jan 18 2018

Issue description

WKNavigationDelegate callbacks in CRWWebController all assume that self.currentNavItem is the relevant navigation item associated with the given WKNavigation*. This assumption doesn't seem to hold in some cases and whatever the cause is, it is very likely a bug.

One known example is PassKitEGTest/testPassKitDownload. It triggers DCHECK_EQ(self.currentNavItem->GetUniqueID(), navigationContext->GetNavigationItemUniqueID()), if it is added to |webView:didFailProvisionalNavigation|.

The right way to find the relevant navigation item in a WKNavigationDelegate callback should be web::GetItemWithUniqueID([_navigationStates contextForNavigation:navigation]->GetNavigationItemUniqueID()); 
 
Project Member

Comment 1 by sheriffbot@chromium.org, Yesterday (46 hours ago)

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by danyao@chromium.org, Yesterday (46 hours ago)

Status: Available (was: Untriaged)

Sign in to add a comment