Fix static fields guarded by instance locks in code |
||
Issue description1. Read http://errorprone.info/bugpattern/StaticGuardedByInstance 2. Remove 'StaticGuardedByInstance' suppression for errorprone. 3. Fix or suppress each instance in code. 4. Upgrade 'StaticGuardedByInstance' to errorprone error to prevent future regressions.
,
Mar 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/83ef62e3220dbdc048c5970c09c7b258f55b70e4 commit 83ef62e3220dbdc048c5970c09c7b258f55b70e4 Author: Rob Buis <rob.buis@samsung.com> Date: Wed Mar 14 14:26:17 2018 Fix errorprone StaticGuardedByInstance warnings Fix errorprone StaticGuardedByInstance warnings and make sure it is treated as error after this CL. http://errorprone.info/bugpattern/StaticGuardedByInstance Bug: 803625 Change-Id: Ica786979670c8ec58c07691122e225acc56e62df Reviewed-on: https://chromium-review.googlesource.com/961041 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#543078} [modify] https://crrev.com/83ef62e3220dbdc048c5970c09c7b258f55b70e4/base/test/android/java/src/org/chromium/base/JavaHandlerThreadHelpers.java [modify] https://crrev.com/83ef62e3220dbdc048c5970c09c7b258f55b70e4/build/android/gyp/javac.py
,
Mar 14 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by rob.b...@samsung.com
, Mar 13 2018Status: Started (was: Available)