New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 803605 link

Starred by 1 user
Status: Fixed
Owner:
█ hongjunchoi@chromium.org
Last visit > 30 days ago
Closed: Jan 2018
Cc:
kpaulhamus@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Change CBORReader::Read() input parameter type

Project Member Reported by hongjunchoi@chromium.org, Jan 18 2018 
Change input parameter of CBORReader::Read() from const std::vector<uint8_t> to base::span.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/087c6d2d29c373ea015fbccde6a6dbb971f99fe4

commit 087c6d2d29c373ea015fbccde6a6dbb971f99fe4
Author: Jun Choi <hongjunchoi@chromium.org>
Date: Mon Jan 22 22:54:18 2018

Change CBORReader::Read parameter to base::span.

Change |input_data| parameter of CBORReader::Read() from const
std::vector<uint8_t>& to base::span<uint8_t const> to prevent
unnecessary intermediate copies.

Bug:  803605 
Change-Id: Id96df6a9c806bb39549f5696f73853faf71c3a94
Reviewed-on: https://chromium-review.googlesource.com/875006
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531038}
[modify] https://crrev.com/087c6d2d29c373ea015fbccde6a6dbb971f99fe4/components/cbor/cbor_reader.cc
[modify] https://crrev.com/087c6d2d29c373ea015fbccde6a6dbb971f99fe4/components/cbor/cbor_reader.h

Comment 2 by hongjunchoi@chromium.org, Jan 23 2018

Status: Fixed (was: Untriaged)
►

Sign in to add a comment