[SPv175+] Missing clip for scrollbars |
||
Issue descriptionFor the following case: <div style="overflow-y: scroll; width: 5px; height: 50px"></div> now we paint the vertical scrollbar overflowing the border box of the div in SPv175+. Currently the following tests fail in SPv175 because of this bug: fast/replaced/width100percent-textarea.html scrollbars/border-box-rect-clips-scrollbars.html There seems no existing clip property node for the purpose. Do we need to create another clip node (OverflowControlsClip)? Any idea?
,
Jan 18 2018
Interesting. What clipped the scrollbar in SPv1?
,
Jan 18 2018
,
Jan 18 2018
Ah ok. OverflowControlsClip sounds good to me.
,
Jan 19 2018
I remember we deliberately not creating one because the clip always apply to a single widget, and can be painted as a part of the drawing display item. That said, there is no reason why we can't create one (I think we should!). BTW don't forget to handle border radius. It will be slightly different from the overflow clip since it uses OUTER border radius instead of inner.
,
Jan 19 2018
Scroll controls may need multiple DrawingDisplayItems, especially for custom scrollbars. If we used DrawingDisplayItems to output such clip, we would need a pair of new DrawingDisplayItems which looks not good. Currently we don't apply border radius on overflow controls. I'm not sure if this is intentional.
,
Jan 19 2018
I think it is intentional to not border radius clip controls, because of the danger of making the controls unusable. Just consider 50% border radius on all corners. What would the scroll control look like?
,
Jan 22 2018
https://chromium-review.googlesource.com/c/chromium/src/+/875257 (wrongly associated with the meta bug) fixed this. |
||
►
Sign in to add a comment |
||
Comment 1 by wangxianzhu@chromium.org
, Jan 18 2018Status: Assigned (was: Available)