1. Read http://errorprone.info/bugpattern/MissingFail 2. Remove 'MissingFail' suppression for errorprone. 3. Fix or suppress each instance in code. 4. Upgrade 'MissingFail' to errorprone error to prevent future regressions.
The assigned owner "rob.buis@samsung.com" is not able to receive e-mails, please re-triage. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9183512b9470658f5e8e58614e176ebbec63c504 commit 9183512b9470658f5e8e58614e176ebbec63c504 Author: Rob Buis <rob.buis@samsung.com> Date: Mon Apr 23 21:08:52 2018 Fix errorprone MissingFail warnings Fix errorprone MissingFail warnings and make sure it is treated as error after this CL. http://errorprone.info/bugpattern/MissingFail Bug: 803589 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I26bb2b58844a9a517e27cc25e334e529eaa6f06a Reviewed-on: https://chromium-review.googlesource.com/960422 Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Reviewed-by: Helen Li <xunjieli@chromium.org> Reviewed-by: Peter Wen <wnwen@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#552830} [modify] https://crrev.com/9183512b9470658f5e8e58614e176ebbec63c504/base/android/junit/src/org/chromium/base/PromiseTest.java [modify] https://crrev.com/9183512b9470658f5e8e58614e176ebbec63c504/build/android/gyp/javac.py [modify] https://crrev.com/9183512b9470658f5e8e58614e176ebbec63c504/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridgeTest.java [modify] https://crrev.com/9183512b9470658f5e8e58614e176ebbec63c504/chrome/android/javatests/src/org/chromium/chrome/browser/push_messaging/PushMessagingTest.java [modify] https://crrev.com/9183512b9470658f5e8e58614e176ebbec63c504/components/cronet/android/BUILD.gn [modify] https://crrev.com/9183512b9470658f5e8e58614e176ebbec63c504/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetFixedModeOutputStreamTest.java [modify] https://crrev.com/9183512b9470658f5e8e58614e176ebbec63c504/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetURLStreamHandlerFactoryTest.java
wnwen@ can you confirm if this is fixed and close it out? Thanks!
Yep! Rob fixed it. Not sure why his email is bouncing...
Comment 1 by rob.b...@samsung.com
, Apr 3 2018Status: Assigned (was: Available)