1. Read http://errorprone.info/bugpattern/MissingOverride 2. Remove 'MissingOverride' suppression for errorprone. 3. Fix or suppress each instance in code. 4. Upgrade 'MissingOverride' to errorprone error to prevent future regressions.
The following revision refers to this bug: https://chrome-internal.googlesource.com/clank/internal/apps/+/f132a334415f39da301da9f80d9c007a7d77388b commit f132a334415f39da301da9f80d9c007a7d77388b Author: Peter Wen <wnwen@google.com> Date: Wed Feb 21 20:49:46 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d567da5d6dc4962bfcdaca2dbf020ce5858625d8 commit d567da5d6dc4962bfcdaca2dbf020ce5858625d8 Author: Rob Buis <rob.buis@samsung.com> Date: Wed Feb 21 22:54:09 2018 Fix errorprone MissingOverride warnings Fix errorprone MissingOverride warnings and make sure it is treated as error after this CL. http://errorprone.info/bugpattern/MissingOverride Bug: 803587 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I31933654c42139781d719315bbe20689756e90ba Reviewed-on: https://chromium-review.googlesource.com/911869 Reviewed-by: Helen Li <xunjieli@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Peter Wen <wnwen@chromium.org> Reviewed-by: Tao Bai <michaelbai@chromium.org> Commit-Queue: Rob Buis <rob.buis@samsung.com> Cr-Commit-Position: refs/heads/master@{#538238} [modify] https://crrev.com/d567da5d6dc4962bfcdaca2dbf020ce5858625d8/android_webview/glue/java/src/com/android/webview/chromium/FontPreloadingWorkaround.java [modify] https://crrev.com/d567da5d6dc4962bfcdaca2dbf020ce5858625d8/base/test/android/junit/src/org/chromium/base/test/BaseRobolectricTestRunner.java [modify] https://crrev.com/d567da5d6dc4962bfcdaca2dbf020ce5858625d8/build/android/gyp/javac.py [modify] https://crrev.com/d567da5d6dc4962bfcdaca2dbf020ce5858625d8/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java [modify] https://crrev.com/d567da5d6dc4962bfcdaca2dbf020ce5858625d8/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDialog.java [modify] https://crrev.com/d567da5d6dc4962bfcdaca2dbf020ce5858625d8/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/keyboard/KeyboardEdit.java [modify] https://crrev.com/d567da5d6dc4962bfcdaca2dbf020ce5858625d8/components/cronet/android/java/src/org/chromium/net/impl/BidirectionalStreamBuilderImpl.java [modify] https://crrev.com/d567da5d6dc4962bfcdaca2dbf020ce5858625d8/components/cronet/android/java/src/org/chromium/net/impl/CronetBidirectionalStream.java [modify] https://crrev.com/d567da5d6dc4962bfcdaca2dbf020ce5858625d8/components/cronet/android/java/src/org/chromium/net/impl/CronetMetrics.java [modify] https://crrev.com/d567da5d6dc4962bfcdaca2dbf020ce5858625d8/components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java [modify] https://crrev.com/d567da5d6dc4962bfcdaca2dbf020ce5858625d8/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java [modify] https://crrev.com/d567da5d6dc4962bfcdaca2dbf020ce5858625d8/components/cronet/android/test/javatests/src/org/chromium/net/TestBidirectionalStreamCallback.java [modify] https://crrev.com/d567da5d6dc4962bfcdaca2dbf020ce5858625d8/components/cronet/android/test/javatests/src/org/chromium/net/TestUploadDataProvider.java [modify] https://crrev.com/d567da5d6dc4962bfcdaca2dbf020ce5858625d8/components/cronet/android/test/javatests/src/org/chromium/net/TestUrlRequestCallback.java [modify] https://crrev.com/d567da5d6dc4962bfcdaca2dbf020ce5858625d8/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/MessageLoopTest.java [modify] https://crrev.com/d567da5d6dc4962bfcdaca2dbf020ce5858625d8/components/cronet/android/test/src/org/chromium/net/Http2TestServer.java
Great work! Thank you Rob. These are some longstanding issues that will no longer pop up again since they are elevated to errors for new code.
Comment 1 by bugdroid1@chromium.org
, Feb 21 2018