New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 803532 link

Starred by 3 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----

Blocking:
issue 703263



Sign in to add a comment

UIResourceLostBeforeCommit.RunSingleThread_DelegatingRenderer is flaky

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Jan 18 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of smcgruer@google.com

UIResourceLostBeforeCommit.RunSingleThread_DelegatingRenderer is flaky on Win7 Tests (dbg)(1)

Builders failed on: 
- Win7 Tests (dbg)(1): 
  https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29

Example failure: https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/65865

[ RUN      ] UIResourceLostBeforeCommit.RunSingleThread_DelegatingRenderer
[5228:2820:0118/091855.657:3895454:FATAL:layer_tree_host_unittest_context.cc(1305)] Check failed: false.

Flake dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=UIResourceLostBeforeCommit.RunSingleThread_DelegatingRenderer&testType=cc_unittests

 

Comment 1 by danakj@chromium.org, Jan 18 2018

Blocking: 703263

Comment 2 by danakj@chromium.org, Jan 18 2018

Cc: powei@chromium.org ccameron@chromium.org
This flake won't be specific to windows.
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25ddb137581f80010f5c9665806652ca2e231eb4

commit 25ddb137581f80010f5c9665806652ca2e231eb4
Author: Stephen McGruer <smcgruer@chromium.org>
Date: Thu Jan 18 19:10:15 2018

Disable UIResourceLostBeforeCommit.RunSingleThread_... on Win 7 debug

UIResourceLostBeforeCommit.RunSingleThread_DelegatingRenderer is flaky
on Win7 Tests (dbg).

Bug: 803532
Change-Id: I5fb9cc8f5b1a0b9b0888b8d378c7e00a96f9e104

TBR=danakj@chromium.org,vmiura@chromium.org

Change-Id: I5fb9cc8f5b1a0b9b0888b8d378c7e00a96f9e104
Reviewed-on: https://chromium-review.googlesource.com/874571
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530220}
[modify] https://crrev.com/25ddb137581f80010f5c9665806652ca2e231eb4/cc/trees/layer_tree_host_unittest_context.cc

Cc: danakj@chromium.org vmi...@chromium.org
Status: Assigned (was: Available)
It is only showing up as flaky on the Windows bot so far, but feel free to disable it on more platforms if you are concerned.
Status: Available (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c208a9000f0fd378956a3e415befaa689a107d4b

commit c208a9000f0fd378956a3e415befaa689a107d4b
Author: Jeremy Roman <jbroman@chromium.org>
Date: Mon Feb 12 16:37:44 2018

Correct disable condition for UIResourceLostBeforeCommit.RunSingleThread_DelegatingRenderer.

It's still failing:
  https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%28dbg%29%281%29/66304

The previous condition disabled it on non-Windows debug, but Windows debug was intended:
  https://chromium.googlesource.com/chromium/src/+/25ddb137581f80010f5c9665806652ca2e231eb4

Bug: 803532
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I623fa8cfab38e920d5398594b56918a43054bfef
Tbr: smcgruer@chromium.org,danakj@chromium.org
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/913968
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536099}
[modify] https://crrev.com/c208a9000f0fd378956a3e415befaa689a107d4b/cc/trees/layer_tree_host_unittest_context.cc

Also saw this on Linux:
https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_chromium_tsan_rel_ng/286019
[ RUN      ] UIResourceLostBeforeCommit.RunSingleThread_DelegatingRenderer
../../cc/trees/layer_tree_host_unittest_context.cc:1326: Failure
Expected: (0u) != (impl->ResourceIdForUIResource(test_id1_)), actual: 0 vs 0
[  FAILED  ] UIResourceLostBeforeCommit.RunSingleThread_DelegatingRenderer (72 ms)

Comment 8 by sahel@chromium.org, Apr 27 2018

 Issue 837409  has been merged into this issue.
Project Member

Comment 9 by chromium...@appspot.gserviceaccount.com, Apr 27 2018

Labels: Sheriff-Chromium
Detected 3 new flakes for test/step "UIResourceLostBeforeCommit.RunSingleThread_DelegatingRenderer". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNySAsSBUZsYWtlIj1VSVJlc291cmNlTG9zdEJlZm9yZUNvbW1pdC5SdW5TaW5nbGVUaHJlYWRfRGVsZWdhdGluZ1JlbmRlcmVyDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Summary: UIResourceLostBeforeCommit.RunSingleThread_DelegatingRenderer is flaky (was: UIResourceLostBeforeCommit.RunSingleThread_DelegatingRenderer is flaky on Win7 Tests (dbg)(1))
Recent set of flakes have been exclusively on linux_chromium_tsan_rel_ng
Project Member

Comment 11 by chromium...@appspot.gserviceaccount.com, Apr 28 2018

Detected 3 new flakes for test/step "UIResourceLostBeforeCommit.RunSingleThread_DelegatingRenderer". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNySAsSBUZsYWtlIj1VSVJlc291cmNlTG9zdEJlZm9yZUNvbW1pdC5SdW5TaW5nbGVUaHJlYWRfRGVsZWdhdGluZ1JlbmRlcmVyDA. This message was posted automatically by the chromium-try-flakes app.

Comment 12 by sahel@chromium.org, Apr 30 2018

https://chromium-review.googlesource.com/c/chromium/src/+/1034844 disables the test on linux_chromium_tsan_rel_ng.
Project Member

Comment 13 by bugdroid1@chromium.org, Apr 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9857640b424182a76fe600e29fbf54ab3d8e46a

commit d9857640b424182a76fe600e29fbf54ab3d8e46a
Author: Sahel Sharify <sahel@chromium.org>
Date: Mon Apr 30 15:06:40 2018

disable UIResourceLostBeforeCommit.RunSingleThread_DelegatingRenderer.

This cl disables UIResourceLostBeforeCommit.RunSingleThread_DelegatingRenderer
on linux tsan.

TBR=danakj@chromium.org,vmiura@chromium.org

Bug: 803532
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I8c74bbe6593839f5232edda101c334d771fb6d0c
Reviewed-on: https://chromium-review.googlesource.com/1034844
Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org>
Reviewed-by: Sahel Sharifymoghaddam <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554754}
[modify] https://crrev.com/d9857640b424182a76fe600e29fbf54ab3d8e46a/cc/trees/layer_tree_host_unittest_context.cc

Labels: -Sheriff-Chromium
Removing from sheriff queue given #13
Components: Internals>Compositing
Status: Untriaged (was: Available)
Status: Available (was: Untriaged)
Available as I assume we want to re-enable this test.

Sign in to add a comment