New issue
Advanced search Search tips

Issue 803511 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Task

Blocking:
issue 776445



Sign in to add a comment

Migrate mtpd to platform2

Project Member Reported by ejcaruso@chromium.org, Jan 18 2018

Issue description

After talking with thestig@ it doesn't look like there's any reason this needs to exist in platform/, so we can include it in platform2/ and potentially simplify future CLs that need to modify it.
 
Blocking: 776445
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/3f5ecd8fce3b143e9eab174af2cd2f3bd6c2fa39

commit 3f5ecd8fce3b143e9eab174af2cd2f3bd6c2fa39
Author: Eric Caruso <ejcaruso@chromium.org>
Date: Fri Jan 19 01:40:51 2018

mtpd: move from platform/ to platform2/

This was imported as of change 8c83d6b36cce and so we can start
building out of platform2/ to prepare for getting rid of the git
repo from platform/.

BUG= chromium:803511 
TEST=emerge

Change-Id: Ied49176949ce910eb38a3c73026990c006288d8e
Reviewed-on: https://chromium-review.googlesource.com/874771
Commit-Ready: Eric Caruso <ejcaruso@chromium.org>
Tested-by: Eric Caruso <ejcaruso@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/3f5ecd8fce3b143e9eab174af2cd2f3bd6c2fa39/chromeos-base/mtpd/mtpd-9999.ebuild

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/1cc4cd4a2346b92c6a15b55414283cf2121a93ff

commit 1cc4cd4a2346b92c6a15b55414283cf2121a93ff
Author: Eric Caruso <ejcaruso@chromium.org>
Date: Fri Jan 19 01:40:29 2018

mtpd: fix up some .gyp file paths

Now that mtpd resides in platform2 we can use a relative path
internal to platform2 to get stuff from common-mk.

BUG= chromium:803511 
TEST=emerge

Change-Id: Ic2e9b80eae36fb4ba12175995cc99b0f6fe3b87c
Reviewed-on: https://chromium-review.googlesource.com/874750
Commit-Ready: Eric Caruso <ejcaruso@chromium.org>
Tested-by: Eric Caruso <ejcaruso@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/1cc4cd4a2346b92c6a15b55414283cf2121a93ff/mtpd/mtpd.gyp

Status: Fixed (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 26 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/manifest-internal/+/857a53a34b7abf2b4794e500117e312987aa8e1d

commit 857a53a34b7abf2b4794e500117e312987aa8e1d
Author: Mike Frysinger <vapier@chromium.org>
Date: Fri Jan 26 03:23:50 2018

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/manifest/+/af56f1094fc8045a09750bc2500fb67ac2726213

commit af56f1094fc8045a09750bc2500fb67ac2726213
Author: Mike Frysinger <vapier@chromium.org>
Date: Fri Jan 26 03:23:56 2018

drop mtpd (now in platform2)

BUG= chromium:803511 
TEST=precq passes

Change-Id: Ib4ae2ad3db6041012b0ed34177bd8afabe799388
Reviewed-on: https://chromium-review.googlesource.com/879325
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[modify] https://crrev.com/af56f1094fc8045a09750bc2500fb67ac2726213/full.xml

Cc: yawano@chromium.org nya@chromium.org derat@chromium.org amistry@chromium.org ejcaruso@chromium.org
 Issue 789201  has been merged into this issue.

Sign in to add a comment