New issue
Advanced search Search tips

Issue 803506 link

Starred by 1 user
Status: Fixed
Owner:
mek@chromium.org
Closed: Jan 2018
Cc:
dmu...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Several blob histograms are reporting incorrect data

Project Member Reported by mek@chromium.org, Jan 18 2018 
Both the Storage.Blob.TotalSize and Storage.BlobItemSize.* histograms are reporting incorrect data. The first neglects to include almost all memory usage of a blob, while the second one incorrectly subtracts "offset" from all sizes.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/600477e63cccafefa3adeb114f57a213524c2cd8

commit 600477e63cccafefa3adeb114f57a213524c2cd8
Author: Marijn Kruisselbrink <mek@chromium.org>
Date: Thu Jan 18 20:13:18 2018

Fix several blob histograms that were broken over a year ago.

Specifically this fixes Storage.Blob.TotalSize to take into account size
of bytes elements again (broken in https://crrev.com/432960).

And fixes the various Storage.BlobItemSize.* histograms to not subtract
the offset of the size (length is already relative to offset, so
subtracting offset again doesn't make sense) (broken in
https://crrev.com/315702).

Bug:  803506 
Change-Id: I2f803ac1c574b9491b7e05fc2b96e82029d51c78
Reviewed-on: https://chromium-review.googlesource.com/874410
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530250}
[modify] https://crrev.com/600477e63cccafefa3adeb114f57a213524c2cd8/storage/browser/blob/blob_storage_context.cc

Comment 2 by mek@chromium.org, Jan 19 2018

Status: Fixed (was: Started)
►

Sign in to add a comment