New issue
Advanced search Search tips

Issue 803503 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: ----



Sign in to add a comment

Clean up WebStateObserver callback hacks for placeholder URL

Project Member Reported by danyao@chromium.org, Jan 18 2018

Issue description

Placeholder URL is used to insert a WKBackForwardList item for native content (e.g. NTP, native error page) and WebUI. See go/bling-navigation-experiment.

Several hacks have been added and need rethinking through:
1) WebStateImpl: omits OnNavigation(Started|Finished) callbacks when NavigationContext::GetUrl() returns placeholder URL.
2) CRWWebController |loadNativeErrorForNavigationItem:| changes NavigationContext URL from placeholder to non-placeholder to force WebStateObserver callbacks for native error.

1) is needed to make sure WebUI and |loadCurrentURLInNativeView| don't generate two sets of navigation callbacks. However, for native error view, the navigation finish / loading stopped callbacks are never generated on the initial navigation so must be done when the native error view is presented upon the completion of the placeholder navigation.

There is no inherent reason why the code paths for the three cases can't be unified.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Yesterday (46 hours ago)

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by danyao@chromium.org, Yesterday (46 hours ago)

Status: Available (was: Untriaged)

Sign in to add a comment