It is possible that we will release modern design in normal Chrome. We should have a flag to facilitate this and change relevant Chrome Home checks with a check for if modern design is enabled.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5b7f1d69f1eb334e64dfff4b42fde77e37e98b80 commit 5b7f1d69f1eb334e64dfff4b42fde77e37e98b80 Author: Matthew Jones <mdjones@chromium.org> Date: Tue Jan 23 00:37:25 2018 [Modern] Switch Chrome Home checks to Chrome Modern checks where relevant This change adds a new flag to enable modern design in normal Chrome. The relevant checks that were previously gated on Chrome Home have been replaced by checks for this feature. Modern is considered enabled if Chrome Home is enabled. BUG= 803500 , 803087 Change-Id: I3c5f958483d29c230a1044f12604988659808238 Reviewed-on: https://chromium-review.googlesource.com/874293 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#531088} [modify] https://crrev.com/5b7f1d69f1eb334e64dfff4b42fde77e37e98b80/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java [modify] https://crrev.com/5b7f1d69f1eb334e64dfff4b42fde77e37e98b80/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkAddEditFolderActivity.java [modify] https://crrev.com/5b7f1d69f1eb334e64dfff4b42fde77e37e98b80/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkEditActivity.java [modify] https://crrev.com/5b7f1d69f1eb334e64dfff4b42fde77e37e98b80/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkFolderSelectActivity.java [modify] https://crrev.com/5b7f1d69f1eb334e64dfff4b42fde77e37e98b80/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkItemRow.java [modify] https://crrev.com/5b7f1d69f1eb334e64dfff4b42fde77e37e98b80/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkManager.java [modify] https://crrev.com/5b7f1d69f1eb334e64dfff4b42fde77e37e98b80/chrome/android/java/src/org/chromium/chrome/browser/compositor/LayerTitleCache.java [modify] https://crrev.com/5b7f1d69f1eb334e64dfff4b42fde77e37e98b80/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchQuickActionControl.java [modify] https://crrev.com/5b7f1d69f1eb334e64dfff4b42fde77e37e98b80/chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/TabListSceneLayer.java [modify] https://crrev.com/5b7f1d69f1eb334e64dfff4b42fde77e37e98b80/chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ToolbarSceneLayer.java [modify] https://crrev.com/5b7f1d69f1eb334e64dfff4b42fde77e37e98b80/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadItemView.java [modify] https://crrev.com/5b7f1d69f1eb334e64dfff4b42fde77e37e98b80/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java [modify] https://crrev.com/5b7f1d69f1eb334e64dfff4b42fde77e37e98b80/chrome/android/java/src/org/chromium/chrome/browser/download/ui/FilterAdapter.java [modify] https://crrev.com/5b7f1d69f1eb334e64dfff4b42fde77e37e98b80/chrome/android/java/src/org/chromium/chrome/browser/download/ui/OfflineGroupHeaderView.java [modify] https://crrev.com/5b7f1d69f1eb334e64dfff4b42fde77e37e98b80/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryItemView.java [modify] https://crrev.com/5b7f1d69f1eb334e64dfff4b42fde77e37e98b80/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManager.java [modify] https://crrev.com/5b7f1d69f1eb334e64dfff4b42fde77e37e98b80/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java [modify] https://crrev.com/5b7f1d69f1eb334e64dfff4b42fde77e37e98b80/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBar.java [modify] https://crrev.com/5b7f1d69f1eb334e64dfff4b42fde77e37e98b80/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java [modify] https://crrev.com/5b7f1d69f1eb334e64dfff4b42fde77e37e98b80/chrome/android/java/src/org/chromium/chrome/browser/omnibox/SuggestionView.java [modify] https://crrev.com/5b7f1d69f1eb334e64dfff4b42fde77e37e98b80/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivityLocationBarLayout.java [modify] https://crrev.com/5b7f1d69f1eb334e64dfff4b42fde77e37e98b80/chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarView.java [modify] https://crrev.com/5b7f1d69f1eb334e64dfff4b42fde77e37e98b80/chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileRenderer.java [modify] https://crrev.com/5b7f1d69f1eb334e64dfff4b42fde77e37e98b80/chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java [modify] https://crrev.com/5b7f1d69f1eb334e64dfff4b42fde77e37e98b80/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarModelImpl.java [modify] https://crrev.com/5b7f1d69f1eb334e64dfff4b42fde77e37e98b80/chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java [modify] https://crrev.com/5b7f1d69f1eb334e64dfff4b42fde77e37e98b80/chrome/android/java/src/org/chromium/chrome/browser/widget/accessibility/AccessibilityTabModelListItem.java [modify] https://crrev.com/5b7f1d69f1eb334e64dfff4b42fde77e37e98b80/chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectableItemView.java [modify] https://crrev.com/5b7f1d69f1eb334e64dfff4b42fde77e37e98b80/chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectableListLayout.java [modify] https://crrev.com/5b7f1d69f1eb334e64dfff4b42fde77e37e98b80/chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectableListToolbar.java [modify] https://crrev.com/5b7f1d69f1eb334e64dfff4b42fde77e37e98b80/chrome/browser/about_flags.cc [modify] https://crrev.com/5b7f1d69f1eb334e64dfff4b42fde77e37e98b80/chrome/browser/android/chrome_feature_list.cc [modify] https://crrev.com/5b7f1d69f1eb334e64dfff4b42fde77e37e98b80/chrome/browser/android/chrome_feature_list.h [modify] https://crrev.com/5b7f1d69f1eb334e64dfff4b42fde77e37e98b80/chrome/browser/android/feature_utilities.cc [modify] https://crrev.com/5b7f1d69f1eb334e64dfff4b42fde77e37e98b80/chrome/browser/android/feature_utilities.h [modify] https://crrev.com/5b7f1d69f1eb334e64dfff4b42fde77e37e98b80/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/5b7f1d69f1eb334e64dfff4b42fde77e37e98b80/chrome/browser/flag_descriptions.h [modify] https://crrev.com/5b7f1d69f1eb334e64dfff4b42fde77e37e98b80/chrome/browser/search_provider_logos/logo_service_factory.cc [modify] https://crrev.com/5b7f1d69f1eb334e64dfff4b42fde77e37e98b80/tools/metrics/histograms/enums.xml
Can this be marked as "Fixed" or should we leave it open in case the flag implementation needs modifications?
I don't think the flag will need modifications, but there may be usages that still need to be switched. We can have a separate bug for that though.
Comment 1 by twelling...@chromium.org
, Jan 18 2018