New issue
Advanced search Search tips

Issue 803494 link

Starred by 8 users
Status: Started
Owner:
orphis@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----

Blocked on:
issue webrtc:9143
issue webrtc:9141
Blocking:
issue 700916



Sign in to add a comment

Implement RTCRtpSender.get/setParameters()

Project Member Reported by orphis@chromium.org, Jan 18 2018 
Feature description: Implement RTCRtpSender.get/setParameters()

Eng owner: orphis@chromium.org
Product owner: juberti@chromium.org

Design doc: https://w3c.github.io/webrtc-pc/#rtcrtpsender-interface

Are you planning on experimenting before launch? no
Any new strings? no
Any implications for Google webservices (i.e. sync, translate)? no
Binary size? Not much
Do the existing perf tests exercise all aspects of your new feature(s)? no
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4abdeef44e337bb0caecd716ee17249aae737ff

commit e4abdeef44e337bb0caecd716ee17249aae737ff
Author: Florent Castelli <orphis@chromium.org>
Date: Fri Mar 09 11:48:28 2018

Add RTCRtpSender.getParameters() and mock setParameters()

Add the getParameters() function forwarding all the values
that are implemented in WebRTC to the Javascript layer.
Other properties that exist will be loaded for future use,
but not passed to the Javascript layer.
Currently behind RuntimeEnabled=RTCRtpSenderParameters.

Bug: 803494
Change-Id: Icd1c1ea58fd1ad3d50a46e97db3026837381c7b6
Reviewed-on: https://chromium-review.googlesource.com/919082
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Florent Castelli <orphis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542086}
[modify] https://crrev.com/e4abdeef44e337bb0caecd716ee17249aae737ff/content/renderer/BUILD.gn
[add] https://crrev.com/e4abdeef44e337bb0caecd716ee17249aae737ff/content/renderer/media/webrtc/rtc_rtp_parameters.cc
[add] https://crrev.com/e4abdeef44e337bb0caecd716ee17249aae737ff/content/renderer/media/webrtc/rtc_rtp_parameters.h
[add] https://crrev.com/e4abdeef44e337bb0caecd716ee17249aae737ff/content/renderer/media/webrtc/rtc_rtp_parameters_unittest.cc
[modify] https://crrev.com/e4abdeef44e337bb0caecd716ee17249aae737ff/content/renderer/media/webrtc/rtc_rtp_sender.cc
[modify] https://crrev.com/e4abdeef44e337bb0caecd716ee17249aae737ff/content/renderer/media/webrtc/rtc_rtp_sender.h
[modify] https://crrev.com/e4abdeef44e337bb0caecd716ee17249aae737ff/content/test/BUILD.gn
[modify] https://crrev.com/e4abdeef44e337bb0caecd716ee17249aae737ff/third_party/WebKit/LayoutTests/external/wpt/webrtc/interfaces.https-expected.txt
[add] https://crrev.com/e4abdeef44e337bb0caecd716ee17249aae737ff/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-getParameters.html
[modify] https://crrev.com/e4abdeef44e337bb0caecd716ee17249aae737ff/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/e4abdeef44e337bb0caecd716ee17249aae737ff/third_party/WebKit/Source/modules/modules_idl_files.gni
[add] https://crrev.com/e4abdeef44e337bb0caecd716ee17249aae737ff/third_party/WebKit/Source/modules/peerconnection/RTCRtcpParameters.idl
[add] https://crrev.com/e4abdeef44e337bb0caecd716ee17249aae737ff/third_party/WebKit/Source/modules/peerconnection/RTCRtpCodecParameters.idl
[add] https://crrev.com/e4abdeef44e337bb0caecd716ee17249aae737ff/third_party/WebKit/Source/modules/peerconnection/RTCRtpEncodingParameters.idl
[add] https://crrev.com/e4abdeef44e337bb0caecd716ee17249aae737ff/third_party/WebKit/Source/modules/peerconnection/RTCRtpHeaderExtensionParameters.idl
[add] https://crrev.com/e4abdeef44e337bb0caecd716ee17249aae737ff/third_party/WebKit/Source/modules/peerconnection/RTCRtpParameters.idl
[modify] https://crrev.com/e4abdeef44e337bb0caecd716ee17249aae737ff/third_party/WebKit/Source/modules/peerconnection/RTCRtpSender.cpp
[modify] https://crrev.com/e4abdeef44e337bb0caecd716ee17249aae737ff/third_party/WebKit/Source/modules/peerconnection/RTCRtpSender.h
[modify] https://crrev.com/e4abdeef44e337bb0caecd716ee17249aae737ff/third_party/WebKit/Source/modules/peerconnection/RTCRtpSender.idl
[modify] https://crrev.com/e4abdeef44e337bb0caecd716ee17249aae737ff/third_party/WebKit/Source/platform/runtime_enabled_features.json5
[modify] https://crrev.com/e4abdeef44e337bb0caecd716ee17249aae737ff/third_party/WebKit/Source/platform/testing/TestingPlatformSupportWithWebRTC.cpp
[add] https://crrev.com/e4abdeef44e337bb0caecd716ee17249aae737ff/third_party/WebKit/public/platform/WebRTCRtpParameters.h
[modify] https://crrev.com/e4abdeef44e337bb0caecd716ee17249aae737ff/third_party/WebKit/public/platform/WebRTCRtpSender.h
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd508f2124fe8f1eff1310026f5411f53f2776c4

commit cd508f2124fe8f1eff1310026f5411f53f2776c4
Author: Florent Castelli <orphis@chromium.org>
Date: Wed Mar 14 17:36:58 2018

Move ConvertToWebKitRTCError to a separate file

This function is shared with the upcoming RTCRtpSender.setParameters().

Bug: 803494
Change-Id: I4ec8412c63ee4abd98ffc458df73bc9b45e72e87
Reviewed-on: https://chromium-review.googlesource.com/962604
Commit-Queue: Florent Castelli <orphis@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543119}
[modify] https://crrev.com/cd508f2124fe8f1eff1310026f5411f53f2776c4/content/renderer/BUILD.gn
[add] https://crrev.com/cd508f2124fe8f1eff1310026f5411f53f2776c4/content/renderer/media/webrtc/rtc_error.cc
[add] https://crrev.com/cd508f2124fe8f1eff1310026f5411f53f2776c4/content/renderer/media/webrtc/rtc_error.h
[modify] https://crrev.com/cd508f2124fe8f1eff1310026f5411f53f2776c4/content/renderer/media/webrtc/rtc_peer_connection_handler.cc

Comment 3 by orphis@chromium.org, Apr 12 2018

Blockedon: webrtc:9143 webrtc:9141
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/856e3eca2bcef720090006c9e1f7471952226c7a

commit 856e3eca2bcef720090006c9e1f7471952226c7a
Author: Florent Castelli <orphis@chromium.org>
Date: Tue Apr 17 21:16:52 2018

Implement RTCRtpSender.setParameters()

Only parameters encodings.active, encodings.maxBitrate and
encodings.priority are effectively working and connected
to the native layer.

Due to discrepancies between the WebRTC specification and the
native layers, the objects are not passed back from Javascript
and converted to native directly, but instead the relevant fields
are converted and patch the last result from getParameters().
If any read-only field is implemented by the native layer but not
exposed yet to Javascript, they will be left as is and won't cause
any InvalidModificationError.

Bug: 803494
Change-Id: Ia59734e5c3eddb54e5a1448a04fdcefe5a41a279
Reviewed-on: https://chromium-review.googlesource.com/969124
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Florent Castelli <orphis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551477}
[modify] https://crrev.com/856e3eca2bcef720090006c9e1f7471952226c7a/content/renderer/media/webrtc/rtc_rtp_parameters.cc
[modify] https://crrev.com/856e3eca2bcef720090006c9e1f7471952226c7a/content/renderer/media/webrtc/rtc_rtp_parameters.h
[modify] https://crrev.com/856e3eca2bcef720090006c9e1f7471952226c7a/content/renderer/media/webrtc/rtc_rtp_parameters_unittest.cc
[modify] https://crrev.com/856e3eca2bcef720090006c9e1f7471952226c7a/content/renderer/media/webrtc/rtc_rtp_sender.cc
[modify] https://crrev.com/856e3eca2bcef720090006c9e1f7471952226c7a/content/renderer/media/webrtc/rtc_rtp_sender.h
[modify] https://crrev.com/856e3eca2bcef720090006c9e1f7471952226c7a/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/856e3eca2bcef720090006c9e1f7471952226c7a/third_party/WebKit/LayoutTests/fast/peerconnection/RTCRtpSender-setParameters-crash.html
[add] https://crrev.com/856e3eca2bcef720090006c9e1f7471952226c7a/third_party/WebKit/LayoutTests/fast/peerconnection/RTCRtpSender-setParameters-expected.txt
[add] https://crrev.com/856e3eca2bcef720090006c9e1f7471952226c7a/third_party/WebKit/LayoutTests/fast/peerconnection/RTCRtpSender-setParameters.html
[modify] https://crrev.com/856e3eca2bcef720090006c9e1f7471952226c7a/third_party/blink/public/platform/web_rtc_rtp_sender.h
[modify] https://crrev.com/856e3eca2bcef720090006c9e1f7471952226c7a/third_party/blink/renderer/modules/peerconnection/BUILD.gn
[modify] https://crrev.com/856e3eca2bcef720090006c9e1f7471952226c7a/third_party/blink/renderer/modules/peerconnection/rtc_rtp_sender.cc
[modify] https://crrev.com/856e3eca2bcef720090006c9e1f7471952226c7a/third_party/blink/renderer/modules/peerconnection/rtc_rtp_sender.h
[add] https://crrev.com/856e3eca2bcef720090006c9e1f7471952226c7a/third_party/blink/renderer/modules/peerconnection/rtc_void_request_script_promise_resolver_impl.cc
[add] https://crrev.com/856e3eca2bcef720090006c9e1f7471952226c7a/third_party/blink/renderer/modules/peerconnection/rtc_void_request_script_promise_resolver_impl.h
[modify] https://crrev.com/856e3eca2bcef720090006c9e1f7471952226c7a/third_party/blink/renderer/platform/testing/testing_platform_support_with_web_rtc.cc

Comment 5 by hrun...@gmail.com, Apr 24 2018 

@orphis, I was exploring `.setParameters` API and found out that your change has landed into master. But for some reason I don't see the method in `RTCRtpSender` prototype. Is it behind some flag? Can you advice me on how to try out your implementation in Canary?

Thanks a lot!

Comment 6 by hrun...@gmail.com, Apr 27 2018 

For anyone interested, I've found the parameter myself, it is:
--enable-blink-features=RTCRtpSenderParameters
Project Member

Comment 7 by bugdroid1@chromium.org, May 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0215cd0936839c1542ae07574204cbc67976407a

commit 0215cd0936839c1542ae07574204cbc67976407a
Author: Florent Castelli <orphis@chromium.org>
Date: Mon May 07 17:00:43 2018

Mark RTCRtpSender-setParameters-crash test as possibly passing

In case the related bug gets fixed in WebRTC, we don't want
any build failure when it is rolled out to Chrome.

Bug: 803494
Change-Id: I3001c566049067182b1123d2f452f8a8297d5525
Reviewed-on: https://chromium-review.googlesource.com/1047665
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Florent Castelli <orphis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556474}
[modify] https://crrev.com/0215cd0936839c1542ae07574204cbc67976407a/third_party/WebKit/LayoutTests/TestExpectations
Project Member

Comment 8 by bugdroid1@chromium.org, May 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab67c16a1445518da7fb3409de2424f198a25de3

commit ab67c16a1445518da7fb3409de2424f198a25de3
Author: Florent Castelli <orphis@chromium.org>
Date: Tue May 08 17:32:21 2018

Invalidate LastReturnedParameters slot after setParameters()

The standard got updated to invalidate the internal slot after
a setParameters() call to enforce having a single matching
getParameters() call.

Bug: 803494
Change-Id: Ia6b1483b908c3ef29c31fdcf2fb8014735cea322
Reviewed-on: https://chromium-review.googlesource.com/1047426
Commit-Queue: Florent Castelli <orphis@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556853}
[modify] https://crrev.com/ab67c16a1445518da7fb3409de2424f198a25de3/third_party/WebKit/LayoutTests/fast/peerconnection/RTCRtpSender-setParameters-expected.txt
[modify] https://crrev.com/ab67c16a1445518da7fb3409de2424f198a25de3/third_party/WebKit/LayoutTests/fast/peerconnection/RTCRtpSender-setParameters.html
[modify] https://crrev.com/ab67c16a1445518da7fb3409de2424f198a25de3/third_party/blink/renderer/modules/peerconnection/rtc_rtp_sender.cc
[modify] https://crrev.com/ab67c16a1445518da7fb3409de2424f198a25de3/third_party/blink/renderer/modules/peerconnection/rtc_rtp_sender.h
[modify] https://crrev.com/ab67c16a1445518da7fb3409de2424f198a25de3/third_party/blink/renderer/modules/peerconnection/rtc_void_request_script_promise_resolver_impl.h
Project Member

Comment 10 by bugdroid1@chromium.org, May 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b83b829006b13b185a6bbd5cdc44f188914f7206

commit b83b829006b13b185a6bbd5cdc44f188914f7206
Author: Florent Castelli <orphis@chromium.org>
Date: Wed May 23 19:45:59 2018

Remove unsupported RTCRtpParameters from the WebIDL

This should help feature detection when the feature is unflagged.

Bug: 803494
Change-Id: Ifcd64ea82954338751c722e26799aaa7c018268d
Reviewed-on: https://chromium-review.googlesource.com/1062032
Commit-Queue: Florent Castelli <orphis@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561214}
[modify] https://crrev.com/b83b829006b13b185a6bbd5cdc44f188914f7206/third_party/WebKit/LayoutTests/fast/peerconnection/RTCRtpSender-setParameters-expected.txt
[modify] https://crrev.com/b83b829006b13b185a6bbd5cdc44f188914f7206/third_party/blink/renderer/modules/modules_idl_files.gni
[delete] https://crrev.com/a95d86932d4699067f3ef9c3a162d64f9c0e8898/third_party/blink/renderer/modules/peerconnection/rtc_rtcp_parameters.idl
[modify] https://crrev.com/b83b829006b13b185a6bbd5cdc44f188914f7206/third_party/blink/renderer/modules/peerconnection/rtc_rtp_encoding_parameters.idl
[delete] https://crrev.com/a95d86932d4699067f3ef9c3a162d64f9c0e8898/third_party/blink/renderer/modules/peerconnection/rtc_rtp_header_extension_parameters.idl
[modify] https://crrev.com/b83b829006b13b185a6bbd5cdc44f188914f7206/third_party/blink/renderer/modules/peerconnection/rtc_rtp_parameters.idl
[modify] https://crrev.com/b83b829006b13b185a6bbd5cdc44f188914f7206/third_party/blink/renderer/modules/peerconnection/rtc_rtp_sender.cc
Project Member

Comment 11 by bugdroid1@chromium.org, May 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f57f3b2bc53cb0d52be69faee2b175612b0df23a

commit f57f3b2bc53cb0d52be69faee2b175612b0df23a
Author: Florent Castelli <orphis@chromium.org>
Date: Thu May 24 09:02:59 2018

Ship RTCRtpSender.get/setParameters

Although not all fields are currently implemented, this should be
stable and give users enough to experiment with.

Intent thread: https://groups.google.com/a/chromium.org/d/msg/blink-dev/VvBUUo7h0L4/gCBrvQMLCAAJ

Bug: 803494
Change-Id: I7b3c61a84c1706991603ea539eeaf5f22fb4e918
Reviewed-on: https://chromium-review.googlesource.com/1070277
Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Florent Castelli <orphis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561431}
[modify] https://crrev.com/f57f3b2bc53cb0d52be69faee2b175612b0df23a/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/f57f3b2bc53cb0d52be69faee2b175612b0df23a/third_party/blink/renderer/platform/runtime_enabled_features.json5
Project Member

Comment 12 by bugdroid1@chromium.org, May 31 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3e96a9240c41c96ef8edc106e7fc186aaa59b8a

commit d3e96a9240c41c96ef8edc106e7fc186aaa59b8a
Author: Florent Castelli <orphis@chromium.org>
Date: Thu May 31 11:55:53 2018

Don't override deprecated method in FakeRtpSender mock

Bug: 803494
Change-Id: Id4059fd33bccb23b091ab0b999239392db7395eb
Reviewed-on: https://chromium-review.googlesource.com/1080507
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Florent Castelli <orphis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563197}
[modify] https://crrev.com/d3e96a9240c41c96ef8edc106e7fc186aaa59b8a/content/renderer/media/webrtc/mock_peer_connection_impl.cc
[modify] https://crrev.com/d3e96a9240c41c96ef8edc106e7fc186aaa59b8a/content/renderer/media/webrtc/mock_peer_connection_impl.h
Project Member

Comment 13 by bugdroid1@chromium.org, Jun 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a198b3954364e7cb36e624dc46c566588e887b2d

commit a198b3954364e7cb36e624dc46c566588e887b2d
Author: Florent Castelli <orphis@chromium.org>
Date: Fri Jun 01 10:59:00 2018

Add RTCP parameters to RTCRtpParameters

Bug: 803494
Change-Id: I9fcf41aa39a04f85e7b04e923ccc6070a725c403
Reviewed-on: https://chromium-review.googlesource.com/1080550
Commit-Queue: Florent Castelli <orphis@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563585}
[modify] https://crrev.com/a198b3954364e7cb36e624dc46c566588e887b2d/third_party/WebKit/LayoutTests/fast/peerconnection/RTCRtpSender-getParameters.html
[modify] https://crrev.com/a198b3954364e7cb36e624dc46c566588e887b2d/third_party/WebKit/LayoutTests/fast/peerconnection/RTCRtpSender-setParameters-expected.txt
[modify] https://crrev.com/a198b3954364e7cb36e624dc46c566588e887b2d/third_party/WebKit/LayoutTests/fast/peerconnection/RTCRtpSender-setParameters.html
[modify] https://crrev.com/a198b3954364e7cb36e624dc46c566588e887b2d/third_party/blink/renderer/modules/modules_idl_files.gni
[add] https://crrev.com/a198b3954364e7cb36e624dc46c566588e887b2d/third_party/blink/renderer/modules/peerconnection/rtc_rtcp_parameters.idl
[modify] https://crrev.com/a198b3954364e7cb36e624dc46c566588e887b2d/third_party/blink/renderer/modules/peerconnection/rtc_rtp_parameters.idl
[modify] https://crrev.com/a198b3954364e7cb36e624dc46c566588e887b2d/third_party/blink/renderer/modules/peerconnection/rtc_rtp_sender.cc
Project Member

Comment 14 by bugdroid1@chromium.org, Jun 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3737c14bf20f700319badd7981ac65442e22c838

commit 3737c14bf20f700319badd7981ac65442e22c838
Author: Florent Castelli <orphis@chromium.org>
Date: Mon Jun 25 17:19:11 2018

Add headerExtensions to RTCRtpParameters

Bug: 803494
Change-Id: Ie8e7d6b4cf14be21cecc4e0b9bd6f808cef487c4
Reviewed-on: https://chromium-review.googlesource.com/1102436
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Florent Castelli <orphis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570079}
[modify] https://crrev.com/3737c14bf20f700319badd7981ac65442e22c838/third_party/WebKit/LayoutTests/fast/peerconnection/RTCRtpSender-getParameters.html
[modify] https://crrev.com/3737c14bf20f700319badd7981ac65442e22c838/third_party/WebKit/LayoutTests/fast/peerconnection/RTCRtpSender-setParameters-expected.txt
[modify] https://crrev.com/3737c14bf20f700319badd7981ac65442e22c838/third_party/WebKit/LayoutTests/fast/peerconnection/RTCRtpSender-setParameters.html
[modify] https://crrev.com/3737c14bf20f700319badd7981ac65442e22c838/third_party/blink/renderer/modules/modules_idl_files.gni
[add] https://crrev.com/3737c14bf20f700319badd7981ac65442e22c838/third_party/blink/renderer/modules/peerconnection/rtc_rtp_header_extension_parameters.idl
[modify] https://crrev.com/3737c14bf20f700319badd7981ac65442e22c838/third_party/blink/renderer/modules/peerconnection/rtc_rtp_parameters.idl
[modify] https://crrev.com/3737c14bf20f700319badd7981ac65442e22c838/third_party/blink/renderer/modules/peerconnection/rtc_rtp_sender.cc
Project Member

Comment 15 by bugdroid1@chromium.org, Jun 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa87cb3cea4322d026dfdba044de178c93837964

commit aa87cb3cea4322d026dfdba044de178c93837964
Author: Florent Castelli <orphis@chromium.org>
Date: Wed Jun 27 17:06:19 2018

Import updated WebIDL for RTCRtpSendParameters and related types

Extracts RTCRtpSendParameters from RTCRtpParameters.
Extracts RTCRtpEncodingParameters from RTCRtpCodingParameters.
Adds required to many fields and update tests accordindly.

Bug: 803494
Change-Id: I416c0884abf15ab8d55ce5ae481f15ac8012c73d
Reviewed-on: https://chromium-review.googlesource.com/1114844
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Florent Castelli <orphis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570820}
[modify] https://crrev.com/aa87cb3cea4322d026dfdba044de178c93837964/third_party/WebKit/LayoutTests/fast/peerconnection/RTCRtpSender-setParameters-expected.txt
[modify] https://crrev.com/aa87cb3cea4322d026dfdba044de178c93837964/third_party/WebKit/LayoutTests/fast/peerconnection/RTCRtpSender-setParameters.html
[modify] https://crrev.com/aa87cb3cea4322d026dfdba044de178c93837964/third_party/blink/renderer/modules/modules_idl_files.gni
[modify] https://crrev.com/aa87cb3cea4322d026dfdba044de178c93837964/third_party/blink/renderer/modules/peerconnection/rtc_rtp_codec_parameters.idl
[add] https://crrev.com/aa87cb3cea4322d026dfdba044de178c93837964/third_party/blink/renderer/modules/peerconnection/rtc_rtp_coding_parameters.idl
[modify] https://crrev.com/aa87cb3cea4322d026dfdba044de178c93837964/third_party/blink/renderer/modules/peerconnection/rtc_rtp_encoding_parameters.idl
[modify] https://crrev.com/aa87cb3cea4322d026dfdba044de178c93837964/third_party/blink/renderer/modules/peerconnection/rtc_rtp_header_extension_parameters.idl
[modify] https://crrev.com/aa87cb3cea4322d026dfdba044de178c93837964/third_party/blink/renderer/modules/peerconnection/rtc_rtp_parameters.idl
[add] https://crrev.com/aa87cb3cea4322d026dfdba044de178c93837964/third_party/blink/renderer/modules/peerconnection/rtc_rtp_send_parameters.idl
[modify] https://crrev.com/aa87cb3cea4322d026dfdba044de178c93837964/third_party/blink/renderer/modules/peerconnection/rtc_rtp_sender.cc
[modify] https://crrev.com/aa87cb3cea4322d026dfdba044de178c93837964/third_party/blink/renderer/modules/peerconnection/rtc_rtp_sender.h
[modify] https://crrev.com/aa87cb3cea4322d026dfdba044de178c93837964/third_party/blink/renderer/modules/peerconnection/rtc_rtp_sender.idl
Project Member

Comment 16 by bugdroid1@chromium.org, Jun 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46b73d21ff4348ba84f77df16a294db7b57b9079

commit 46b73d21ff4348ba84f77df16a294db7b57b9079
Author: Henrik Boström <hbos@chromium.org>
Date: Fri Jun 29 08:56:05 2018

Update external/wpt/webrtc/RTCRtpParameters* tests.

This is in preparation for get/setParameters[1] and
RTCRtpTransceiver[2].

Tests are updated to use promise_test and async/await to make them
easier to write and to execute sequentially.

Tests are updated to set up a call before getParameters() because many
parameters are defined as "that has been negotiated". If we want to test
what is returned before negotiation we should add that as separate
tests. For now, this is necessary for the tests to run on [1][2].

Some tests are removed because they no longer reflect the spec.

Because get/setParameters() and RTCRtpTransceiver has not landed yet,
the tests are still expected to fail.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1102436
[2] https://chromium-review.googlesource.com/c/chromium/src/+/1025771

Bug: 803494,  777617 
Change-Id: I3f14a37925837576a602d91bb67e48181c56a946
Reviewed-on: https://chromium-review.googlesource.com/1102502
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571430}
[modify] https://crrev.com/46b73d21ff4348ba84f77df16a294db7b57b9079/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCRtpParameters-codecs-expected.txt
[modify] https://crrev.com/46b73d21ff4348ba84f77df16a294db7b57b9079/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCRtpParameters-codecs.html
[modify] https://crrev.com/46b73d21ff4348ba84f77df16a294db7b57b9079/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCRtpParameters-encodings-expected.txt
[modify] https://crrev.com/46b73d21ff4348ba84f77df16a294db7b57b9079/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCRtpParameters-encodings.html
[modify] https://crrev.com/46b73d21ff4348ba84f77df16a294db7b57b9079/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCRtpParameters-helper.js
[modify] https://crrev.com/46b73d21ff4348ba84f77df16a294db7b57b9079/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCRtpParameters-transactionId-expected.txt
[modify] https://crrev.com/46b73d21ff4348ba84f77df16a294db7b57b9079/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCRtpParameters-transactionId.html
Project Member

Comment 17 by bugdroid1@chromium.org, Aug 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ba4fb0c89f3d82ac7378d256bd48ace1fe538c4

commit 2ba4fb0c89f3d82ac7378d256bd48ace1fe538c4
Author: Florent Castelli <orphis@chromium.org>
Date: Mon Aug 06 15:59:28 2018

Fix the wpt/webrtc/RTCRtpParameters-transactionId test

The transactionId field is now required in the WebIDL, so the proper
error is now a TypeError.

Bug: 803494
Change-Id: Iaf49c2cd192b8ac99678acb74a163670f4c93893
Reviewed-on: https://chromium-review.googlesource.com/1163666
Commit-Queue: Florent Castelli <orphis@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580887}
[modify] https://crrev.com/2ba4fb0c89f3d82ac7378d256bd48ace1fe538c4/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCRtpParameters-transactionId-expected.txt
[modify] https://crrev.com/2ba4fb0c89f3d82ac7378d256bd48ace1fe538c4/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCRtpParameters-transactionId.html
[modify] https://crrev.com/2ba4fb0c89f3d82ac7378d256bd48ace1fe538c4/third_party/WebKit/LayoutTests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/RTCRtpParameters-transactionId-expected.txt

Comment 18 by hbos@chromium.org, Sep 4

Blocking: 700916

Comment 19 by hbos@chromium.org, Sep 4

Status: Started (was: Assigned)

Comment 21 by hbos@chromium.org, Jan 8 

Should we maybe update this bug to reflect the fact that get/setParameters() have been shipped, and leave remaining items to their own bugs to be tracked individually?

Comment 22 by benhenry@google.com, Jan 11

Labels: Pri-2
Setting defect without priority to Pri-2.

Comment 23 by benhenry@google.com, Jan 11 

Setting defect without priority to Pri-2.
►

Sign in to add a comment