Fix failed assertions being ignored in test code |
|||||
Issue description1. Read http://errorprone.info/bugpattern/AssertionFailureIgnored 2. Remove 'AssertionFailureIgnored' suppression for errorprone. 3. Fix or suppress each instance in code. 4. Upgrade 'AssertionFailureIgnored' to errorprone error to prevent future regressions.
,
Mar 8 2018
,
Mar 8 2018
,
Mar 8 2018
It's okay :) It might help to set yourself as Owner on the bugs you are currently working on.
,
Mar 27 2018
,
Mar 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/19599044bcb9f1762f7e09f722b752255808fdb4 commit 19599044bcb9f1762f7e09f722b752255808fdb4 Author: Rob Buis <rob.buis@samsung.com> Date: Wed Mar 28 20:53:17 2018 Fix errorprone AssertionFailureIgnored warnings Fix errorprone AssertionFailureIgnored warnings and make sure it is treated as error after this CL. http://errorprone.info/bugpattern/AssertionFailureIgnored Bug: 803486 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Icd3570588059e964fca0638e6ce8adf16f1e5ff9 Reviewed-on: https://chromium-review.googlesource.com/938157 Reviewed-by: John Budorick <jbudorick@chromium.org> Reviewed-by: Helen Li <xunjieli@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Peter Wen <wnwen@chromium.org> Commit-Queue: Rob Buis <rob.buis@samsung.com> Cr-Commit-Position: refs/heads/master@{#546592} [modify] https://crrev.com/19599044bcb9f1762f7e09f722b752255808fdb4/build/android/gyp/javac.py [modify] https://crrev.com/19599044bcb9f1762f7e09f722b752255808fdb4/chrome/android/javatests/src/org/chromium/chrome/browser/feedback/ConnectivityTaskTest.java [modify] https://crrev.com/19599044bcb9f1762f7e09f722b752255808fdb4/components/cronet/android/test/javatests/src/org/chromium/net/GetStatusTest.java [modify] https://crrev.com/19599044bcb9f1762f7e09f722b752255808fdb4/components/cronet/android/test/smoketests/src/org/chromium/net/smoke/MissingNativeLibraryTest.java [modify] https://crrev.com/19599044bcb9f1762f7e09f722b752255808fdb4/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
,
Apr 3 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Mar 7 2018