New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 803486 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Apr 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug


Participants' hotlists:
ErrorProne-Fixes


Sign in to add a comment

Fix failed assertions being ignored in test code

Project Member Reported by wnwen@chromium.org, Jan 18 2018

Issue description

1. Read http://errorprone.info/bugpattern/AssertionFailureIgnored
2. Remove 'AssertionFailureIgnored' suppression for errorprone.
3. Fix or suppress each instance in code.
4. Upgrade 'AssertionFailureIgnored' to errorprone error to prevent future regressions.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f095fd3955cfc8cfe420e82bf84a098b7a8ec03

commit 6f095fd3955cfc8cfe420e82bf84a098b7a8ec03
Author: Rob Buis <rob.buis@samsung.com>
Date: Wed Mar 07 22:21:06 2018

Fix errorprone ArgumentSelectionDefectChecker warnings

Fix errorprone ArgumentSelectionDefectChecker warnings and make
sure it is treated as error after this CL.

http://errorprone.info/bugpattern/ArgumentSelectionDefectChecker

Bug:  803486 
Change-Id: I9890d4c5d32f5b1cbb81695bd308e0b93b0ceef5
Reviewed-on: https://chromium-review.googlesource.com/953076
Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Rob Buis <rob.buis@samsung.com>
Cr-Commit-Position: refs/heads/master@{#541609}
[modify] https://crrev.com/6f095fd3955cfc8cfe420e82bf84a098b7a8ec03/build/android/gyp/javac.py

Status: Fixed (was: Available)
Status: Available (was: Fixed)
Oops, used the wrong bug number in r541609 :(

Comment 4 by wnwen@chromium.org, Mar 8 2018

Cc: rob.b...@samsung.com
It's okay :)

It might help to set yourself as Owner on the bugs you are currently working on.
Owner: rob.b...@samsung.com
Status: assigned (was: Available)
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19599044bcb9f1762f7e09f722b752255808fdb4

commit 19599044bcb9f1762f7e09f722b752255808fdb4
Author: Rob Buis <rob.buis@samsung.com>
Date: Wed Mar 28 20:53:17 2018

Fix errorprone AssertionFailureIgnored warnings

Fix errorprone AssertionFailureIgnored warnings and make
sure it is treated as error after this CL.

http://errorprone.info/bugpattern/AssertionFailureIgnored

Bug:  803486 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Icd3570588059e964fca0638e6ce8adf16f1e5ff9
Reviewed-on: https://chromium-review.googlesource.com/938157
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Rob Buis <rob.buis@samsung.com>
Cr-Commit-Position: refs/heads/master@{#546592}
[modify] https://crrev.com/19599044bcb9f1762f7e09f722b752255808fdb4/build/android/gyp/javac.py
[modify] https://crrev.com/19599044bcb9f1762f7e09f722b752255808fdb4/chrome/android/javatests/src/org/chromium/chrome/browser/feedback/ConnectivityTaskTest.java
[modify] https://crrev.com/19599044bcb9f1762f7e09f722b752255808fdb4/components/cronet/android/test/javatests/src/org/chromium/net/GetStatusTest.java
[modify] https://crrev.com/19599044bcb9f1762f7e09f722b752255808fdb4/components/cronet/android/test/smoketests/src/org/chromium/net/smoke/MissingNativeLibraryTest.java
[modify] https://crrev.com/19599044bcb9f1762f7e09f722b752255808fdb4/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

Status: Fixed (was: Assigned)

Sign in to add a comment