New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 803482 link

Starred by 1 user
Status: Fixed
Owner:
█ rob.b...@samsung.com
Email to this user bounced
Closed: Mar 2018
Cc:
agrieve@chromium.org
█ nyquist@chromium.org
█ wnwen@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug


Participants' hotlists:
ErrorProne-Fixes


Sign in to add a comment

Fix java asserts in test code

Project Member Reported by wnwen@chromium.org, Jan 18 2018 
1. Read http://errorprone.info/bugpattern/UseCorrectAssertInTests
2. Remove 'UseCorrectAssertInTests' suppression for errorprone.
3. Fix or suppress each instance in code.
4. Upgrade 'UseCorrectAssertInTests' to errorprone error to prevent future regressions.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ca2b4b8f13542b8da970f1ec2e3f24feaf167e8

commit 1ca2b4b8f13542b8da970f1ec2e3f24feaf167e8
Author: Rob Buis <rob.buis@samsung.com>
Date: Thu Mar 01 16:30:10 2018

Fix errorprone UseCorrectAssertInTests warnings

Fix errorprone UseCorrectAssertInTests warnings and make
sure it is treated as error after this CL.

http://errorprone.info/bugpattern/UseCorrectAssertInTests

Bug:  803482 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ic337a2e0313986961af4390c38bfa47bfdb46325
Reviewed-on: https://chromium-review.googlesource.com/938642
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Tao Bai <michaelbai@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Rob Buis <rob.buis@samsung.com>
Cr-Commit-Position: refs/heads/master@{#540175}
[modify] https://crrev.com/1ca2b4b8f13542b8da970f1ec2e3f24feaf167e8/android_webview/javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java
[modify] https://crrev.com/1ca2b4b8f13542b8da970f1ec2e3f24feaf167e8/build/android/gyp/javac.py
[modify] https://crrev.com/1ca2b4b8f13542b8da970f1ec2e3f24feaf167e8/chrome/android/junit/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFinderUnitTest.java
[modify] https://crrev.com/1ca2b4b8f13542b8da970f1ec2e3f24feaf167e8/chrome/android/junit/src/org/chromium/chrome/browser/payments/PaymentManifestVerifierTest.java
[modify] https://crrev.com/1ca2b4b8f13542b8da970f1ec2e3f24feaf167e8/components/cronet/android/test/javatests/src/org/chromium/net/NQETest.java

Comment 2 by rob.b...@samsung.com, Mar 8 2018

Status: Fixed (was: Available)

Comment 3 by wnwen@chromium.org, Mar 8 2018

Owner: rob.b...@samsung.com
►

Sign in to add a comment