New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 803471 link

Starred by 1 user
Status: Fixed
Owner:
enne@chromium.org
Closed: Jan 2018
Cc:
█ kbr@chromium.org
vmi...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 777154



Sign in to add a comment

OffscreenCanvasTransferBeforeStyleResize failing on Mac Pro AMD GPU FYI bots

Project Member Reported by cwallez@chromium.org, Jan 18 2018 
gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_OffscreenCanvasTransferBeforeStyleResize is failing on buildbot/chromium.gpu.fyi/Mac Pro Debug (AMD) and buildbot/chromium.gpu.fyi/Mac Pro Release (AMD).

The first failing build on Debug: https://ci.chromium.org/buildbot/chromium.gpu.fyi/Mac%20Pro%20Debug%20%28AMD%29/12161

enne@ can you TAL? Your commit changing the suppressions for this test is in the regression range. https://chromium.googlesource.com/chromium/src/+/7b59d4703cc735d686346985739fc18d427e5d7b%5E%21/#F0

The test looks like it might still be flaky (just very very flaky) because one run passed on the Mac PRO Debug (AMD) bot.

Comment 1 by enne@chromium.org, Jan 18 2018 

Looks like the rebaseline when I bumped the version grabbed the wrong image.

Current result:
http://chromium-browser-gpu-tests.commondatastorage.googleapis.com/view_test_results.html?9dd74e24ba1f2fc38bbe45dbf51d806c7c791851_Mac_Pro_Debug_AMD__telemetry

This seems in line with https://bugs.chromium.org/p/chromium/issues/detail?id=735228#c11

Is the best thing to do here just to bump the version again and hope it picks up the right images? Can I revert those image changes on platforms other than Android?

Sorry for all the questions.  I'm just not familiar with the best approach for dealing with these tests.

Comment 2 by kbr@chromium.org, Jan 18 2018

Blocking: 777154
Status: Assigned (was: Available)
No worries. In general, yes, the way to handle this would be to suppress this test again (on all platforms), increment the version number of the page again, and then un-suppress it. But that seems like overkill for this flaky test.

I've just used the Cloud Storage link from https://www.chromium.org/developers/how-tos/gpu-wrangling to look up the bad reference image (Pixel_OffscreenCanvasTransferBeforeStyleResize_v4_mac_1002_679e_msaa.png) and manually deleted it. It should be regenerated during the next run. Can you watch to make sure it goes green afterward? Thanks.

Comment 3 by enne@chromium.org, Jan 18 2018 

Can do.  Thanks!

Comment 4 by enne@chromium.org, Jan 19 2018

Status: Fixed (was: Assigned)
Those two bots look good, thanks again!
►

Sign in to add a comment