New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 803460 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 803507



Sign in to add a comment

media_perftests failing on chromium.perf/Android Nexus5X Perf

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Jan 18 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of ashleymarie@google.com

media_perftests failing on chromium.perf/Android Nexus5X Perf

Builders failed on: 
- Android Nexus5X Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5X%20Perf


 
PipelineIntegrationPerfTest.AudioPlaybackBenchmark seems to be failing frequently

Comment 2 by crouleau@google.com, Jan 18 2018

Cc: dalecur...@chromium.org
media_perftests on Android media_perftests on Android
TEST RESULTS WERE INVALID

There's no stack trace in the output: https://logs.chromium.org/v/?s=chrome%2Fbb%2Fchromium.perf%2FAndroid_Nexus5X_Perf%2F1118%2F%2B%2Frecipes%2Fsteps%2Fmedia_perftests_on_Android%2F0%2Fstdout#

Comment 4 by crouleau@google.com, Jan 18 2018

Blockedon: 803507
Labels: Type-Bug
Probably taking too long to run now that we run it with --single-process.
Ping this is still failing

Comment 7 by crouleau@google.com, Jan 30 2018

Owner: dalecur...@chromium.org
Status: Assigned (was: Available)
Assigning to Dale, current Media Perf Sheriff.
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e517a1c2836aa4e971db9e28259582b0cd58a49a

commit e517a1c2836aa4e971db9e28259582b0cd58a49a
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Wed Jan 31 01:38:33 2018

Make some media_perftests TEST_P, remove/replace useless cases.

Ultimately this shaves a couple seconds of runtime off my local
build, so it should help with timeouts on Android bots.

This removes the following perf test cases since they don't
correspond to well used codecs. Well used in this case means
we see above 2% daily usage per relavant histograms:

DemuxerPerfTest:
- bear.avi
- sfx_s16le.wav
- bear.flac

AudioPipelineIntegrationPerfTest:
- sfx_f32le.wav
- sfx_s24le.wav
- sfx_u8.wav
- sfx.flac

It replaces the above audio tests with more appropriate ones
reflecting actual usage:
- sfx.mp3 (mp3)
- sfx.ogg (vorbis)
- sfx.m4a (aac)

This also splits out a couple chunk TEST() blocks into
parameterized tests for cleanliness, though that won't
improve performance since we run perf tests --single-process.

BUG= 803460 
TEST=none

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Iebac045d09c867eb3cc7f867d62e8959aa094e66
Reviewed-on: https://chromium-review.googlesource.com/893437
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533150}
[modify] https://crrev.com/e517a1c2836aa4e971db9e28259582b0cd58a49a/media/filters/demuxer_perftest.cc
[modify] https://crrev.com/e517a1c2836aa4e971db9e28259582b0cd58a49a/media/test/pipeline_integration_perftest.cc

Status: Fixed (was: Assigned)
Seems fixed in recent runs.

Sign in to add a comment