New issue
Advanced search Search tips

Issue 803456 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac , Fuchsia
Pri: 3
Type: Bug

Blocked on:
issue 448486



Sign in to add a comment

NavigationManager keeps the "CanGoForward" state from the previous navigation during interstitials

Project Member Reported by gambard@chromium.org, Jan 18 2018

Issue description

Chrome Version: M63

What steps will reproduce the problem?
(1) Go to a page
(2) Go back
(3) Go to expired.badssl.com (or any page showing interstitial)

What is the expected result?
The forward button should be disabled

What happens instead?
The forward button is shown. Tapping it navigate to the page shown in (1).
 
Cc: est...@chromium.org
Why do you expect the forward button to be disabled? Desktop has the same behavior (forward button navigates to page #1).
Because in my opinion I have started a new navigation (which didn't complete because there is a problem with the certificate). I don't expect the navigation stack to remain the same.
Cc: creis@chromium.org
Labels: -Pri-1 OS-Android OS-Chrome OS-Fuchsia OS-Linux OS-Mac OS-Windows Pri-3
Emily, Charlie, do you think this is a bug or WAI? If a bug then we probably should fix it for all platforms.

Comment 4 by est...@chromium.org, Jan 19 2018

I don't care too much about this either way -- I think either behavior is fine. My guess is that the current behavior was more or less an accident of how interstitials work and that nobody thought too hard about it. (Charlie may have been around at the time and might actually know one way or another.)

In any case, this behavior is going to change on non-iOS platforms with the committed interstitial refactor. Interstitials will clear the navigation stack like a normal navigation, or like a net error page. (https://docs.google.com/document/d/1rEBpw5V-Nn1UIi8CIFa5ZZvwlR08SkY3CogvWE2UMFs/edit) It'll take a while to get around to it, but we should eventually convert iOS to a similar design where interstitials work more like net error pages.
Cc: eugene...@chromium.org
Owner: ----
Status: Available (was: Assigned)
Thanks Emily. Do we have a bug for "committed interstitials", so I can block this bug on "committed interstitials" bug? 

Comment 6 by est...@chromium.org, Jan 19 2018

Blockedon: 448486
Yep, it's 448486.

Comment 7 by creis@chromium.org, Jan 20 2018

The current behavior probably wasn't a conscious decision, but it's what I would expect given how interstitials work (i.e., as overlays).  The forward history is not cleared until a new navigation commits, and an interstitial page is not a commit (at least until the refactor estark@ mentioned in issue 448486).  It's similar to doing a slow navigation and clicking forward before it completes.

So I'd say it's working as intended for now, and the forward history will be cleared as gambard@ expected after we switch interstitials from overlays to committed pages.
Project Member

Comment 8 by sheriffbot@chromium.org, Yesterday (46 hours ago)

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 9 by eugene...@chromium.org, Today (20 hours ago)

Status: Available (was: Untriaged)

Sign in to add a comment