NavigationManager keeps the "CanGoForward" state from the previous navigation during interstitials |
|||||
Issue descriptionChrome Version: M63 What steps will reproduce the problem? (1) Go to a page (2) Go back (3) Go to expired.badssl.com (or any page showing interstitial) What is the expected result? The forward button should be disabled What happens instead? The forward button is shown. Tapping it navigate to the page shown in (1).
,
Jan 18 2018
Because in my opinion I have started a new navigation (which didn't complete because there is a problem with the certificate). I don't expect the navigation stack to remain the same.
,
Jan 18 2018
Emily, Charlie, do you think this is a bug or WAI? If a bug then we probably should fix it for all platforms.
,
Jan 19 2018
I don't care too much about this either way -- I think either behavior is fine. My guess is that the current behavior was more or less an accident of how interstitials work and that nobody thought too hard about it. (Charlie may have been around at the time and might actually know one way or another.) In any case, this behavior is going to change on non-iOS platforms with the committed interstitial refactor. Interstitials will clear the navigation stack like a normal navigation, or like a net error page. (https://docs.google.com/document/d/1rEBpw5V-Nn1UIi8CIFa5ZZvwlR08SkY3CogvWE2UMFs/edit) It'll take a while to get around to it, but we should eventually convert iOS to a similar design where interstitials work more like net error pages.
,
Jan 19 2018
Thanks Emily. Do we have a bug for "committed interstitials", so I can block this bug on "committed interstitials" bug?
,
Jan 19 2018
,
Jan 20 2018
The current behavior probably wasn't a conscious decision, but it's what I would expect given how interstitials work (i.e., as overlays). The forward history is not cleared until a new navigation commits, and an interstitial page is not a commit (at least until the refactor estark@ mentioned in issue 448486). It's similar to doing a slow navigation and clicking forward before it completes. So I'd say it's working as intended for now, and the forward history will be cleared as gambard@ expected after we switch interstitials from overlays to committed pages.
,
Yesterday
(46 hours ago)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Today
(20 hours ago)
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by eugene...@chromium.org
, Jan 18 2018