Issue metadata
Sign in to add a comment
|
Support blocking of cookies via content settings with Network Service |
||||||||||||||||||||||||||
Issue descriptionIn the non-Network Service world, TabSpecificContentSettings gets the chance to block setting cookies via ChromeNetworkDelegate::OnCanSetCookie(), which is invoked by URLRequest::CanSetCookie(). However, in the Network Service world, URLRequests have BasicNetworkDelegate as their delegate. BasicNetworkDelegate::OnCanSetCookie() returns true unconditionally. Naively, it seems like this needs to change to call through to the browser in some fashion so that TabSpecificContentSettings can still be invoked? Note that URLRequest::CanSetCookie() currently returns synchronously. This lack of functionality is causing the ContentSettingsTest failures.
,
Jan 18 2018
Tab-specific settings in the network process is doable but moderately complex. (I imagine consumers of the network service scoping frames by URLLoaderFactory and having interfaces on URLLoaderFactory to set this kind of cookie filters.) . I agree that we can't add process hops for this functionality, though.
,
Jan 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6f393137d791f73e241085afd0696562c44ab3c5 commit 6f393137d791f73e241085afd0696562c44ab3c5 Author: Colin Blundell <blundell@chromium.org> Date: Fri Jan 19 08:50:58 2018 Mark proper cause of ContentSettings tests failures with Network Service Bug: 803452 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I3875413cd8ffc50ac52bef1771bb108fdcd5e330 Reviewed-on: https://chromium-review.googlesource.com/873830 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#530454} [modify] https://crrev.com/6f393137d791f73e241085afd0696562c44ab3c5/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
,
Mar 2 2018
,
May 7 2018
,
May 14 2018
|
|||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||
Comment 1 by mmenke@chromium.org
, Jan 18 2018