New issue
Advanced search Search tips

Issue 803451 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug


Participants' hotlists:
high-bit-depth


Sign in to add a comment

Add support for XR30 GLImages on Win

Project Member Reported by mcasas@chromium.org, Jan 18 2018

Issue description

https://crev.com/c/868172 connected support for XR30 GLImages
but the associated gl_unittests failed on win7_chromium_rel_ng
gl_unittests (see below)

Investigate and connect XR30 in Win.





LogDog : chromium/bb/tryserver.chromium.win/win7_chromium_rel_ng/82956/+/recipes/steps/gl_unittests_on_NVIDIA_GPU_on_Windows__with_patch__on_Windows-2008ServerR2-SP1/0/stdout
Sign in
WRAP
'C:\b\depot_tools\win_tools-2_7_6_bin\python\bin\python.exe' -u 'C:\b\rr\tmpqzqied\rw\checkout\scripts\tools\runit.py' --show-path -- python 'C:\b\rr\tmpqzqied\rw\checkout\scripts/slave\recipe_modules\swarming\resources\collect_task.py' -o 'c:\users\chrome~1\appdata\local\temp\tmpzr3ir_.json' --task-output-dir 'c:\users\chrome~1\appdata\local\temp\tmp5ietr3' --merge-script 'C:\b\rr\tmpqzqied\rw\checkout\scripts/slave\recipe_modules\swarming\resources\standard_gtest_merge.py' --merge-additional-args '[]' --build-properties '{"attempt_start_ts": 1516229736000000, "blamelist": ["mcasas@chromium.org"], "bot_id": "win99-c4", "branch": "", "build_data_dir": "C:\\b\\rr\\tmpbmao7e", "build_id": "buildbot/tryserver.chromium.win/win7_chromium_rel_ng/82956", "buildbotURL": "http://build.chromium.org/p/tryserver.chromium.win/", "buildbucket": "{\"build\": {\"bucket\": \"master.tryserver.chromium.win\", \"created_by\": \"user:5071639625-1lppvbtck1morgivc6sq4dul7klu27sd@developer.gserviceaccount.com\", \"created_ts\": \"1516229756995710\", \"id\": \"8957111582287228448\", \"lease_key\": \"1628077351\", \"tags\": [\"builder:win7_chromium_rel_ng\", \"buildset:patch/gerrit/chromium-review.googlesource.com/868172/9\", \"cq_experimental:false\", \"master:master.tryserver.chromium.win\", \"user_agent:cq\"]}}", "builder_id": "master.tryserver.chromium.win:win7_chromium_rel_ng", "buildername": "win7_chromium_rel_ng", "buildnumber": 82956, "category": "cq", "got_angle_revision": "b745f172dd6870736e3d2e2112a9e908fdc7a74b", "got_buildtools_revision": null, "got_nacl_revision": "7f07816e463da403255f0ab4f6d88004450dd09d", "got_revision": "df331b4b8b098e3d727fba84f28f96a8f6a68da1", "got_revision_cp": "refs/heads/master@{#529936}", "got_swarming_client_revision": null, "got_v8_revision": "dc0a0f78419d087c1427a26d88ce067682d3be73", "got_v8_revision_cp": "refs/heads/6.5.253@{#1}", "got_webrtc_revision": "4aa8ab5d568d562aa1a28829bedce902429916d8", "got_webrtc_revision_cp": "refs/heads/master@{#21645}", "luci_migration": {"status": "ok"}, "master": "master.tryserver.chromium.win", "mastername": "tryserver.chromium.win", "patch_gerrit_url": "https://chromium-review.googlesource.com", "patch_issue": 868172, "patch_project": "chromium/src", "patch_ref": "refs/changes/72/868172/9", "patch_repository_url": "https://chromium.googlesource.com/chromium/src", "patch_set": 9, "patch_storage": "gerrit", "path_config": "kitchen", "project": "", "reason": "CQ", "recipe": "chromium_trybot", "recipe_repository": "https://chromium.googlesource.com/chromium/tools/build.git", "repository": "https://chromium.googlesource.com/chromium/src", "requestedAt": 1516229761, "requester": "commit-bot@chromium.org", "revision": "", "slavename": "win99-c4", "use_gitiles": false, "workdir": "C:\\b\\build\\slave/remote_run"}' -- python -u 'C:\b\c\b\win\src\tools\swarming_client\swarming.py' collect --swarming https://chromium-swarm.appspot.com --decorate --print-status-updates --json 'c:\users\chrome~1\appdata\local\temp\tmpbfgxgj.json' --task-summary-json 'c:\users\chrome~1\appdata\local\temp\tmprry11o.json'
in dir C:\b\rr\tmpqzqied\w:
 allow_subannotations: True
 base_name: 'gl_unittests on NVIDIA GPU on Windows (with patch) on Windows-2008ServerR2-SP1'
 cmd: ['C:\\b\\depot_tools\\win_tools-2_7_6_bin\\python\\bin\\python.exe',
 '-u',
 'C:\\b\\rr\\tmpqzqied\\rw\\checkout\\scripts\\tools\\runit.py',
 '--show-path',
 '--',
 'python',
 'C:\\b\\rr\\tmpqzqied\\rw\\checkout\\scripts/slave\\recipe_modules\\swarming\\resources\\collect_task.py',
 '-o',
 'c:\\users\\chrome~1\\appdata\\local\\temp\\tmpzr3ir_.json',
 '--task-output-dir',
 'c:\\users\\chrome~1\\appdata\\local\\temp\\tmp5ietr3',
 '--merge-script',
 'C:\\b\\rr\\tmpqzqied\\rw\\checkout\\scripts/slave\\recipe_modules\\swarming\\resources\\standard_gtest_merge.py',
 '--merge-additional-args',
 '[]',
 '--build-properties',
 '{"attempt_start_ts": 1516229736000000, "blamelist": ["mcasas@chromium.org"], "bot_id": "win99-c4", "branch": "", "build_data_dir": "C:\\\\b\\\\rr\\\\tmpbmao7e", "build_id": "buildbot/tryserver.chromium.win/win7_chromium_rel_ng/82956", "buildbotURL": "http://build.chromium.org/p/tryserver.chromium.win/", "buildbucket": "{\\"build\\": {\\"bucket\\": \\"master.tryserver.chromium.win\\", \\"created_by\\": \\"user:5071639625-1lppvbtck1morgivc6sq4dul7klu27sd@developer.gserviceaccount.com\\", \\"created_ts\\": \\"1516229756995710\\", \\"id\\": \\"8957111582287228448\\", \\"lease_key\\": \\"1628077351\\", \\"tags\\": [\\"builder:win7_chromium_rel_ng\\", \\"buildset:patch/gerrit/chromium-review.googlesource.com/868172/9\\", \\"cq_experimental:false\\", \\"master:master.tryserver.chromium.win\\", \\"user_agent:cq\\"]}}", "builder_id": "master.tryserver.chromium.win:win7_chromium_rel_ng", "buildername": "win7_chromium_rel_ng", "buildnumber": 82956, "category": "cq", "got_angle_revision": "b745f172dd6870736e3d2e2112a9e908fdc7a74b", "got_buildtools_revision": null, "got_nacl_revision": "7f07816e463da403255f0ab4f6d88004450dd09d", "got_revision": "df331b4b8b098e3d727fba84f28f96a8f6a68da1", "got_revision_cp": "refs/heads/master@{#529936}", "got_swarming_client_revision": null, "got_v8_revision": "dc0a0f78419d087c1427a26d88ce067682d3be73", "got_v8_revision_cp": "refs/heads/6.5.253@{#1}", "got_webrtc_revision": "4aa8ab5d568d562aa1a28829bedce902429916d8", "got_webrtc_revision_cp": "refs/heads/master@{#21645}", "luci_migration": {"status": "ok"}, "master": "master.tryserver.chromium.win", "mastername": "tryserver.chromium.win", "patch_gerrit_url": "https://chromium-review.googlesource.com", "patch_issue": 868172, "patch_project": "chromium/src", "patch_ref": "refs/changes/72/868172/9", "patch_repository_url": "https://chromium.googlesource.com/chromium/src", "patch_set": 9, "patch_storage": "gerrit", "path_config": "kitchen", "project": "", "reason": "CQ", "recipe": "chromium_trybot", "recipe_repository": "https://chromium.googlesource.com/chromium/tools/build.git", "repository": "https://chromium.googlesource.com/chromium/src", "requestedAt": 1516229761, "requester": "commit-bot@chromium.org", "revision": "", "slavename": "win99-c4", "use_gitiles": false, "workdir": "C:\\\\b\\\\build\\\\slave/remote_run"}',
 '--',
 'python',
 '-u',
 'C:\\b\\c\\b\\win\\src\\tools\\swarming_client\\swarming.py',
 'collect',
 '--swarming',
 'https://chromium-swarm.appspot.com',
 '--decorate',
 '--print-status-updates',
 '--json',
 'c:\\users\\chrome~1\\appdata\\local\\temp\\tmpbfgxgj.json',
 '--task-summary-json',
 'c:\\users\\chrome~1\\appdata\\local\\temp\\tmprry11o.json']
 env: {'CHROME_HEADLESS': '1',
 'DEPOT_TOOLS_WIN_TOOLCHAIN_ROOT': 'C:\\b\\c\\win_toolchain'}
 env_prefixes: {'PATH': 'C:\\b\\cipd_client;C:\\b\\cipd_path_tools;C:\\b\\cipd_path_tools\\bin'}
 env_suffixes: {}
 infra_step: False
 name: 'gl_unittests on NVIDIA GPU on Windows (with patch) on Windows-2008ServerR2-SP1'
 nest_level: 0
 ok_ret: frozenset([0])
 step_test_data: <lambda>(...)
 trigger_specs: ()
full environment:
 APPDATA: C:\Users\chrome-bot\AppData\Roaming
 AWS_CREDENTIAL_FILE: C:\b\build\site_config\.boto
 BOTO_CONFIG: C:\b\build\site_config\.boto
 BUILDBOT_BLAMELIST: [u'mcasas@chromium.org']
 BUILDBOT_BRANCH: 
 BUILDBOT_BUILDBOTURL: http://build.chromium.org/p/tryserver.chromium.win/
 BUILDBOT_BUILDERNAME: win7_chromium_rel_ng
 BUILDBOT_BUILDNUMBER: 82956
 BUILDBOT_CLOBBER: 
 BUILDBOT_GOT_REVISION: None
 BUILDBOT_MASTERNAME: tryserver.chromium.win
 BUILDBOT_REVISION: 
 BUILDBOT_SCHEDULER: None
 BUILDBOT_SLAVENAME: win99-c4
 CHROME_HEADLESS: 1
 CIPD_CACHE_DIR: C:\b\c\cipd
 COMMONPROGRAMFILES: C:\Program Files (x86)\Common Files
 COMMONPROGRAMFILES(X86): C:\Program Files (x86)\Common Files
 COMMONPROGRAMW6432: C:\Program Files\Common Files
 COMPUTERNAME: WIN99-C4
 COMSPEC: C:\Windows\system32\cmd.exe
 DEPOT_TOOLS_WIN_TOOLCHAIN_ROOT: C:\b\c\win_toolchain
 GIT_USER_AGENT: git/2.15.1.windows.2 win32 win99-c4.c.chromecompute.google.com.internal
 HOME: C:\Users\chrome-bot
 HOMEDRIVE: C:
 HOMEPATH: \Users\chrome-bot
 INFRA_BUILDBOT_MASTER_CLASS_NAME: TryServerChromiumWin
 INFRA_BUILDBOT_SLAVE_ACTIVE_SUBDIR: 
 INFRA_BUILDBOT_SLAVE_NAME: win99-c4
 LOCALAPPDATA: C:\Users\chrome-bot\AppData\Local
 LOGDOG_COORDINATOR_HOST: logs.chromium.org
 LOGDOG_STREAM_PREFIX: bb/tryserver.chromium.win/win7_chromium_rel_ng/82956
 LOGDOG_STREAM_PROJECT: chromium
 LOGDOG_STREAM_SERVER_PATH: net.pipe:LUCILogDogButler
 LOGNAME: chrome-bot
 NUMBER_OF_PROCESSORS: 8
 OS: Windows_NT
 PATH: C:\b\cipd_client;C:\b\cipd_path_tools;C:\b\cipd_path_tools\bin;C:\b\cipd_path_tools;C:\b\cipd_path_tools\bin;C:\b\cipd_client;C:\b\depot_tools\win_tools-2_7_6_bin\python\bin;C:\b\depot_tools\win_tools-2_7_6_bin\python\bin\Scripts;C:\b\depot_tools;c:\setup\depot_tools\win_tools-2_7_6_bin\python\bin;C:\Windows\system32;C:\Windows\system32\WBEM;C:\Program Files\7-Zip;C:\cmake\bin;c:\windows\system32\windowspowershell\v1.0;C:\b\build_internal\tools
 PATHEXT: .COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH;.MSC
 PROCESSOR_ARCHITECTURE: x86
 PROCESSOR_ARCHITEW6432: AMD64
 PROCESSOR_IDENTIFIER: Intel64 Family 6 Model 63 Stepping 0, GenuineIntel
 PROGRAMFILES: C:\Program Files (x86)
 PROGRAMFILES(X86): C:\Program Files (x86)
 PROGRAMW6432: C:\Program Files
 PROMPT: $P$G
 PWD: C:\b\build\slave\remote_run\build
 PYTHONIOENCODING: UTF-8
 PYTHONPATH: C:\b\build\site_config;C:\b\build\scripts;C:\b\build\scripts\release;C:\b\build\third_party;C:\b\build\third_party\google_api_python_client;C:\b\build\third_party\httplib2\python2;C:\b\build\third_party\infra_libs;C:\b\build\third_party\oauth2client;C:\b\build\third_party\pyasn1;C:\b\build\third_party\pyasn1-modules;C:\b\build\third_party\python-rsa;C:\b\build\third_party\requests_2_10_0;C:\b\build\third_party\setuptools-0.6c11;C:\b\build\third_party\site-packages;C:\b\build\third_party\uritemplate;C:\b\build_internal\site_config;C:\b\build_internal\symsrc;C:\b\build\slave;C:\b\build\third_party\buildbot_slave_8_4;C:\b\build\third_party\twisted_10_2;
 PYTHONUNBUFFERED: 1
 PYTHON_BAT_RUNNER: 1
 PYTHON_BIN_RELDIR: win_tools-2_7_6_bin\python\bin
 SYSTEMDRIVE: C:
 SYSTEMROOT: C:\Windows
 TEMP: C:\Users\CHROME~1\AppData\Local\Temp
 TESTING_SLAVENAME: win99-c4
 TMP: C:\Users\CHROME~1\AppData\Local\Temp
 USERDOMAIN: WIN99-C4
 USERNAME: chrome-bot
 USERPROFILE: C:\Users\chrome-bot
 VPYTHON_CLEAR_PYTHONPATH: 1
 VPYTHON_VIRTUALENV_ROOT: C:\b\c\vpython
 WINDIR: C:\Windows
Set PYTHONPATH: C:\b\rr\tmpqzqied\rw\checkout\scripts;C:\b\rr\tmpqzqied\rw\checkout\site_config;C:\b\rr\tmpqzqied\rw\checkout\third_party;C:\b\rr\tmpqzqied\rw\checkout\third_party\buildbot_8_4p1;C:\b\rr\tmpqzqied\rw\checkout\third_party\buildbot_slave_8_4;C:\b\rr\tmpqzqied\rw\checkout\third_party\coverage-3.7.1;C:\b\rr\tmpqzqied\rw\checkout\third_party\decorator_3_3_1;C:\b\rr\tmpqzqied\rw\checkout\third_party\google_api_python_client;C:\b\rr\tmpqzqied\rw\checkout\third_party\httplib2\python2;C:\b\rr\tmpqzqied\rw\checkout\third_party\infra_libs;C:\b\rr\tmpqzqied\rw\checkout\third_party\jinja2;C:\b\rr\tmpqzqied\rw\checkout\third_party\markupsafe;C:\b\rr\tmpqzqied\rw\checkout\third_party\mock-1.0.1;C:\b\rr\tmpqzqied\rw\checkout\third_party\oauth2client;C:\b\rr\tmpqzqied\rw\checkout\third_party\pyasn1;C:\b\rr\tmpqzqied\rw\checkout\third_party\pyasn1-modules;C:\b\rr\tmpqzqied\rw\checkout\third_party\python-rsa;C:\b\rr\tmpqzqied\rw\checkout\third_party\requests_2_10_0;C:\b\rr\tmpqzqied\rw\checkout\third_party\setuptools-0.6c11;C:\b\rr\tmpqzqied\rw\checkout\third_party\sqlalchemy_0_7_1;C:\b\rr\tmpqzqied\rw\checkout\third_party\sqlalchemy_migrate_0_7_1;C:\b\rr\tmpqzqied\rw\checkout\third_party\tempita_0_5;C:\b\rr\tmpqzqied\rw\checkout\third_party\twisted_10_2;C:\b\rr\tmpqzqied\rw\checkout\third_party\uritemplate;C:\b\rr\tmpqzqied\rw\checkout\third_party\site-packages;C:\b\rr\tmpqzqied\rw\checkout\scripts\tools;C:\b\build\third_party\google_api_python_client;C:\b\build\site_config;C:\b\build\scripts;C:\b\build\scripts\release;C:\b\build\third_party;C:\b\build\third_party\httplib2\python2;C:\b\build\third_party\infra_libs;C:\b\build\third_party\oauth2client;C:\b\build\third_party\pyasn1;C:\b\build\third_party\pyasn1-modules;C:\b\build\third_party\python-rsa;C:\b\build\third_party\requests_2_10_0;C:\b\build\third_party\setuptools-0.6c11;C:\b\build\third_party\uritemplate;C:\b\build_internal\site_config;C:\b\build_internal\symsrc;C:\b\build\slave;C:\b\build\third_party\buildbot_slave_8_4;C:\b\build\third_party\twisted_10_2;C:\b\rr\tmpqzqied\w;C:\b\depot_tools\win_tools-2_7_6_bin\python\bin\python27.zip;C:\b\depot_tools\win_tools-2_7_6_bin\python\bin\DLLs;C:\b\depot_tools\win_tools-2_7_6_bin\python\bin\lib;C:\b\depot_tools\win_tools-2_7_6_bin\python\bin\lib\plat-win;C:\b\depot_tools\win_tools-2_7_6_bin\python\bin\lib\lib-tk;C:\b\depot_tools\win_tools-2_7_6_bin\python\bin
WARNING:root:task_output_dir 'c:\\users\\chrome~1\\appdata\\local\\temp\\tmp5ietr3' already exists!
WARNING:root:task_output_dir existing content: []
+------------------------------------------------------------------------+
| Shard 0  https://chromium-swarm.appspot.com/user/task/3b1f4a5f9ddd8810 |
+------------------------------------------------------------------------+
Additional test environment:
    CHROME_DEVEL_SANDBOX=/opt/chromium/chrome_sandbox
    CHROME_HEADLESS=1
    LANG=en_US.UTF-8
Command: .\gl_unittests.exe --brave-new-test-launcher --test-launcher-bot-mode --cfi-diag=0 --use-gpu-in-tests --test-launcher-summary-output=c:\b\s\w\ionitoai\output.json
IMPORTANT DEBUGGING NOTE: batches of tests are run inside their
own process. For debugging a test inside a debugger, use the
--gtest_filter=<your_test_name> flag along with
--single-process-tests.
Using sharding settings from environment. This is shard 0/1
Using 8 parallel jobs.
[1/48] EGLApiTest.DisabledExtensionStringTest (0 ms)
[2/48] EGLInitializationDisplaysTest.DisableD3D11 (0 ms)
[3/48] EGLInitializationDisplaysTest.SwiftShader (0 ms)
[4/48] EGLInitializationDisplaysTest.DefaultRenderers (0 ms)
[5/48] EGLInitializationDisplaysTest.NonDefaultRenderers (0 ms)
[6/48] EGLInitializationDisplaysTest.NoExtensions (0 ms)
[7/48] WGLApiTest.DisabledExtensionBitTest (0 ms)
[8/48] WGLApiTest.DisabledExtensionStringTest (0 ms)
[9/48] GLSurfaceFormatTest.BasicTest (0 ms)
[10/48] GLVersionInfoTest.MajorMinorVersionTest (0 ms)
[11/48] GPUTimingTest.FakeTimerTest (1 ms)
[12/48] GPUTimingTest.ForceTimeElapsedQuery (0 ms)
[13/48] GPUTimingTest.QueryTimeStampTest (1 ms)
[14/48] GPUTimingTest.QueryTimeStampUsingElapsedTest (0 ms)
[15/48] GPUTimingTest.QueryTimestampUsingElapsedARBTest (1 ms)
[16/48] GLSurfaceEGLTest.SurfaceFormatTest (732 ms)
[17/48] GLSurfaceEGLTest.FixedSizeExtension (31 ms)
[18/48] EGLApiTest.DisabledExtensionBitTest (12 ms)
[19/48] GLApiTest.DisabledExtensionStringTest (0 ms)
[20/48] GLApiTest.DisabledExtensionBitTest (0 ms)
[21/48] GLApiTest.DisabledExtensionStringIndexTest (0 ms)
[22/48] GLImageRefCountedMemory/GLImageTest/0.Create (750 ms)
[23/48] GLImageRefCountedMemory/GLImageTest/1.Create (30 ms)
[24/48] GLImageRefCountedMemory/GLImageTest/2.Create (25 ms)
[25/48] GLImageRefCountedMemory/GLImageTest/3.Create (22 ms)
[26/48] GLImageRefCountedMemory/GLImageCopyTest/0.CopyTexImage (261 ms)
[27/48] GLImageRefCountedMemory/GLImageCopyTest/1.CopyTexImage (46 ms)
[28/48] GLImageRefCountedMemory/GLImageCopyTest/2.CopyTexImage (45 ms)
[29/48] GLImageRefCountedMemory/GLImageCopyTest/3.CopyTexImage (1088 ms)
[30/48] GLImageSharedMemory/GLImageTest/0.Create (28 ms)
[31/48] GLImageSharedMemory/GLImageTest/1.Create (24 ms)
[32/48] GLImageSharedMemory/GLImageTest/2.Create (25 ms)
[33/48] GLImageSharedMemory/GLImageTest/3.Create (28 ms)
[34/48] GLImageSharedMemory/GLImageTest/4.Create (22 ms)
[35/48] GLImageSharedMemory/GLImageTest/5.Create (19 ms)
[36/48] GLImageSharedMemory/GLImageOddSizeTest/0.Create (19 ms)
[37/48] GLImageSharedMemory/GLImageOddSizeTest/1.Create (20 ms)
[38/48] GLImageSharedMemory/GLImageOddSizeTest/2.Create (21 ms)
Failed to get out-of-band test success data, dumping full stdio below:
Note: Google Test filter = GLImageSharedMemory/GLImageOddSizeTest/3.Create:GLImageSharedMemory/GLImageOddSizeTest/4.Create:GLImageSharedMemory/GLImageOddSizeTest/5.Create:GLImageSharedMemory/GLImageCopyTest/0.CopyTexImage:GLImageSharedMemory/GLImageCopyTest/1.CopyTexImage:GLImageSharedMemory/GLImageCopyTest/2.CopyTexImage:GLImageSharedMemory/GLImageCopyTest/3.CopyTexImage:GLImageSharedMemory/GLImageCopyTest/4.CopyTexImage:GLImageSharedMemory/GLImageCopyTest/5.CopyTexImage:GLImageSharedMemoryPool/GLImageCopyTest/0.CopyTexImage
[==========] Running 10 tests from 10 test cases.
[----------] Global test environment set-up.
[----------] 1 test from GLImageSharedMemory/GLImageOddSizeTest/3, where TypeParam = <type>
[ RUN      ] GLImageSharedMemory/GLImageOddSizeTest/3.Create
[       OK ] GLImageSharedMemory/GLImageOddSizeTest/3.Create (748 ms)
[----------] 1 test from GLImageSharedMemory/GLImageOddSizeTest/3 (748 ms total)
[----------] 1 test from GLImageSharedMemory/GLImageOddSizeTest/4, where TypeParam = <type>
[ RUN      ] GLImageSharedMemory/GLImageOddSizeTest/4.Create
[       OK ] GLImageSharedMemory/GLImageOddSizeTest/4.Create (30 ms)
[----------] 1 test from GLImageSharedMemory/GLImageOddSizeTest/4 (30 ms total)
[----------] 1 test from GLImageSharedMemory/GLImageOddSizeTest/5, where TypeParam = <type>
[ RUN      ] GLImageSharedMemory/GLImageOddSizeTest/5.Create
[       OK ] GLImageSharedMemory/GLImageOddSizeTest/5.Create (26 ms)
[----------] 1 test from GLImageSharedMemory/GLImageOddSizeTest/5 (26 ms total)
[----------] 1 test from GLImageSharedMemory/GLImageCopyTest/0, where TypeParam = <type>
[ RUN      ] GLImageSharedMemory/GLImageCopyTest/0.CopyTexImage
[       OK ] GLImageSharedMemory/GLImageCopyTest/0.CopyTexImage (283 ms)
[----------] 1 test from GLImageSharedMemory/GLImageCopyTest/0 (283 ms total)
[----------] 1 test from GLImageSharedMemory/GLImageCopyTest/1, where TypeParam = <type>
[ RUN      ] GLImageSharedMemory/GLImageCopyTest/1.CopyTexImage
[       OK ] GLImageSharedMemory/GLImageCopyTest/1.CopyTexImage (46 ms)
[----------] 1 test from GLImageSharedMemory/GLImageCopyTest/1 (46 ms total)
[----------] 1 test from GLImageSharedMemory/GLImageCopyTest/2, where TypeParam = <type>
[ RUN      ] GLImageSharedMemory/GLImageCopyTest/2.CopyTexImage
[       OK ] GLImageSharedMemory/GLImageCopyTest/2.CopyTexImage (45 ms)
[----------] 1 test from GLImageSharedMemory/GLImageCopyTest/2 (45 ms total)
[----------] 1 test from GLImageSharedMemory/GLImageCopyTest/3, where TypeParam = <type>
[ RUN      ] GLImageSharedMemory/GLImageCopyTest/3.CopyTexImage
[       OK ] GLImageSharedMemory/GLImageCopyTest/3.CopyTexImage (33 ms)
[----------] 1 test from GLImageSharedMemory/GLImageCopyTest/3 (33 ms total)
[----------] 1 test from GLImageSharedMemory/GLImageCopyTest/4, where TypeParam = <type>
[ RUN      ] GLImageSharedMemory/GLImageCopyTest/4.CopyTexImage
[       OK ] GLImageSharedMemory/GLImageCopyTest/4.CopyTexImage (35 ms)
[----------] 1 test from GLImageSharedMemory/GLImageCopyTest/4 (35 ms total)
[----------] 1 test from GLImageSharedMemory/GLImageCopyTest/5, where TypeParam = <type>
[ RUN      ] GLImageSharedMemory/GLImageCopyTest/5.CopyTexImage
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 32, which exceeds error, where
expected evaluates to 32,
actual evaluates to 0, and
error evaluates to 0.
 at 0, 0 channel 1
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 255, which exceeds error, where
expected evaluates to 0,
actual evaluates to 255, and
error evaluates to 0.
 at 0, 0 channel 2
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 32, which exceeds error, where
expected evaluates to 32,
actual evaluates to 0, and
error evaluates to 0.
 at 1, 0 channel 1
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 255, which exceeds error, where
expected evaluates to 0,
actual evaluates to 255, and
error evaluates to 0.
 at 1, 0 channel 2
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 32, which exceeds error, where
expected evaluates to 32,
actual evaluates to 0, and
error evaluates to 0.
 at 2, 0 channel 1
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 255, which exceeds error, where
expected evaluates to 0,
actual evaluates to 255, and
error evaluates to 0.
 at 2, 0 channel 2
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 32, which exceeds error, where
expected evaluates to 32,
actual evaluates to 0, and
error evaluates to 0.
 at 3, 0 channel 1
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 255, which exceeds error, where
expected evaluates to 0,
actual evaluates to 255, and
error evaluates to 0.
 at 3, 0 channel 2
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 32, which exceeds error, where
expected evaluates to 32,
actual evaluates to 0, and
error evaluates to 0.
 at 4, 0 channel 1
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 255, which exceeds error, where
expected evaluates to 0,
actual evaluates to 255, and
error evaluates to 0.
 at 4, 0 channel 2
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 32, which exceeds error, where
expected evaluates to 32,
actual evaluates to 0, and
error evaluates to 0.
 at 5, 0 channel 1
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 255, which exceeds error, where
expected evaluates to 0,
actual evaluates to 255, and
error evaluates to 0.
 at 5, 0 channel 2
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 32, which exceeds error, where
expected evaluates to 32,
actual evaluates to 0, and
error evaluates to 0.
 at 6, 0 channel 1
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 255, which exceeds error, where
expected evaluates to 0,
actual evaluates to 255, and
error evaluates to 0.
 at 6, 0 channel 2
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 32, which exceeds error, where
expected evaluates to 32,
actual evaluates to 0, and
error evaluates to 0.
 at 7, 0 channel 1
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 255, which exceeds error, where
expected evaluates to 0,
actual evaluates to 255, and
error evaluates to 0.
 at 7, 0 channel 2
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 32, which exceeds error, where
expected evaluates to 32,
actual evaluates to 0, and
error evaluates to 0.
 at 8, 0 channel 1
[  FAILED  ] GLImageSharedMemory/GLImageCopyTest/5.CopyTexImage, where TypeParam = <type> (34 ms)
[----------] 1 test from GLImageSharedMemory/GLImageCopyTest/5 (34 ms total)
[----------] 1 test from GLImageSharedMemoryPool/GLImageCopyTest/0, where TypeParam = <type>
[ RUN      ] GLImageSharedMemoryPool/GLImageCopyTest/0.CopyTexImage
[       OK ] GLImageSharedMemoryPool/GLImageCopyTest/0.CopyTexImage (31 ms)
[----------] 1 test from GLImageSharedMemoryPool/GLImageCopyTest/0 (31 ms total)
[----------] Global test environment tear-down
[==========] 10 tests from 10 test cases ran. (1311 ms total)
[  PASSED  ] 9 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] GLImageSharedMemory/GLImageCopyTest/5.CopyTexImage, where TypeParam = <type>
 1 FAILED TEST
[39/48] GLImageSharedMemory/GLImageOddSizeTest/4.Create (74 ms)
[40/48] GLImageSharedMemory/GLImageOddSizeTest/5.Create (77 ms)
[41/48] GLImageSharedMemory/GLImageOddSizeTest/3.Create (81 ms)
[42/48] GLImageSharedMemory/GLImageCopyTest/1.CopyTexImage (101 ms)
[43/48] GLImageSharedMemory/GLImageCopyTest/0.CopyTexImage (105 ms)
[44/48] GLImageSharedMemory/GLImageCopyTest/4.CopyTexImage (106 ms)
[45/48] GLImageSharedMemory/GLImageCopyTest/3.CopyTexImage (109 ms)
[46/48] GLImageSharedMemory/GLImageCopyTest/2.CopyTexImage (111 ms)
Failed to get out-of-band test success data, dumping full stdio below:
Note: Google Test filter = GLImageSharedMemory/GLImageCopyTest/5.CopyTexImage
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from GLImageSharedMemory/GLImageCopyTest/5, where TypeParam = <type>
[ RUN      ] GLImageSharedMemory/GLImageCopyTest/5.CopyTexImage
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 32, which exceeds error, where
expected evaluates to 32,
actual evaluates to 0, and
error evaluates to 0.
 at 0, 0 channel 1
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 255, which exceeds error, where
expected evaluates to 0,
actual evaluates to 255, and
error evaluates to 0.
 at 0, 0 channel 2
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 32, which exceeds error, where
expected evaluates to 32,
actual evaluates to 0, and
error evaluates to 0.
 at 1, 0 channel 1
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 255, which exceeds error, where
expected evaluates to 0,
actual evaluates to 255, and
error evaluates to 0.
 at 1, 0 channel 2
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 32, which exceeds error, where
expected evaluates to 32,
actual evaluates to 0, and
error evaluates to 0.
 at 2, 0 channel 1
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 255, which exceeds error, where
expected evaluates to 0,
actual evaluates to 255, and
error evaluates to 0.
 at 2, 0 channel 2
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 32, which exceeds error, where
expected evaluates to 32,
actual evaluates to 0, and
error evaluates to 0.
 at 3, 0 channel 1
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 255, which exceeds error, where
expected evaluates to 0,
actual evaluates to 255, and
error evaluates to 0.
 at 3, 0 channel 2
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 32, which exceeds error, where
expected evaluates to 32,
actual evaluates to 0, and
error evaluates to 0.
 at 4, 0 channel 1
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 255, which exceeds error, where
expected evaluates to 0,
actual evaluates to 255, and
error evaluates to 0.
 at 4, 0 channel 2
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 32, which exceeds error, where
expected evaluates to 32,
actual evaluates to 0, and
error evaluates to 0.
 at 5, 0 channel 1
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 255, which exceeds error, where
expected evaluates to 0,
actual evaluates to 255, and
error evaluates to 0.
 at 5, 0 channel 2
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 32, which exceeds error, where
expected evaluates to 32,
actual evaluates to 0, and
error evaluates to 0.
 at 6, 0 channel 1
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 255, which exceeds error, where
expected evaluates to 0,
actual evaluates to 255, and
error evaluates to 0.
 at 6, 0 channel 2
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 32, which exceeds error, where
expected evaluates to 32,
actual evaluates to 0, and
error evaluates to 0.
 at 7, 0 channel 1
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 255, which exceeds error, where
expected evaluates to 0,
actual evaluates to 255, and
error evaluates to 0.
 at 7, 0 channel 2
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 32, which exceeds error, where
expected evaluates to 32,
actual evaluates to 0, and
error evaluates to 0.
 at 8, 0 channel 1
[  FAILED  ] GLImageSharedMemory/GLImageCopyTest/5.CopyTexImage, where TypeParam = <type> (55 ms)
[----------] 1 test from GLImageSharedMemory/GLImageCopyTest/5 (55 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (55 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] GLImageSharedMemory/GLImageCopyTest/5.CopyTexImage, where TypeParam = <type>
 1 FAILED TEST
[47/48] GLImageSharedMemory/GLImageCopyTest/5.CopyTexImage (0 ms)
[48/48] GLImageSharedMemoryPool/GLImageCopyTest/0.CopyTexImage (54 ms)
Retrying 1 test (retry #1)
Failed to get out-of-band test success data, dumping full stdio below:
Note: Google Test filter = GLImageSharedMemory/GLImageCopyTest/5.CopyTexImage
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from GLImageSharedMemory/GLImageCopyTest/5, where TypeParam = <type>
[ RUN      ] GLImageSharedMemory/GLImageCopyTest/5.CopyTexImage
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 32, which exceeds error, where
expected evaluates to 32,
actual evaluates to 0, and
error evaluates to 0.
 at 0, 0 channel 1
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 255, which exceeds error, where
expected evaluates to 0,
actual evaluates to 255, and
error evaluates to 0.
 at 0, 0 channel 2
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 32, which exceeds error, where
expected evaluates to 32,
actual evaluates to 0, and
error evaluates to 0.
 at 1, 0 channel 1
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 255, which exceeds error, where
expected evaluates to 0,
actual evaluates to 255, and
error evaluates to 0.
 at 1, 0 channel 2
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 32, which exceeds error, where
expected evaluates to 32,
actual evaluates to 0, and
error evaluates to 0.
 at 2, 0 channel 1
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 255, which exceeds error, where
expected evaluates to 0,
actual evaluates to 255, and
error evaluates to 0.
 at 2, 0 channel 2
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 32, which exceeds error, where
expected evaluates to 32,
actual evaluates to 0, and
error evaluates to 0.
 at 3, 0 channel 1
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 255, which exceeds error, where
expected evaluates to 0,
actual evaluates to 255, and
error evaluates to 0.
 at 3, 0 channel 2
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 32, which exceeds error, where
expected evaluates to 32,
actual evaluates to 0, and
error evaluates to 0.
 at 4, 0 channel 1
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 255, which exceeds error, where
expected evaluates to 0,
actual evaluates to 255, and
error evaluates to 0.
 at 4, 0 channel 2
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 32, which exceeds error, where
expected evaluates to 32,
actual evaluates to 0, and
error evaluates to 0.
 at 5, 0 channel 1
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 255, which exceeds error, where
expected evaluates to 0,
actual evaluates to 255, and
error evaluates to 0.
 at 5, 0 channel 2
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 32, which exceeds error, where
expected evaluates to 32,
actual evaluates to 0, and
error evaluates to 0.
 at 6, 0 channel 1
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 255, which exceeds error, where
expected evaluates to 0,
actual evaluates to 255, and
error evaluates to 0.
 at 6, 0 channel 2
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 32, which exceeds error, where
expected evaluates to 32,
actual evaluates to 0, and
error evaluates to 0.
 at 7, 0 channel 1
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 255, which exceeds error, where
expected evaluates to 0,
actual evaluates to 255, and
error evaluates to 0.
 at 7, 0 channel 2
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 32, which exceeds error, where
expected evaluates to 32,
actual evaluates to 0, and
error evaluates to 0.
 at 8, 0 channel 1
[  FAILED  ] GLImageSharedMemory/GLImageCopyTest/5.CopyTexImage, where TypeParam = <type> (40 ms)
[----------] 1 test from GLImageSharedMemory/GLImageCopyTest/5 (40 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (40 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] GLImageSharedMemory/GLImageCopyTest/5.CopyTexImage, where TypeParam = <type>
 1 FAILED TEST
[49/49] GLImageSharedMemory/GLImageCopyTest/5.CopyTexImage (0 ms)
Retrying 1 test (retry #2)
Failed to get out-of-band test success data, dumping full stdio below:
Note: Google Test filter = GLImageSharedMemory/GLImageCopyTest/5.CopyTexImage
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from GLImageSharedMemory/GLImageCopyTest/5, where TypeParam = <type>
[ RUN      ] GLImageSharedMemory/GLImageCopyTest/5.CopyTexImage
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 32, which exceeds error, where
expected evaluates to 32,
actual evaluates to 0, and
error evaluates to 0.
 at 0, 0 channel 1
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 255, which exceeds error, where
expected evaluates to 0,
actual evaluates to 255, and
error evaluates to 0.
 at 0, 0 channel 2
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 32, which exceeds error, where
expected evaluates to 32,
actual evaluates to 0, and
error evaluates to 0.
 at 1, 0 channel 1
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 255, which exceeds error, where
expected evaluates to 0,
actual evaluates to 255, and
error evaluates to 0.
 at 1, 0 channel 2
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 32, which exceeds error, where
expected evaluates to 32,
actual evaluates to 0, and
error evaluates to 0.
 at 2, 0 channel 1
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 255, which exceeds error, where
expected evaluates to 0,
actual evaluates to 255, and
error evaluates to 0.
 at 2, 0 channel 2
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 32, which exceeds error, where
expected evaluates to 32,
actual evaluates to 0, and
error evaluates to 0.
 at 3, 0 channel 1
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 255, which exceeds error, where
expected evaluates to 0,
actual evaluates to 255, and
error evaluates to 0.
 at 3, 0 channel 2
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 32, which exceeds error, where
expected evaluates to 32,
actual evaluates to 0, and
error evaluates to 0.
 at 4, 0 channel 1
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 255, which exceeds error, where
expected evaluates to 0,
actual evaluates to 255, and
error evaluates to 0.
 at 4, 0 channel 2
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 32, which exceeds error, where
expected evaluates to 32,
actual evaluates to 0, and
error evaluates to 0.
 at 5, 0 channel 1
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 255, which exceeds error, where
expected evaluates to 0,
actual evaluates to 255, and
error evaluates to 0.
 at 5, 0 channel 2
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 32, which exceeds error, where
expected evaluates to 32,
actual evaluates to 0, and
error evaluates to 0.
 at 6, 0 channel 1
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 255, which exceeds error, where
expected evaluates to 0,
actual evaluates to 255, and
error evaluates to 0.
 at 6, 0 channel 2
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 32, which exceeds error, where
expected evaluates to 32,
actual evaluates to 0, and
error evaluates to 0.
 at 7, 0 channel 1
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 255, which exceeds error, where
expected evaluates to 0,
actual evaluates to 255, and
error evaluates to 0.
 at 7, 0 channel 2
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 32, which exceeds error, where
expected evaluates to 32,
actual evaluates to 0, and
error evaluates to 0.
 at 8, 0 channel 1
[  FAILED  ] GLImageSharedMemory/GLImageCopyTest/5.CopyTexImage, where TypeParam = <type> (41 ms)
[----------] 1 test from GLImageSharedMemory/GLImageCopyTest/5 (41 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (41 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] GLImageSharedMemory/GLImageCopyTest/5.CopyTexImage, where TypeParam = <type>
 1 FAILED TEST
[50/50] GLImageSharedMemory/GLImageCopyTest/5.CopyTexImage (0 ms)
Retrying 1 test (retry #3)
Failed to get out-of-band test success data, dumping full stdio below:
Note: Google Test filter = GLImageSharedMemory/GLImageCopyTest/5.CopyTexImage
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from GLImageSharedMemory/GLImageCopyTest/5, where TypeParam = <type>
[ RUN      ] GLImageSharedMemory/GLImageCopyTest/5.CopyTexImage
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 32, which exceeds error, where
expected evaluates to 32,
actual evaluates to 0, and
error evaluates to 0.
 at 0, 0 channel 1
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 255, which exceeds error, where
expected evaluates to 0,
actual evaluates to 255, and
error evaluates to 0.
 at 0, 0 channel 2
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 32, which exceeds error, where
expected evaluates to 32,
actual evaluates to 0, and
error evaluates to 0.
 at 1, 0 channel 1
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 255, which exceeds error, where
expected evaluates to 0,
actual evaluates to 255, and
error evaluates to 0.
 at 1, 0 channel 2
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 32, which exceeds error, where
expected evaluates to 32,
actual evaluates to 0, and
error evaluates to 0.
 at 2, 0 channel 1
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 255, which exceeds error, where
expected evaluates to 0,
actual evaluates to 255, and
error evaluates to 0.
 at 2, 0 channel 2
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 32, which exceeds error, where
expected evaluates to 32,
actual evaluates to 0, and
error evaluates to 0.
 at 3, 0 channel 1
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 255, which exceeds error, where
expected evaluates to 0,
actual evaluates to 255, and
error evaluates to 0.
 at 3, 0 channel 2
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 32, which exceeds error, where
expected evaluates to 32,
actual evaluates to 0, and
error evaluates to 0.
 at 4, 0 channel 1
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 255, which exceeds error, where
expected evaluates to 0,
actual evaluates to 255, and
error evaluates to 0.
 at 4, 0 channel 2
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 32, which exceeds error, where
expected evaluates to 32,
actual evaluates to 0, and
error evaluates to 0.
 at 5, 0 channel 1
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 255, which exceeds error, where
expected evaluates to 0,
actual evaluates to 255, and
error evaluates to 0.
 at 5, 0 channel 2
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 32, which exceeds error, where
expected evaluates to 32,
actual evaluates to 0, and
error evaluates to 0.
 at 6, 0 channel 1
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 255, which exceeds error, where
expected evaluates to 0,
actual evaluates to 255, and
error evaluates to 0.
 at 6, 0 channel 2
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 32, which exceeds error, where
expected evaluates to 32,
actual evaluates to 0, and
error evaluates to 0.
 at 7, 0 channel 1
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 255, which exceeds error, where
expected evaluates to 0,
actual evaluates to 255, and
error evaluates to 0.
 at 7, 0 channel 2
../../ui/gl/test/gl_test_helper.cc(77): error: The difference between expected and actual is 32, which exceeds error, where
expected evaluates to 32,
actual evaluates to 0, and
error evaluates to 0.
 at 8, 0 channel 1
[  FAILED  ] GLImageSharedMemory/GLImageCopyTest/5.CopyTexImage, where TypeParam = <type> (40 ms)
[----------] 1 test from GLImageSharedMemory/GLImageCopyTest/5 (40 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (40 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] GLImageSharedMemory/GLImageCopyTest/5.CopyTexImage, where TypeParam = <type>
 1 FAILED TEST
[51/51] GLImageSharedMemory/GLImageCopyTest/5.CopyTexImage (0 ms)
1 test failed:
    GLImageSharedMemory/GLImageCopyTest/5.CopyTexImage (../..\ui/gl/test/gl_image_test_template.h:252)
Tests took 1 seconds.
+------------------------------------------------------------------------+
| End of shard 0                                                         |
|  Pending: 0.8s  Duration: 1.8s  Bot: build881-m4  Exit: 1              |
+------------------------------------------------------------------------+
Total duration: 1.8s
WARNING:root:collect_cmd had non-zero return code: 1
step returned non-zero exit code: 1

 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/673d8eb65e0b08e9af8c68012b9b1a165d605c5b

commit 673d8eb65e0b08e9af8c68012b9b1a165d605c5b
Author: Miguel Casas <mcasas@chromium.org>
Date: Sun Feb 18 13:58:28 2018

GpuMemoryBuffer: add image_xb30 capability and RGBX_1010102 BufferFormat

This CL adds a new Gpu FeatureInfo::FeatureFlags and command buffer
Capabilities to signal support for image_xb30, in parallel to the
existing image_xr30. The new flag is used on platforms supporting
glTexImage2D() with data format GL_RGB(A), namely >=gles3, >=gl3.3
or those with the appropriate GL extension.

This CL also adds a new GpuMemoryBuffer format RGBX_1010102 to
be used where image_xb30 is signalled.

With all this, Mac will use image_xr30 <-> BGRX_1010102, and the
GLES3+/GL3.3+ platforms will use image_xb30 <-> RGBX_1010102.

Bug:  803975 , 776093, 803451,  808172 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I00c834b68ce81d93e0f55694d891186ed3b75611
Reviewed-on: https://chromium-review.googlesource.com/920361
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537561}
[modify] https://crrev.com/673d8eb65e0b08e9af8c68012b9b1a165d605c5b/cc/resources/video_resource_updater.cc
[modify] https://crrev.com/673d8eb65e0b08e9af8c68012b9b1a165d605c5b/components/exo/buffer.cc
[modify] https://crrev.com/673d8eb65e0b08e9af8c68012b9b1a165d605c5b/content/renderer/media/gpu/gpu_video_accelerator_factories_impl.cc
[modify] https://crrev.com/673d8eb65e0b08e9af8c68012b9b1a165d605c5b/gpu/command_buffer/client/gles2_implementation.cc
[modify] https://crrev.com/673d8eb65e0b08e9af8c68012b9b1a165d605c5b/gpu/command_buffer/common/capabilities.h
[modify] https://crrev.com/673d8eb65e0b08e9af8c68012b9b1a165d605c5b/gpu/command_buffer/common/gpu_memory_buffer_support.cc
[modify] https://crrev.com/673d8eb65e0b08e9af8c68012b9b1a165d605c5b/gpu/command_buffer/service/feature_info.cc
[modify] https://crrev.com/673d8eb65e0b08e9af8c68012b9b1a165d605c5b/gpu/command_buffer/service/feature_info.h
[modify] https://crrev.com/673d8eb65e0b08e9af8c68012b9b1a165d605c5b/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/673d8eb65e0b08e9af8c68012b9b1a165d605c5b/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc
[modify] https://crrev.com/673d8eb65e0b08e9af8c68012b9b1a165d605c5b/gpu/command_buffer/service/texture_manager.cc
[modify] https://crrev.com/673d8eb65e0b08e9af8c68012b9b1a165d605c5b/gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc
[modify] https://crrev.com/673d8eb65e0b08e9af8c68012b9b1a165d605c5b/gpu/command_buffer/tests/gl_unittest.cc
[modify] https://crrev.com/673d8eb65e0b08e9af8c68012b9b1a165d605c5b/gpu/ipc/client/gpu_memory_buffer_impl_shared_memory.cc
[modify] https://crrev.com/673d8eb65e0b08e9af8c68012b9b1a165d605c5b/gpu/ipc/common/gpu_command_buffer_traits_multi.h
[modify] https://crrev.com/673d8eb65e0b08e9af8c68012b9b1a165d605c5b/gpu/ipc/host/gpu_memory_buffer_support.cc
[modify] https://crrev.com/673d8eb65e0b08e9af8c68012b9b1a165d605c5b/media/base/video_frame.cc
[modify] https://crrev.com/673d8eb65e0b08e9af8c68012b9b1a165d605c5b/media/video/gpu_memory_buffer_video_frame_pool.cc
[modify] https://crrev.com/673d8eb65e0b08e9af8c68012b9b1a165d605c5b/media/video/gpu_memory_buffer_video_frame_pool_unittest.cc
[modify] https://crrev.com/673d8eb65e0b08e9af8c68012b9b1a165d605c5b/media/video/gpu_video_accelerator_factories.h
[modify] https://crrev.com/673d8eb65e0b08e9af8c68012b9b1a165d605c5b/media/video/mock_gpu_video_accelerator_factories.cc
[modify] https://crrev.com/673d8eb65e0b08e9af8c68012b9b1a165d605c5b/ui/gfx/buffer_format_util.cc
[modify] https://crrev.com/673d8eb65e0b08e9af8c68012b9b1a165d605c5b/ui/gfx/buffer_types.h
[modify] https://crrev.com/673d8eb65e0b08e9af8c68012b9b1a165d605c5b/ui/gfx/mac/io_surface.cc
[modify] https://crrev.com/673d8eb65e0b08e9af8c68012b9b1a165d605c5b/ui/gfx/mojo/buffer_types.mojom
[modify] https://crrev.com/673d8eb65e0b08e9af8c68012b9b1a165d605c5b/ui/gfx/mojo/buffer_types_struct_traits.h
[modify] https://crrev.com/673d8eb65e0b08e9af8c68012b9b1a165d605c5b/ui/gl/gl_image_io_surface.mm
[modify] https://crrev.com/673d8eb65e0b08e9af8c68012b9b1a165d605c5b/ui/gl/gl_image_memory.cc
[modify] https://crrev.com/673d8eb65e0b08e9af8c68012b9b1a165d605c5b/ui/gl/gl_image_native_pixmap.cc
[modify] https://crrev.com/673d8eb65e0b08e9af8c68012b9b1a165d605c5b/ui/gl/gl_image_shared_memory_unittest.cc
[modify] https://crrev.com/673d8eb65e0b08e9af8c68012b9b1a165d605c5b/ui/gl/test/gl_image_test_support.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d703a382302681ad0c8443ccb8a9bac86ea4b4c1

commit d703a382302681ad0c8443ccb8a9bac86ea4b4c1
Author: Takeshi Yoshino <tyoshino@chromium.org>
Date: Mon Feb 19 05:49:11 2018

Revert "GpuMemoryBuffer: add image_xb30 capability and RGBX_1010102 BufferFormat"

This reverts commit 673d8eb65e0b08e9af8c68012b9b1a165d605c5b.

Reason for revert: Looks this has broken linux-chromeos-rel build. See https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=EGLApiTest.DisabledExtensionBitTest&testType=gl_unittests_ozone

Original change's description:
> GpuMemoryBuffer: add image_xb30 capability and RGBX_1010102 BufferFormat
> 
> This CL adds a new Gpu FeatureInfo::FeatureFlags and command buffer
> Capabilities to signal support for image_xb30, in parallel to the
> existing image_xr30. The new flag is used on platforms supporting
> glTexImage2D() with data format GL_RGB(A), namely >=gles3, >=gl3.3
> or those with the appropriate GL extension.
> 
> This CL also adds a new GpuMemoryBuffer format RGBX_1010102 to
> be used where image_xb30 is signalled.
> 
> With all this, Mac will use image_xr30 <-> BGRX_1010102, and the
> GLES3+/GL3.3+ platforms will use image_xb30 <-> RGBX_1010102.
> 
> Bug:  803975 , 776093, 803451,  808172 
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: I00c834b68ce81d93e0f55694d891186ed3b75611
> Reviewed-on: https://chromium-review.googlesource.com/920361
> Reviewed-by: David Reveman <reveman@chromium.org>
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
> Commit-Queue: Miguel Casas <mcasas@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#537561}

TBR=avi@chromium.org,reveman@chromium.org,dalecurtis@chromium.org,mcasas@chromium.org,dcastagna@chromium.org,rsesek@chromium.org,piman@chromium.org

Change-Id: I08563c74c65ed18ea7dd78e41220a3607b7c9ad5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  803975 , 776093, 803451,  808172 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/923448
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537583}
[modify] https://crrev.com/d703a382302681ad0c8443ccb8a9bac86ea4b4c1/cc/resources/video_resource_updater.cc
[modify] https://crrev.com/d703a382302681ad0c8443ccb8a9bac86ea4b4c1/components/exo/buffer.cc
[modify] https://crrev.com/d703a382302681ad0c8443ccb8a9bac86ea4b4c1/content/renderer/media/gpu/gpu_video_accelerator_factories_impl.cc
[modify] https://crrev.com/d703a382302681ad0c8443ccb8a9bac86ea4b4c1/gpu/command_buffer/client/gles2_implementation.cc
[modify] https://crrev.com/d703a382302681ad0c8443ccb8a9bac86ea4b4c1/gpu/command_buffer/common/capabilities.h
[modify] https://crrev.com/d703a382302681ad0c8443ccb8a9bac86ea4b4c1/gpu/command_buffer/common/gpu_memory_buffer_support.cc
[modify] https://crrev.com/d703a382302681ad0c8443ccb8a9bac86ea4b4c1/gpu/command_buffer/service/feature_info.cc
[modify] https://crrev.com/d703a382302681ad0c8443ccb8a9bac86ea4b4c1/gpu/command_buffer/service/feature_info.h
[modify] https://crrev.com/d703a382302681ad0c8443ccb8a9bac86ea4b4c1/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/d703a382302681ad0c8443ccb8a9bac86ea4b4c1/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc
[modify] https://crrev.com/d703a382302681ad0c8443ccb8a9bac86ea4b4c1/gpu/command_buffer/service/texture_manager.cc
[modify] https://crrev.com/d703a382302681ad0c8443ccb8a9bac86ea4b4c1/gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc
[modify] https://crrev.com/d703a382302681ad0c8443ccb8a9bac86ea4b4c1/gpu/command_buffer/tests/gl_unittest.cc
[modify] https://crrev.com/d703a382302681ad0c8443ccb8a9bac86ea4b4c1/gpu/ipc/client/gpu_memory_buffer_impl_shared_memory.cc
[modify] https://crrev.com/d703a382302681ad0c8443ccb8a9bac86ea4b4c1/gpu/ipc/common/gpu_command_buffer_traits_multi.h
[modify] https://crrev.com/d703a382302681ad0c8443ccb8a9bac86ea4b4c1/gpu/ipc/host/gpu_memory_buffer_support.cc
[modify] https://crrev.com/d703a382302681ad0c8443ccb8a9bac86ea4b4c1/media/base/video_frame.cc
[modify] https://crrev.com/d703a382302681ad0c8443ccb8a9bac86ea4b4c1/media/video/gpu_memory_buffer_video_frame_pool.cc
[modify] https://crrev.com/d703a382302681ad0c8443ccb8a9bac86ea4b4c1/media/video/gpu_memory_buffer_video_frame_pool_unittest.cc
[modify] https://crrev.com/d703a382302681ad0c8443ccb8a9bac86ea4b4c1/media/video/gpu_video_accelerator_factories.h
[modify] https://crrev.com/d703a382302681ad0c8443ccb8a9bac86ea4b4c1/media/video/mock_gpu_video_accelerator_factories.cc
[modify] https://crrev.com/d703a382302681ad0c8443ccb8a9bac86ea4b4c1/ui/gfx/buffer_format_util.cc
[modify] https://crrev.com/d703a382302681ad0c8443ccb8a9bac86ea4b4c1/ui/gfx/buffer_types.h
[modify] https://crrev.com/d703a382302681ad0c8443ccb8a9bac86ea4b4c1/ui/gfx/mac/io_surface.cc
[modify] https://crrev.com/d703a382302681ad0c8443ccb8a9bac86ea4b4c1/ui/gfx/mojo/buffer_types.mojom
[modify] https://crrev.com/d703a382302681ad0c8443ccb8a9bac86ea4b4c1/ui/gfx/mojo/buffer_types_struct_traits.h
[modify] https://crrev.com/d703a382302681ad0c8443ccb8a9bac86ea4b4c1/ui/gl/gl_image_io_surface.mm
[modify] https://crrev.com/d703a382302681ad0c8443ccb8a9bac86ea4b4c1/ui/gl/gl_image_memory.cc
[modify] https://crrev.com/d703a382302681ad0c8443ccb8a9bac86ea4b4c1/ui/gl/gl_image_native_pixmap.cc
[modify] https://crrev.com/d703a382302681ad0c8443ccb8a9bac86ea4b4c1/ui/gl/gl_image_shared_memory_unittest.cc
[modify] https://crrev.com/d703a382302681ad0c8443ccb8a9bac86ea4b4c1/ui/gl/test/gl_image_test_support.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Feb 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02290321d15a90a00f942444672ac8aed31dd8bc

commit 02290321d15a90a00f942444672ac8aed31dd8bc
Author: Miguel Casas <mcasas@chromium.org>
Date: Tue Feb 20 21:35:23 2018

RELAND: GpuMemoryBuffer: add image_xb30 capability and RGBX_1010102 BufferFormat

The original CL was reverted due to two gl_unittests_ozone failures:
 EGLApiTest.DisabledExtensionBitTest
 EGLApiTest.DisabledExtensionStringTest
these two tests also fail on my soraka ToT, so I think they're just
flaky. The fix is to check for GetSurfaceFactoryOzone() before using
it in HasGLOzone():
http://crrev.com/c/926862/1..3/ui/gl/init/ozone_util.h

TBR=reveman@chromium.org, piman@chromium.org, rsesek@chromium.org, dalecurtis@chomium.org
since the code they reviewed and LGTM'd hasn't changed.

Original CL description ------------------------------------------------

This CL adds a new Gpu FeatureInfo::FeatureFlags and command buffer
Capabilities to signal support for image_xb30, in parallel to the
existing image_xr30. The new flag is used on platforms supporting
glTexImage2D() with data format GL_RGB(A), namely >=gles3, >=gl3.3
or those with the appropriate GL extension.

This CL also adds a new GpuMemoryBuffer format RGBX_1010102 to
be used where image_xb30 is signalled.

With all this, Mac will use image_xr30 <-> BGRX_1010102, and the
GLES3+/GL3.3+ platforms will use image_xb30 <-> RGBX_1010102.

Bug:  803975 , 776093, 803451,  808172 
Change-Id: I8a5a047aabf08f08f6f6fa1d27196e29ddc67120
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/920361
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#537561}
Reviewed-on: https://chromium-review.googlesource.com/926862
Cr-Commit-Position: refs/heads/master@{#537893}
[modify] https://crrev.com/02290321d15a90a00f942444672ac8aed31dd8bc/cc/resources/video_resource_updater.cc
[modify] https://crrev.com/02290321d15a90a00f942444672ac8aed31dd8bc/components/exo/buffer.cc
[modify] https://crrev.com/02290321d15a90a00f942444672ac8aed31dd8bc/content/renderer/media/gpu/gpu_video_accelerator_factories_impl.cc
[modify] https://crrev.com/02290321d15a90a00f942444672ac8aed31dd8bc/gpu/command_buffer/client/gles2_implementation.cc
[modify] https://crrev.com/02290321d15a90a00f942444672ac8aed31dd8bc/gpu/command_buffer/common/capabilities.h
[modify] https://crrev.com/02290321d15a90a00f942444672ac8aed31dd8bc/gpu/command_buffer/common/gpu_memory_buffer_support.cc
[modify] https://crrev.com/02290321d15a90a00f942444672ac8aed31dd8bc/gpu/command_buffer/service/feature_info.cc
[modify] https://crrev.com/02290321d15a90a00f942444672ac8aed31dd8bc/gpu/command_buffer/service/feature_info.h
[modify] https://crrev.com/02290321d15a90a00f942444672ac8aed31dd8bc/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/02290321d15a90a00f942444672ac8aed31dd8bc/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc
[modify] https://crrev.com/02290321d15a90a00f942444672ac8aed31dd8bc/gpu/command_buffer/service/texture_manager.cc
[modify] https://crrev.com/02290321d15a90a00f942444672ac8aed31dd8bc/gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc
[modify] https://crrev.com/02290321d15a90a00f942444672ac8aed31dd8bc/gpu/command_buffer/tests/gl_unittest.cc
[modify] https://crrev.com/02290321d15a90a00f942444672ac8aed31dd8bc/gpu/ipc/client/gpu_memory_buffer_impl_shared_memory.cc
[modify] https://crrev.com/02290321d15a90a00f942444672ac8aed31dd8bc/gpu/ipc/common/gpu_command_buffer_traits_multi.h
[modify] https://crrev.com/02290321d15a90a00f942444672ac8aed31dd8bc/gpu/ipc/host/gpu_memory_buffer_support.cc
[modify] https://crrev.com/02290321d15a90a00f942444672ac8aed31dd8bc/media/base/video_frame.cc
[modify] https://crrev.com/02290321d15a90a00f942444672ac8aed31dd8bc/media/video/gpu_memory_buffer_video_frame_pool.cc
[modify] https://crrev.com/02290321d15a90a00f942444672ac8aed31dd8bc/media/video/gpu_memory_buffer_video_frame_pool_unittest.cc
[modify] https://crrev.com/02290321d15a90a00f942444672ac8aed31dd8bc/media/video/gpu_video_accelerator_factories.h
[modify] https://crrev.com/02290321d15a90a00f942444672ac8aed31dd8bc/media/video/mock_gpu_video_accelerator_factories.cc
[modify] https://crrev.com/02290321d15a90a00f942444672ac8aed31dd8bc/ui/gfx/buffer_format_util.cc
[modify] https://crrev.com/02290321d15a90a00f942444672ac8aed31dd8bc/ui/gfx/buffer_types.h
[modify] https://crrev.com/02290321d15a90a00f942444672ac8aed31dd8bc/ui/gfx/mac/io_surface.cc
[modify] https://crrev.com/02290321d15a90a00f942444672ac8aed31dd8bc/ui/gfx/mojo/buffer_types.mojom
[modify] https://crrev.com/02290321d15a90a00f942444672ac8aed31dd8bc/ui/gfx/mojo/buffer_types_struct_traits.h
[modify] https://crrev.com/02290321d15a90a00f942444672ac8aed31dd8bc/ui/gl/gl_image_io_surface.mm
[modify] https://crrev.com/02290321d15a90a00f942444672ac8aed31dd8bc/ui/gl/gl_image_memory.cc
[modify] https://crrev.com/02290321d15a90a00f942444672ac8aed31dd8bc/ui/gl/gl_image_native_pixmap.cc
[modify] https://crrev.com/02290321d15a90a00f942444672ac8aed31dd8bc/ui/gl/gl_image_shared_memory_unittest.cc
[modify] https://crrev.com/02290321d15a90a00f942444672ac8aed31dd8bc/ui/gl/init/ozone_util.h
[modify] https://crrev.com/02290321d15a90a00f942444672ac8aed31dd8bc/ui/gl/test/gl_image_test_support.cc

Comment 4 by danakj@chromium.org, Today (18 hours ago)

Hello, I came across the RenderThreadImpl::SetRenderingColorSpace() today and wanted to point out somewhere some problems with the current code.

Because it is on RenderThreadImpl, this means it is global for an entire renderer process. A renderer process is shared for each page within a given site (and possibly between sites), which means multiple top level browser windows can share a renderer process.

So this property can not be correct for each output if there is a window on each monitor with a different color space. It will only be correct for one.

Secondly, it's being set by visual properties passed to RenderWidget. Since each page will have (at least 1) RenderWidget in the process, these RenderWidgets will clobber each other setting the color space on RenderThreadImpl. The most recent RenderWidget will win for any given time.

And so third, the GpuVideoAcceleratorFactoriesImpl::VideoFrameOutputFormat() is at the wrong level of abstraction - the factory is global for the process - or at least requires some parameter to distinguish which monitor's color space it intends - the RenderWidget, the Page, something.

I will leave a TODO in RenderWidget pointing back to here. I found this bug from a TODO for completing this work for Windows. This will certainly come up there as multi monitor configurations are common, and frequently the primary one has much higher specs (eg is HDR or higher frequency).

Comment 5 by piman@chromium.org, Today (18 hours ago)

FYI, I raised these points during review, see various comments on the CL https://chromium-review.googlesource.com/c/chromium/src/+/852912 which gives context as to why the usage is probably ok, albeit subtle and confusing.

Given the usage pattern it should probably flow some other way to make it less confusing.

Comment 6 by danakj@chromium.org, Today (18 hours ago)

Ok it seems that
a) This only works on windows
b) The HDR bit is a global in the browser on windows, unclear about the rest of the color space
c) If other parts aren't globally identical then the value seen in the renderer will be arbitrary at any given point in time as different monitors' values clobber each other in RenderThreadImpl.
d) This is all going through per-widget/compositor channels but at the very end jumping out to a global and this seems very wrong.

I would suggest perhaps using renderer.mojom to set a global HDR-exists-anywhere bool to be more clear and drop the color space from visual properties.

Comment 7 by mcasas@chromium.org, Today (17 hours ago)

#4: AFAIK only Windows supports HDR mode, and it needs the user to actively
turn it on via some non-intuitive OS Settings operations. The transition takes
a few seconds, and the whole screen changes (ccameron@ has one such set up).
After this point, all rendering is in HDR (wide luminance, Half float),
meaning that non-HDR colors look faded, including Chrome UI. I'm not sure 
how, if at all, Windows will deal with several monitors connected, where only
one is HDR-capable (clues are left in [0]). ToT code has a specific code path 
starting in [1, 2] (BrowserMainLoop in there, glups!) so that ScreenWin can
get to know the HDR status.

Hence, to clarify: HDR on Chrome is only supported on Windows, and globally
(per browser).  Why that flag? When it's enabled, the Video playback uses a 
HalfFloat update path [3].

crrev.com/c/852912, surfaced this situation, but was just a wiring of the 
parameters to enable crrev.com/c/843132, where I disabled using the Half
Float update path if HDR was not available, instead dropping the bitdepth.

[0] https://cs.chromium.org/chromium/src/ui/display/win/screen_win.h?type=cs&q=SetRequestHDRStatus&g=0&l=135
[1] https://cs.chromium.org/chromium/src/components/viz/service/gl/gpu_service_impl.cc?type=cs&q=DirectCompositionSurfaceWin::IsHDRSupported&g=0&l=536
[2] https://cs.chromium.org/chromium/src/content/browser/browser_main_loop.cc?type=cs&q=RequestHDRStatus&g=0&l=476
[3] https://cs.chromium.org/chromium/src/media/renderers/video_resource_updater.cc?type=cs&q=halffloat+maker&g=0&l=1000

Comment 8 by danakj@chromium.org, Today (17 hours ago)

I believe a per-browser and per-renderer plumbing+IPC path, of only that specific bool, would be orders of magnitude more clear on intention and forward-looking correctness. IOW to not involve RenderWidgetHost, RenderViewHost, RenderWidget, etc at all.

Sign in to add a comment