New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 803449 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 27
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

breakpoints-ui-restored-breakpoint.js is flaky or broken

Project Member Reported by smcgruer@chromium.org, Jan 18 2018

Issue description

This test is failing regularly on Win 7 (dgb), WebKit Mac10.11 (dgb), and WebKit Linux Trusty (dbg). Example links:

Win 7 Tests (dbg): https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%28dbg%29%281%29/65853

WebKit Mac10.11 (dbg): https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.11%20%28dbg%29/12151

WebKit Linux Trusty (dbg): https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20%28dbg%29/8882

As I am unable to revert due to subsequent dependent patches, I will be disabling the test.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/352282bbe0f37815d61044a6f286c8bee35d897a

commit 352282bbe0f37815d61044a6f286c8bee35d897a
Author: Stephen McGruer <smcgruer@chromium.org>
Date: Thu Jan 18 16:11:21 2018

Mark breakpoints-ui-restored-breakpoint.js as flaky

This test is failing with high occurence on Windows, Mac, and Linux
debug bots.

Bug:  803449 
Change-Id: I0c2319823d4bf6f5eaee1e45ff84e963ba24d08d

TBR=kozyatinskiy@chromium.org,lushnikov@chromium.org

Change-Id: I0c2319823d4bf6f5eaee1e45ff84e963ba24d08d
Reviewed-on: https://chromium-review.googlesource.com/873731
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530156}
[modify] https://crrev.com/352282bbe0f37815d61044a6f286c8bee35d897a/third_party/WebKit/LayoutTests/TestExpectations

Cc: lushnikov@chromium.org
Owner: kozyatinskiy@chromium.org
Status: Assigned (was: Started)

Comment 4 by kozy@chromium.org, Jan 19 2018

Status: Fixed (was: Assigned)

Comment 5 by mastiz@chromium.org, Jan 19 2018

Cc: mastiz@chromium.org
 Issue 803800  has been merged into this issue.

Comment 6 by mastiz@chromium.org, Jan 19 2018

Status: Assigned (was: Fixed)
This issue seems to persist, reopening and marking tests flaky again. Sample builds that already include the patch above:
Win7 Tests (dbg): https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%28dbg%29%281%29/65879
WebKit Linux Trusty (dbg): https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20%28dbg%29/8918
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9b9fb2b4bd7fef57a1f586e21a10717895f1a36

commit f9b9fb2b4bd7fef57a1f586e21a10717895f1a36
Author: Mikel Astiz <mastiz@chromium.org>
Date: Fri Jan 19 11:27:33 2018

Mark breakpoints-ui-restored-breakpoint.js as flaky

This test is failing with high occurence on Windows, Mac, and Linux
debug bots.

This is a reland of 352282b.

Bug:  803449 
Change-Id: Ide953195f2ae32af5ed6c5744ed2e9c8011dd4cc

TBR=kozyatinskiy@chromium.org,lushnikov@chromium.org

Change-Id: Ide953195f2ae32af5ed6c5744ed2e9c8011dd4cc
Reviewed-on: https://chromium-review.googlesource.com/875982
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530483}
[modify] https://crrev.com/f9b9fb2b4bd7fef57a1f586e21a10717895f1a36/third_party/WebKit/LayoutTests/TestExpectations

Comment 8 by mastiz@chromium.org, Jan 22 2018

breakpoints-ui-navigation.js is also failing on Mac, see https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/12234

I assume it's the same underlying issue so extending the scope of this bug.

Comment 9 by kozy@chromium.org, Feb 17 2018

Owner: kozy@chromium.org
Status: Fixed (was: Assigned)
looks fixed, at least there is no new flakes according try-flakes [1].

[1] https://chromium-try-flakes.appspot.com/search?q=http%2Ftests%2Fdevtools%2Fsources%2Fdebugger-breakpoints%2Fbreakpoints-ui-restored-breakpoint.js

Sign in to add a comment