New issue
Advanced search Search tips

Issue 803434 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 776589



Sign in to add a comment

Browser tests shouldn't use URLRequestFailedJobs::GetMockHttpUrl

Project Member Reported by clamy@chromium.org, Jan 18 2018

Issue description

Several browser tests use URLRequestFailedJobs::GetMockHttpUrl to simulate network failures. This function is no longer supported when the network service is enabled.
 

Comment 1 by clamy@chromium.org, Jan 18 2018

Cc: clamy@chromium.org
Components: Test
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f77e9ff732b7300c1e1e85349cef383c048ff810

commit f77e9ff732b7300c1e1e85349cef383c048ff810
Author: clamy <clamy@chromium.org>
Date: Thu Jan 18 15:53:43 2018

Remove usage of URLRequestFailedJobs::GetMockHttpUrl in content/

This CL removes usage of URLRequestFailedJobs::GetMockHttpUrl in
content. This function was used to simulate a connection error in some
navigation browser tests, but it is not supported by the network
service. Instead we use the "/close-socket" handler of the
EmbeddedTestServer which will result in a connection closure when the
URL is requested.

BUG=803434

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I7e5c8612b3c8cb886b89519e8c544428fa222c20
Reviewed-on: https://chromium-review.googlesource.com/873639
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530148}
[modify] https://crrev.com/f77e9ff732b7300c1e1e85349cef383c048ff810/content/browser/browser_side_navigation_browsertest.cc
[modify] https://crrev.com/f77e9ff732b7300c1e1e85349cef383c048ff810/content/browser/frame_host/navigation_controller_impl_browsertest.cc
[modify] https://crrev.com/f77e9ff732b7300c1e1e85349cef383c048ff810/content/browser/frame_host/navigation_handle_impl_browsertest.cc
[modify] https://crrev.com/f77e9ff732b7300c1e1e85349cef383c048ff810/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter

Comment 3 by jam@chromium.org, Jan 18 2018

Blocking: 776589

Sign in to add a comment