New issue
Advanced search Search tips

Issue 803428 link

Starred by 2 users
Status: Fixed
Owner:
vasi...@chromium.org
Closed: Jan 2018
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

"Never save password" should blacklist the whole site

Project Member Reported by vasi...@chromium.org, Jan 18 2018 
Chrome Version: 65
OS: all

When a user clicks "Never" in the "Save password?" dialog then Chrome shouldn't pop up the bubble on this site automatically. Currently we try to blacklist one particular form. It sometimes doesn't work because the path and elements of the form can be different next time.
As of today the users click "Never" in 29.5% cases which seems too high.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/448ec53e7d17989ea8eebe00b34ddeb27b6ea3ae

commit 448ec53e7d17989ea8eebe00b34ddeb27b6ea3ae
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Thu Jan 18 17:27:46 2018

"Never save password" should blacklist the whole site.

Previously we used the path and element names of the form.
It seems flaky. It can happen that 'Never' doesn't work on the same sign-in page.

Bug:  803428 
Change-Id: Ife1d924ef34ef5a7c5f5133547c65ba45407d7a2
Reviewed-on: https://chromium-review.googlesource.com/873635
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530181}
[modify] https://crrev.com/448ec53e7d17989ea8eebe00b34ddeb27b6ea3ae/components/password_manager/core/browser/password_form_manager.cc
[modify] https://crrev.com/448ec53e7d17989ea8eebe00b34ddeb27b6ea3ae/components/password_manager/core/browser/password_form_manager.h
[modify] https://crrev.com/448ec53e7d17989ea8eebe00b34ddeb27b6ea3ae/components/password_manager/core/browser/password_form_manager_unittest.cc

Comment 2 by vasi...@chromium.org, Jan 18 2018

Status: Fixed (was: Started)

Comment 3 by battre@chromium.org, Feb 6 2018 

 Issue 809235  has been merged into this issue.
►

Sign in to add a comment