New issue
Advanced search Search tips

Issue 803427 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Security


Participants' hotlists:
Hotlist-OffHeapWasm


Sign in to add a comment

DCHECK failure in (native_module_->lazy_builtin_) == nullptr in wasm-serialization.cc

Project Member Reported by ClusterFuzz, Jan 18 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4655273041199104

Fuzzer: ochang_js_fuzzer
Job Type: linux_asan_d8_dbg
Platform Id: linux

Crash Type: DCHECK failure
Crash Address: 
Crash State:
  (native_module_->lazy_builtin_) == nullptr in wasm-serialization.cc
  v8::internal::wasm::NativeModuleSerializer::NativeModuleSerializer
  v8::internal::wasm::SerializeNativeModule
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_d8_dbg&range=49947:49948

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4655273041199104

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jan 18 2018

Components: Blink>JavaScript>WebAssembly
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Jan 18 2018

Labels: Test-Predator-Auto-Owner
Owner: mtrofin@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/v8/v8/+/f2e19a63873a700e6c0a1bca35e8301bd50db4e1 ([wasm] Add --wasm-jit-to-native under --future).

If this is incorrect, please remove the owner and apply the Test-Predator-Wrong-CLs label.
Project Member

Comment 3 by sheriffbot@chromium.org, Jan 18 2018

Labels: Pri-1
Owner: mstarzinger@chromium.org
Labels: Security_Impact-Head M-65
Project Member

Comment 6 by sheriffbot@chromium.org, Jan 21 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Needs --wasm-lazy-compilation to reproduce, which is not on by default.
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/e11c57fe9e7b7db6a9bd707642ea1cdfa92102f5

commit e11c57fe9e7b7db6a9bd707642ea1cdfa92102f5
Author: Michael Starzinger <mstarzinger@chromium.org>
Date: Mon Jan 22 17:27:15 2018

[wasm] Remove {NativeModule::lazy_builtin} field.

This removes the field in question to make it simpler to serialize and
deserialize modules without having to worry about the state of lazy
compilation. It is always possible to clone a non-anonymous builtin,
even without having this module-wide field.

R=clemensh@chromium.org
TEST=mjsunit/regress/wasm/regress-803427
BUG= chromium:803427 

Change-Id: I72041e314eb6ee92859d45f1db0ed8500003edc4
Reviewed-on: https://chromium-review.googlesource.com/878581
Commit-Queue: Michael Starzinger <mstarzinger@chromium.org>
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#50771}
[modify] https://crrev.com/e11c57fe9e7b7db6a9bd707642ea1cdfa92102f5/src/wasm/module-compiler.cc
[modify] https://crrev.com/e11c57fe9e7b7db6a9bd707642ea1cdfa92102f5/src/wasm/wasm-code-manager.cc
[modify] https://crrev.com/e11c57fe9e7b7db6a9bd707642ea1cdfa92102f5/src/wasm/wasm-code-manager.h
[modify] https://crrev.com/e11c57fe9e7b7db6a9bd707642ea1cdfa92102f5/src/wasm/wasm-serialization.cc
[add] https://crrev.com/e11c57fe9e7b7db6a9bd707642ea1cdfa92102f5/test/mjsunit/regress/wasm/regress-803427.js

Status: Fixed (was: Assigned)
Project Member

Comment 10 by ClusterFuzz, Jan 23 2018

ClusterFuzz has detected this issue as fixed in range 50770:50771.

Detailed report: https://clusterfuzz.com/testcase?key=4655273041199104

Fuzzer: ochang_js_fuzzer
Job Type: linux_asan_d8_dbg
Platform Id: linux

Crash Type: DCHECK failure
Crash Address: 
Crash State:
  (native_module_->lazy_builtin_) == nullptr in wasm-serialization.cc
  v8::internal::wasm::NativeModuleSerializer::NativeModuleSerializer
  v8::internal::wasm::SerializeNativeModule
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_d8_dbg&range=49947:49948
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_d8_dbg&range=50770:50771

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4655273041199104

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 11 by ClusterFuzz, Jan 23 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 4655273041199104 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 12 by sheriffbot@chromium.org, Feb 8 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -ReleaseBlock-Stable -M-65 M-66
Project Member

Comment 14 by sheriffbot@chromium.org, Mar 27 2018

Labels: -Security_Impact-Head Security_Impact-Beta
Project Member

Comment 15 by sheriffbot@chromium.org, Apr 27 2018

Labels: Merge-Request-67
Project Member

Comment 16 by sheriffbot@chromium.org, Apr 27 2018

Labels: -Merge-Request-67 Merge-Review-67 Hotlist-Merge-Review
This bug requires manual review: M67 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: awhalley@chromium.org
+awhalley@ for M67 merge review. 
Labels: -Hotlist-Merge-Review -Merge-Review-67 OS-Windows
No merge needed.
Project Member

Comment 19 by sheriffbot@chromium.org, May 1 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment