New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 803425 link

Starred by 1 user
Status: Verified
Owner:
gambard@chromium.org
Closed: Jan 2018
Cc:
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Tapping the fakebox doesn't work after a back

Project Member Reported by gambard@chromium.org, Jan 18 2018 
Chrome Version: M65

What steps will reproduce the problem?
(1) Open a new tab
(2) Navigate to a page
(3) Go back to the NTP
(4) Tap the fake omnibox

What is the expected result?
The FakeOmnibox should move up and be focused

What happens instead?
The fakebox doesn't move and the omnibox doesn't appear (can see what is typing).
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b13d1ed121278f38691aa95ccfc62b6eb8271ee1

commit b13d1ed121278f38691aa95ccfc62b6eb8271ee1
Author: Gauthier Ambard <gambard@chromium.org>
Date: Thu Jan 18 14:27:16 2018

Notifies the NTP that it is being shown

This CL adds a notification to the NTP ViewController that it is being
shown.
Without this notification, the fakebox doesn't work.

It also fixes the shadow of the bottom toolbar view by inserting the
view below it.

Bug:  803425 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I9ff6cb9f111e42eb305f4f5042af86269557f115
Reviewed-on: https://chromium-review.googlesource.com/873641
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Louis Romero <lpromero@chromium.org>
Reviewed-by: Louis Romero <lpromero@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530137}
[modify] https://crrev.com/b13d1ed121278f38691aa95ccfc62b6eb8271ee1/ios/chrome/browser/ui/ntp/new_tab_page_controller.mm

Comment 2 by gambard@chromium.org, Jan 18 2018

Status: Fixed (was: Assigned)
Please, make sure to verify this on M65 as we are close to branch point.

Comment 3 by vbhatso...@chromium.org, Jan 23 2018

Status: Verified (was: Fixed)
Verified in 66.0.3329.0 canary on iPad Pro 12'5 iOS 10.3.3, 11.2.5, iPhone X iOS 11.2
►

Sign in to add a comment