Issue metadata
Sign in to add a comment
|
Regression: [Mac] Password bubble get dismissed after entering the password in OS re-authentication password prompt.
Reported by
dchau...@etouch.net,
Jan 18 2018
|
||||||||||||||||||||||
Issue descriptionChrome Version: 65.0.3324.0 (Official Build)Revision 07b221a26af55a4c3e7e375c629eb8474247f691-refs/heads/master@{#530027} (32/64-bit). OS: Mac(10.12.6, 10.13.1, 10.13.3). What steps will reproduce the problem? 1. Launch Chrome, sign-in to www.gmail.com with valid credentials and click anywhere on page to dismiss the password bubble. 2. Click on key icon in omnibox to open password bubble and then click on eye icon (OS re-auth password prompt will appear). 3. Enter valid password in password text-box and and observe. Actual: Password bubble get dismissed after entering the password in OS re-authentication password prompt. Expected: Password bubble should stay visible and decrypted password should be shown after entering the password in OS re-auth password prompt. NOTE: In Windows OS, Password bubble appears with decrypted password as soon as user submits the OS password in re-authentication password prompt. This is a Mac OS specific regression issue, broken in M-65 series, below is manual regression range. Good Build: 65.0.3316.0 (Revision 527862) Bad Build: 65.0.3317.0 (Revision 528119) Using the per-revision bisect providing the bisect results: You are probably looking for a change made after 527981 (known good), but no later than 527982 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/d1603bb87f33912dc07c564d5ae2eb3d8ca7bd74..77e711eb50d673ad4060e36570d81085511b2656 Suspecting: https://chromium.googlesource.com/chromium/src/+/77e711eb50d673ad4060e36570d81085511b2656 @kolos: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. NOTE: 1. This issue is also reproducible on Dev M-65 build # 65.0.3322.3 2. Issue not seen on Windows(7,8,8.1,10) and Linux(14.04 LTS) OS. Kindly review the attached screen-cast for reference. Thank you.
,
Jan 18 2018
Vasilii: could you pleas take a look? Looks like bubble re-opening doesn't work on Mac.
,
Jan 18 2018
,
Jan 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/85b9d0662601895ecb6b25977ce3117725d0d525 commit 85b9d0662601895ecb6b25977ce3117725d0d525 Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Mon Jan 22 16:07:09 2018 On Mac open the password bubble even if the current one is being destroyed. It can happen when OS reauth is required. Sequence of events: - user clicks the eye icon. - the reuth dialog pops up blocking the message loop for Chrome. - the user types something so the bubble looses focus. Thus, the bubble is to be closed. - the reauth dialog is closed. - Chrome schedules an event to pop up the bubble again. - The old bubble gets a message about focus lost and starts closing (1). - Chrome wants to reopen the bubble. (2) - The old bubble is finally closed (i.e. destructed). Before the CL (2) was blocked because the bubble is still alive. As a side effect we have to reset the bubble model earlier so that the metrics recorder feels good. Otherwise, it can't understand how the second bubble opens before one is still alive. Bug: 803411 Change-Id: I0f2574bde52b832492d44aec8efc9353db4c5881 Reviewed-on: https://chromium-review.googlesource.com/876008 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Dominic Battré <battre@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#530874} [modify] https://crrev.com/85b9d0662601895ecb6b25977ce3117725d0d525/chrome/browser/ui/cocoa/tab_dialogs_views_mac.mm [modify] https://crrev.com/85b9d0662601895ecb6b25977ce3117725d0d525/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc [modify] https://crrev.com/85b9d0662601895ecb6b25977ce3117725d0d525/chrome/browser/ui/passwords/manage_passwords_bubble_model.h [modify] https://crrev.com/85b9d0662601895ecb6b25977ce3117725d0d525/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc [modify] https://crrev.com/85b9d0662601895ecb6b25977ce3117725d0d525/chrome/browser/ui/views/passwords/manage_passwords_bubble_delegate_view_base.cc [modify] https://crrev.com/85b9d0662601895ecb6b25977ce3117725d0d525/chrome/browser/ui/views/passwords/manage_passwords_bubble_delegate_view_base.h
,
Jan 24 2018
I want to merge r530874 back. The fix is vital from the privacy point of view.
,
Jan 25 2018
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d30026b57eb051b41848a4c598558bda3e336b18 commit d30026b57eb051b41848a4c598558bda3e336b18 Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Thu Jan 25 11:00:51 2018 On Mac open the password bubble even if the current one is being destroyed. It can happen when OS reauth is required. Sequence of events: - user clicks the eye icon. - the reuth dialog pops up blocking the message loop for Chrome. - the user types something so the bubble looses focus. Thus, the bubble is to be closed. - the reauth dialog is closed. - Chrome schedules an event to pop up the bubble again. - The old bubble gets a message about focus lost and starts closing (1). - Chrome wants to reopen the bubble. (2) - The old bubble is finally closed (i.e. destructed). Before the CL (2) was blocked because the bubble is still alive. As a side effect we have to reset the bubble model earlier so that the metrics recorder feels good. Otherwise, it can't understand how the second bubble opens before one is still alive. TBR=vasilii@chromium.org (cherry picked from commit 85b9d0662601895ecb6b25977ce3117725d0d525) Bug: 803411 Change-Id: I0f2574bde52b832492d44aec8efc9353db4c5881 Reviewed-on: https://chromium-review.googlesource.com/876008 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Dominic Battré <battre@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#530874} Reviewed-on: https://chromium-review.googlesource.com/886347 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#89} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/d30026b57eb051b41848a4c598558bda3e336b18/chrome/browser/ui/cocoa/tab_dialogs_views_mac.mm [modify] https://crrev.com/d30026b57eb051b41848a4c598558bda3e336b18/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc [modify] https://crrev.com/d30026b57eb051b41848a4c598558bda3e336b18/chrome/browser/ui/passwords/manage_passwords_bubble_model.h [modify] https://crrev.com/d30026b57eb051b41848a4c598558bda3e336b18/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc [modify] https://crrev.com/d30026b57eb051b41848a4c598558bda3e336b18/chrome/browser/ui/views/passwords/manage_passwords_bubble_delegate_view_base.cc [modify] https://crrev.com/d30026b57eb051b41848a4c598558bda3e336b18/chrome/browser/ui/views/passwords/manage_passwords_bubble_delegate_view_base.h
,
Jan 25 2018
,
Feb 2 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rbasuvula@chromium.org
, Jan 18 2018