New issue
Advanced search Search tips

Issue 803408 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 803360
Owner: ----
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

[WPT] New failures introduced in external/wpt/svg by import https://crrev.com/c/872573

Project Member Reported by monorail...@ecosystem-infra.iam.gserviceaccount.com, Jan 18 2018

Issue description

WPT import https://crrev.com/c/872573 introduced new failures in external/wpt/svg:

List of new failures:
external/wpt/svg/path/closepath/segment-completing.svg [ Failure ]

This import contains upstream changes from e856c3db7b9217b6b2736e802ae530e5a590e459 to 0343d0df4840a9831b1f5603da88ab0cbedcb1cd:
[css-typed-om] Clean up CSSUnparsedValue serialization test: https://github.com/w3c/web-platform-tests/commit/0343d0df4840a9831b1f5603da88ab0cbedcb1cd
Merge pull request #9071 from mrego/fix-grid-alignment-implies-size-change-tests: https://github.com/w3c/web-platform-tests/commit/70d0ebb9acc29d2b86c57443da2347dec9765de2
[css-typed-om] Upstream CSSPositionValue serialization to WPT.: https://github.com/w3c/web-platform-tests/commit/40f4239eefaf0b86748b6d69a9abf9e1c30ae5b8
[css-typed-om] Upstream style property map tests as tentative: https://github.com/w3c/web-platform-tests/commit/6c7a03edbc7411f803e141ec5618b35a034ec386
[css-layout-api] Adds LayoutWorkletGlobalScope and proxy.: https://github.com/w3c/web-platform-tests/commit/ff621971b206b79179bead55c3469ce7d311f4a4
[css-typed-om] Upstream serialization & normalization tests as tentative: https://github.com/w3c/web-platform-tests/commit/0e5303d5d760122ae260ddd20c3736b7a5439862
Merge pull request #6769 from Honry/sensor/linearaccelerationsensor: https://github.com/w3c/web-platform-tests/commit/6b99066f88c07e2317b21f86753f93011c794a5b
Merge pull request #7431 from Honry/sensor/more-layout-tests: https://github.com/w3c/web-platform-tests/commit/aeebec884e015ca95ae18e410ce0a4c657cccb9a
Recurse to nested arrays in reading arrays (#8797): https://github.com/w3c/web-platform-tests/commit/1f28397aa8a74745943563c6428976b353af9e56
Sensor FP tests need title (#8965): https://github.com/w3c/web-platform-tests/commit/54307bd7a48ab320d4eef306f207ba7f9ff4159d
Merge pull request #8719 from ewilligers/path-error-handling: https://github.com/w3c/web-platform-tests/commit/bf0f93a8376ea2a8b0a35bf8029b3c5090981611
Merge pull request #8720 from ewilligers/closepath-completes-segment: https://github.com/w3c/web-platform-tests/commit/c6beb7750806408a0d3a0e29c94dd6716a60cf0d
Merge pull request #8990 from ewilligers/masking: https://github.com/w3c/web-platform-tests/commit/33e0b541792abbc7ce7b175cde82a2fac9c923c0
Test that invalid paths do not render: https://github.com/w3c/web-platform-tests/commit/9cde3feb9cb02afeacf31203beff8104af33c7fa [affecting this directory]
[css-grid] Fix grid-alignment-implies-size-change tests: https://github.com/w3c/web-platform-tests/commit/235abce9391caa1a8362c9d3cd7c43c30c9d171d
test_valid_value is single test: https://github.com/w3c/web-platform-tests/commit/e67d9cc7dcfd244a3e4e144ad54e462d66ffdaaa
omit path() test: https://github.com/w3c/web-platform-tests/commit/2a5c9bfb831de0503f0dca799fca67f8b1783749
Parsing tests for clip, clip-path, clip-rule: https://github.com/w3c/web-platform-tests/commit/bb499916167dfc929423071f74f3ee3aa026e3d3
Add one more test and use async/await: https://github.com/w3c/web-platform-tests/commit/f20260a61cc96b734dee89f293549aa37ded62bd
Generic Sensor: import tests from Chromium Layout test suite: https://github.com/w3c/web-platform-tests/commit/e47f2dbc8ff24322bdcef2423cb85f9e123f2976
SVG: closepath completes command by initial point: https://github.com/w3c/web-platform-tests/commit/71b0d4129db9cf569a924604905b93505490b689 [affecting this directory]
Pass string param to runGenericSensorInsecureContext: https://github.com/w3c/web-platform-tests/commit/44206bef182ea0e8606e4444dad059305e7bfe6e
Add functional tests for LinearAccelerationSensor: https://github.com/w3c/web-platform-tests/commit/89d14a6ef6faeff6ae1406ad03390426b1538ebd

 

Comment 1 by f...@opera.com, Jan 18 2018

Mergedinto: 803360
Status: Duplicate (was: Untriaged)
Overlapping import ranges.
Thanks for deduping. The overlapping imports were the consequence of a chain of coincidences:

1. The first import passed CQ but could not be merged because tree was red.
2. The importer timed out and started the next import.
3. While the second import was being processed, the tree turned green and the first import landed.
4. The second import was automatically rebased. The final results of both imports were hence correct, but the importer was confused about the import range.

Ideally, the importer should close the CL after timeout (2), i.e. issue 753769.

Sign in to add a comment