New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 803406 link

Starred by 1 user
Status: Fixed
Owner:
█ osc...@opera.com
Last visit > 30 days ago
Closed: Jul 27
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 746956



Sign in to add a comment

Support jumbo in chrome/browser/ui

Project Member Reported by brat...@opera.com, Jan 18 2018 
When building chrome, chrome/browser/ui:ui is one of the build targets that need the most time to compile. In my test configuration it needs 78 CPU minutes to compile out of the ~800 CPU minutes currently needed to compile chrome+content_shell+blink_tests with use_jumbo_build=true.

It looks like there is a fair amount of similarly named constants and functions that need to be handled so it's a big fruit but not a low hanging fruit.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7c53b76aff4c25573def0d49cc43030aaa00934

commit b7c53b76aff4c25573def0d49cc43030aaa00934
Author: Daniel Bratell <bratell@opera.com>
Date: Thu Jan 18 18:50:25 2018

Avoid "using base::Time;" because of X11 Time typedef

if any X11 header has been included, there is an unavoidable
Time typedef in global scope. When there is also a
"using base::Time;" both end up in the global scope which
cause compilation issues. Specifically this happened in
jumbo build experiments.

Bug:  803406 
Change-Id: Ib7cd99b98552a209d1432ecb4ee060d16c9da39f
Reviewed-on: https://chromium-review.googlesource.com/873976
Commit-Queue: Daniel Bratell <bratell@opera.com>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530215}
[modify] https://crrev.com/b7c53b76aff4c25573def0d49cc43030aaa00934/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
[modify] https://crrev.com/b7c53b76aff4c25573def0d49cc43030aaa00934/chrome/browser/ui/views/bookmarks/bookmark_editor_view_unittest.cc
[modify] https://crrev.com/b7c53b76aff4c25573def0d49cc43030aaa00934/chrome/browser/ui/webui/about_ui.cc

Comment 2 by dtapu...@chromium.org, Jan 30 2018

Components: Build
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26b852aa903f2c6b67e76ef8deb282e05d461b9a

commit 26b852aa903f2c6b67e76ef8deb282e05d461b9a
Author: Daniel Bratell <bratell@opera.com>
Date: Sat Mar 17 11:54:18 2018

Give two kTextContext unique names for jumbo builds

There are two different kTextContexts in chrome/browser/ui, living
in different namespaces that in jumbo builds become the same
namespace. This patch renames them so that they have
unique names.

This affects Opera builds but not Chrome builds yet since jumbo
is not yet supported in chrome/browser/ui in Chrome.

Bug:  803406 
Change-Id: I3354881b9dedae9499356800cbaed4de3cc0da4c
Reviewed-on: https://chromium-review.googlesource.com/966202
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#543938}
[modify] https://crrev.com/26b852aa903f2c6b67e76ef8deb282e05d461b9a/chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc
[modify] https://crrev.com/26b852aa903f2c6b67e76ef8deb282e05d461b9a/chrome/browser/ui/views/page_info/permission_selector_row.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/388bce8694b70088490b926d623f7c188e03ee77

commit 388bce8694b70088490b926d623f7c188e03ee77
Author: Daniel Bratell <bratell@opera.com>
Date: Sat Mar 17 12:35:18 2018

Manually inline the IsTouchOptimized method to avoid jumbo clashes

There is a common helper method IsTouchOptimized() that is a shortening
of ui::MaterialDesignController::IsTouchOptimizedUiEnabled(). That
helper method is placed in anonymous namespaces which are merged in
jumbo builds, causing clashes.

Alternatives are to find a shared location for this method (maybe in
//ui?) or inline it. This patch inlines it.

Bug:  803406 
Change-Id: Ia389432bfdb506d27b625c916a9baf73b7b70f30
Reviewed-on: https://chromium-review.googlesource.com/966204
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#543939}
[modify] https://crrev.com/388bce8694b70088490b926d623f7c188e03ee77/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
[modify] https://crrev.com/388bce8694b70088490b926d623f7c188e03ee77/chrome/browser/ui/views/tabs/new_tab_button.cc
[modify] https://crrev.com/388bce8694b70088490b926d623f7c188e03ee77/chrome/browser/ui/views/toolbar/app_menu_button.cc
[modify] https://crrev.com/388bce8694b70088490b926d623f7c188e03ee77/chrome/browser/ui/views/toolbar/reload_button.cc
[modify] https://crrev.com/388bce8694b70088490b926d623f7c188e03ee77/chrome/browser/ui/views/toolbar/toolbar_button.cc
[modify] https://crrev.com/388bce8694b70088490b926d623f7c188e03ee77/chrome/browser/ui/views/toolbar/toolbar_view.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1cc3eead423415528255a051c74998c91c99eed4

commit 1cc3eead423415528255a051c74998c91c99eed4
Author: Daniel Bratell <bratell@opera.com>
Date: Tue Mar 27 20:32:01 2018

Gave two kBubbleReshowsHistogramName unique names

In jumbo builds many cc files are compiled together in the same
translation unit. When that happens, those files will share the
same anonymous namespace so if they use symbols of the same name
they will clash.

That happened with two kBubbleReshowsHistogramName constants in
chrome/browser/ui/exclusive_access and this patch gives
those two more unique names.

Bug:  803406 
Change-Id: I2b8e3a060c7b7853a3a001317e80d32b7d6e56d4
Reviewed-on: https://chromium-review.googlesource.com/980879
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546239}
[modify] https://crrev.com/1cc3eead423415528255a051c74998c91c99eed4/chrome/browser/ui/exclusive_access/fullscreen_controller.cc
[modify] https://crrev.com/1cc3eead423415528255a051c74998c91c99eed4/chrome/browser/ui/exclusive_access/mouse_lock_controller.cc
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f8465d29513a440c6d136ca1a11abfe44d47790

commit 3f8465d29513a440c6d136ca1a11abfe44d47790
Author: Daniel Bratell <bratell@opera.com>
Date: Wed Mar 28 09:31:59 2018

Gave some global variables a g_ prefix to avoid collisions

In jumbo builds many cc files are compiled in the same translation
unit to make the compilation (much) faster. This also joins those
files' anonymous namespace and caused clashes if several files
use symbols with the same name. That happened with two global
"instance_" variables.

This patch renames them g_descriptive_name which matches a common
pattern for naming global variables.

Bug:  803406 
Change-Id: I13e84ba5dba717d978ff2a43470e1ca4ab0457b2
Reviewed-on: https://chromium-review.googlesource.com/980880
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#546444}
[modify] https://crrev.com/3f8465d29513a440c6d136ca1a11abfe44d47790/chrome/browser/ui/views/profiles/user_manager_view.cc
[modify] https://crrev.com/3f8465d29513a440c6d136ca1a11abfe44d47790/chrome/browser/ui/views/tabs/tab_drag_controller.cc
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 6 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd626f58e644100d976bf91b8b40cd73fe95433c

commit dd626f58e644100d976bf91b8b40cd73fe95433c
Author: Daniel Bratell <bratell@opera.com>
Date: Fri Apr 06 08:35:40 2018

Inlined two GetProfileFromWebContents helpers

In jumbo build experiments (no jumbo for chromium/browser/ui yet)
two GetProfileFromWebContents ended up in the same translation unit.
Each of them was only used once. This inlines them both.

I dropped the null check from the GetProfileFromWebContents() in
account_chooser_dialog_view.cc because if that helper returned
null, then the code would already crash inside
GetDefaultStoragePartition() (GetStoragePartitionFromConfig()
will call browser_context->IsOffTheRecord() without any null check).

Bug:  803406 
Change-Id: I0200eb42c0a54b674eaec6122e1193c931dd2344
Reviewed-on: https://chromium-review.googlesource.com/997793
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#548711}
[modify] https://crrev.com/dd626f58e644100d976bf91b8b40cd73fe95433c/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
[modify] https://crrev.com/dd626f58e644100d976bf91b8b40cd73fe95433c/chrome/browser/ui/views/passwords/account_chooser_dialog_view.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 6 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24572e5103be52d720f4eaee4a1659060f7fc366

commit 24572e5103be52d720f4eaee4a1659060f7fc366
Author: Daniel Bratell <bratell@opera.com>
Date: Fri Apr 06 08:37:10 2018

Rename a function whose name conflicted in jumbo builds

In jumbo build experiments the presence of two different
OnCheckIsDefaultBrowserFinished functions meant that
Bind didn't know which one to bind and it didn't compile.

This patch renames one OnCheckIsDefaultBrowserFinished to
OpenURLAfterCheckIsDefaultBrowser which seems like a good
name for that function.

Bug:  803406 
Change-Id: I056e613b7e3d55c0b2dbde68db8d75d3e2c55876
Reviewed-on: https://chromium-review.googlesource.com/998152
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#548712}
[modify] https://crrev.com/24572e5103be52d720f4eaee4a1659060f7fc366/chrome/browser/ui/apps/chrome_app_delegate.cc
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 6 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de32246846bc49b47b24f0418ab896916cfe8273

commit de32246846bc49b47b24f0418ab896916cfe8273
Author: Daniel Bratell <bratell@opera.com>
Date: Fri Apr 06 15:12:56 2018

Gave some Mac/Views helper functions unique names

In jumbo experiments (jumbo is not yet supported in
chrome/browser/ui) several GetBubbleAnchorView and
GetBubbleAnchorRect functions clashed. They were more or less
identical but there is no obvious place to share them, and even
though they are small, the code gets messier if you inline them.

This patch gives the functions unique names as a preparation
for jumbo support in chrome/browser/ui

Bug:  803406 
Change-Id: I104ae7cc961dd867e89e06fe8f18b401b39af549
Reviewed-on: https://chromium-review.googlesource.com/998158
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#548778}
[modify] https://crrev.com/de32246846bc49b47b24f0418ab896916cfe8273/chrome/browser/ui/views/global_error_bubble_view.cc
[modify] https://crrev.com/de32246846bc49b47b24f0418ab896916cfe8273/chrome/browser/ui/views/session_crashed_bubble_view.cc
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 6 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b0a835934b2dc35fb738434b481493abb9fae0b

commit 7b0a835934b2dc35fb738434b481493abb9fae0b
Author: Daniel Bratell <bratell@opera.com>
Date: Fri Apr 06 16:42:26 2018

Reuse existing AcceleratorMapping struct

The two identical AcceleratorMapping structs clashed in jumbo
build experiments (no offical support of jumbo in this code
yet).

Bug:  803406 
Change-Id: I065bfb447de67c05d2f6172ffbdeff4bc68e6538
Reviewed-on: https://chromium-review.googlesource.com/997832
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#548810}
[modify] https://crrev.com/7b0a835934b2dc35fb738434b481493abb9fae0b/chrome/browser/ui/views/apps/chrome_native_app_window_views.cc
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dbdb188fcc9afc266c05f69076aed7c6e9ee4853

commit dbdb188fcc9afc266c05f69076aed7c6e9ee4853
Author: Daniel Bratell <bratell@opera.com>
Date: Mon Apr 09 09:10:07 2018

Made two GetExtensionView() functions into member functions

There were two GetExtensionView functions which clashed in
jumbo build experiments where they ended up in the same
translation unit. This patch makes them member functions which
removes the need to supply an argument, which in turn makes the
code a bit simpler and easier to read.

Bug:  803406 
Change-Id: I09fad295de900d6d78092397654314e757761226
Reviewed-on: https://chromium-review.googlesource.com/997774
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#549133}
[modify] https://crrev.com/dbdb188fcc9afc266c05f69076aed7c6e9ee4853/chrome/browser/ui/views/extensions/extension_dialog.cc
[modify] https://crrev.com/dbdb188fcc9afc266c05f69076aed7c6e9ee4853/chrome/browser/ui/views/extensions/extension_dialog.h
[modify] https://crrev.com/dbdb188fcc9afc266c05f69076aed7c6e9ee4853/chrome/browser/ui/views/extensions/extension_popup.cc
[modify] https://crrev.com/dbdb188fcc9afc266c05f69076aed7c6e9ee4853/chrome/browser/ui/views/extensions/extension_popup.h
Project Member

Comment 12 by bugdroid1@chromium.org, May 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e63a902ae71efc25b61caa06da097f3022a3e5e2

commit e63a902ae71efc25b61caa06da097f3022a3e5e2
Author: Daniel Bratell <bratell@opera.com>
Date: Fri May 25 14:23:10 2018

Change some payments code to not have so many kFirstTagValue

In jumbo build experiments all the kFirstTag variables ended up
in the same translation unit and prevented compilation. This patch
retires those variables, and also renames an enum that had got
a copy-paste name.

Bug:  803406 
Change-Id: I887d85a3632766845a7caede089d99ed73efba35
Reviewed-on: https://chromium-review.googlesource.com/1073308
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561861}
[modify] https://crrev.com/e63a902ae71efc25b61caa06da097f3022a3e5e2/chrome/browser/ui/views/payments/editor_view_controller.cc
[modify] https://crrev.com/e63a902ae71efc25b61caa06da097f3022a3e5e2/chrome/browser/ui/views/payments/payment_method_view_controller.cc
[modify] https://crrev.com/e63a902ae71efc25b61caa06da097f3022a3e5e2/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
[modify] https://crrev.com/e63a902ae71efc25b61caa06da097f3022a3e5e2/chrome/browser/ui/views/payments/profile_list_view_controller.cc

Comment 13 by brat...@opera.com, Jul 16

Owner: osc...@opera.com
Status: Started (was: Available)
Project Member

Comment 14 by bugdroid1@chromium.org, Jul 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58c21e23f2b7fe8496b51b7501ec16c22c884263

commit 58c21e23f2b7fe8496b51b7501ec16c22c884263
Author: Daniel Bratell <bratell@opera.com>
Date: Mon Jul 16 19:22:48 2018

Use :: prefix to distinguish between ::media_router::prefs and ::prefs

There are two namespaces named prefs in scope inside media_router code:
The global ::prefs namespace and the local ::media_router::prefs namespace.

If both namespaces are known to the compiler, as happens in jumbo builds,
then the name lookup will be ambigious and the compiler will fail to
compile the code.

Bug:  803406 
Change-Id: Ib4be547ffe1ba7a790c2003fd54bd091935c378e
Reviewed-on: https://chromium-review.googlesource.com/1138244
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575379}
[modify] https://crrev.com/58c21e23f2b7fe8496b51b7501ec16c22c884263/chrome/browser/ui/views/media_router/media_remoting_dialog_view.cc
Project Member

Comment 15 by bugdroid1@chromium.org, Jul 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2f798ac098967c17e1e35f17d3f71cea33fa4b2

commit f2f798ac098967c17e1e35f17d3f71cea33fa4b2
Author: Oscar Johansson <oscarj@opera.com>
Date: Tue Jul 17 13:23:02 2018

Make category names unique for interfaces (browser/ui)

When building using jumbo, interfaces and implementations
end up in the same scope. The interfaces with the same
category name conflicts.

This commit solves the issue by renaming the category to
something more file specific.

Bug:  803406 
Change-Id: I21a6645640d40b0ed6cd1324dfc30efa87da23c0
Reviewed-on: https://chromium-review.googlesource.com/1140162
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Oscar Johansson <oscarj@opera.com>
Cr-Commit-Position: refs/heads/master@{#575624}
[modify] https://crrev.com/f2f798ac098967c17e1e35f17d3f71cea33fa4b2/chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm
[modify] https://crrev.com/f2f798ac098967c17e1e35f17d3f71cea33fa4b2/chrome/browser/ui/cocoa/browser_window_controller_private.mm
[modify] https://crrev.com/f2f798ac098967c17e1e35f17d3f71cea33fa4b2/chrome/browser/ui/cocoa/tabbed_browser_window.mm
[modify] https://crrev.com/f2f798ac098967c17e1e35f17d3f71cea33fa4b2/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm
[modify] https://crrev.com/f2f798ac098967c17e1e35f17d3f71cea33fa4b2/chrome/browser/ui/cocoa/tabs/tab_view.mm
[modify] https://crrev.com/f2f798ac098967c17e1e35f17d3f71cea33fa4b2/chrome/browser/ui/views/frame/browser_native_widget_window_mac.mm
Project Member

Comment 16 by bugdroid1@chromium.org, Jul 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2c7f79a4227d9457f74a4ff31e3c36b1f9ee9e4

commit b2c7f79a4227d9457f74a4ff31e3c36b1f9ee9e4
Author: Oscar Johansson <oscarj@opera.com>
Date: Tue Jul 17 14:37:54 2018

Specify sender type  before changing state (browser/ui/cocoa)

Instead of using id as sender type this commit specifies which
types that are possible to recieve.

Bug:  803406 
Change-Id: If5a6cfb0c0788b1e2a9e911ae05e9f7dc5e3840d
Reviewed-on: https://chromium-review.googlesource.com/1140166
Commit-Queue: Oscar Johansson <oscarj@opera.com>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575637}
[modify] https://crrev.com/b2c7f79a4227d9457f74a4ff31e3c36b1f9ee9e4/chrome/browser/ui/cocoa/browser_window_command_handler.mm
[modify] https://crrev.com/b2c7f79a4227d9457f74a4ff31e3c36b1f9ee9e4/chrome/browser/ui/cocoa/extensions/media_gallery_list_entry_view.mm
[modify] https://crrev.com/b2c7f79a4227d9457f74a4ff31e3c36b1f9ee9e4/chrome/browser/ui/cocoa/translate/translate_bubble_controller.mm
Project Member

Comment 17 by bugdroid1@chromium.org, Jul 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/213a3c33e572751775994a713f9a320e4bcb29f1

commit 213a3c33e572751775994a713f9a320e4bcb29f1
Author: Oscar Johansson <oscarj@opera.com>
Date: Wed Jul 18 06:37:14 2018

Resolve name conflict between regular and cocoa classes

When building using jumbo, files may end up in the same scope.
In chrome/browser/ui, ui elements defined with the same name in
both browser/ui and  browser/ui/cocoa conflict. This is relevant
for the classes:

HoverButton
ReloadButton
TabStripController
TabController
NewTabButton
BookmarkBarView
DownloadShelfViewCocoa
ToolbarButton
AvatarButton
SadTabView
AlertIndicatorButton
ToolbarView

This commit solves the issue by adding "Cocoa" to the classes
defined in chrome/browser/ui/cocoa. This is changed in
chrome/browser/ui/cocoa and ui/base/cocoa.

Bug:  803406 
Change-Id: Iafd3b9447e4ed6960d86d43d12213ad367919357
Reviewed-on: https://chromium-review.googlesource.com/1140055
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Oscar Johansson <oscarj@opera.com>
Cr-Commit-Position: refs/heads/master@{#575959}
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/app/nibs/Toolbar.xib
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/autofill/autofill_tooltip_controller.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/base_bubble_controller.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view.h
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa.h
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa_unittest.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/browser/zoom_bubble_controller.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/browser_window_cocoa.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/browser_window_controller.h
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/browser_window_controller.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/browser_window_controller_private.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/browser_window_layout.h
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/browser_window_layout.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/browser_window_utils.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/download/download_shelf_controller.h
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/download/download_shelf_controller.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/download/download_shelf_view_cocoa.h
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/download/download_shelf_view_cocoa.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/download/download_shelf_view_cocoa_unittest.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/download/md_download_item_view.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/extensions/browser_action_button.h
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.h
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/fullscreen_window.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/harmony_button.h
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/harmony_button.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/hover_close_button.h
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/md_hover_button.h
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/md_hover_button.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/menu_button.h
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/new_tab_button.h
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/new_tab_button_cocoa.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/profiles/avatar_button.h
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/profiles/avatar_button_cocoa.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/profiles/avatar_button_unittest.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/tab_contents/sad_tab_mac.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/tab_contents/sad_tab_mac_unittest.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/tab_contents/sad_tab_view_cocoa.h
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/tab_contents/sad_tab_view_cocoa.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/tab_dialogs_cocoa.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/tabs/alert_indicator_button_cocoa.h
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/tabs/alert_indicator_button_cocoa.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/tabs/alert_indicator_button_cocoa_unittest.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/tabs/tab_controller.h
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/tabs/tab_controller.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/tabs/tab_controller_target.h
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/tabs/tab_controller_unittest.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/tabs/tab_strip_controller.h
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/tabs/tab_strip_controller_unittest.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.h
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/tabs/tab_strip_view.h
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/tabs/tab_strip_view.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/tabs/tab_view.h
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/tabs/tab_view.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/tabs/tab_view_unittest.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/tabs/tab_window_controller.h
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/tabs/tab_window_controller.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/toolbar/reload_button_cocoa.h
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/toolbar/reload_button_cocoa.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/toolbar/reload_button_unittest_cocoa.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.h
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/toolbar/toolbar_button_unittest.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/toolbar/toolbar_controller.h
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/toolbar/toolbar_view_cocoa.h
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/toolbar/toolbar_view_cocoa.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/toolbar/toolbar_view_unittest.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/chrome/browser/ui/cocoa/view_id_util.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/ui/base/cocoa/controls/blue_label_button.h
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/ui/base/cocoa/controls/blue_label_button.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/ui/base/cocoa/hover_button.h
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/ui/base/cocoa/hover_button.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/ui/base/cocoa/hover_button_unittest.mm
[modify] https://crrev.com/213a3c33e572751775994a713f9a320e4bcb29f1/ui/base/cocoa/hover_image_button.h
Project Member

Comment 18 by bugdroid1@chromium.org, Jul 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15f081e870c28b9584fc58a6d9e214ea8206bea6

commit 15f081e870c28b9584fc58a6d9e214ea8206bea6
Author: Oscar Johansson <oscarj@opera.com>
Date: Wed Jul 18 09:12:47 2018

Fix typo in SadTabViewCocoa (from SabTabViewCocoa)

The class SadTabViewCocoa has a typo and is currently
named SabTabViewCocoa. This commit renames the class
to the correct name.

TBR=avi@chromium.org

Bug:  803406 
Change-Id: Id290fe8d016fe0fae9c760cb556e7c8896d17426
Reviewed-on: https://chromium-review.googlesource.com/1141569
Reviewed-by: Daniel Bratell <bratell@opera.com>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#575986}
[modify] https://crrev.com/15f081e870c28b9584fc58a6d9e214ea8206bea6/chrome/browser/ui/cocoa/tab_contents/sad_tab_mac.mm
[modify] https://crrev.com/15f081e870c28b9584fc58a6d9e214ea8206bea6/chrome/browser/ui/cocoa/tab_contents/sad_tab_mac_unittest.mm
[modify] https://crrev.com/15f081e870c28b9584fc58a6d9e214ea8206bea6/chrome/browser/ui/cocoa/tab_contents/sad_tab_view_cocoa.h
[modify] https://crrev.com/15f081e870c28b9584fc58a6d9e214ea8206bea6/chrome/browser/ui/cocoa/tab_contents/sad_tab_view_cocoa.mm
Project Member

Comment 19 by bugdroid1@chromium.org, Jul 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc0c047faf7c2d2ec4e69fc699b41c6efb06a358

commit cc0c047faf7c2d2ec4e69fc699b41c6efb06a358
Author: Oscar Johansson <oscarj@opera.com>
Date: Wed Jul 18 18:09:49 2018

Specify class type before calling setCornerFlags (mac)

Specifying what subclass of NSView being called,
in this  case BubbleView.

Bug:  803406 
Change-Id: Iabc0a02ab17a881993f34b9c120978ca7f45264c
Reviewed-on: https://chromium-review.googlesource.com/1141879
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Oscar Johansson <oscarj@opera.com>
Cr-Commit-Position: refs/heads/master@{#576137}
[modify] https://crrev.com/cc0c047faf7c2d2ec4e69fc699b41c6efb06a358/chrome/browser/ui/cocoa/status_bubble_mac.mm
Project Member

Comment 20 by bugdroid1@chromium.org, Jul 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/038300d654e5136892a1761b208fa48adb47a4ad

commit 038300d654e5136892a1761b208fa48adb47a4ad
Author: Oscar Johansson <oscarj@opera.com>
Date: Wed Jul 18 18:11:16 2018

Make variable names unique (mac)

When building using jumbo, files gets merged and
variables with the same name may end up in the same
scope. This commit renames such varaibles to something
more descriptive or file specific.

Bug:  803406 
Change-Id: Ia43af0d95b0693ce917722397bc23db655441c29
Reviewed-on: https://chromium-review.googlesource.com/1141579
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Oscar Johansson <oscarj@opera.com>
Cr-Commit-Position: refs/heads/master@{#576139}
[modify] https://crrev.com/038300d654e5136892a1761b208fa48adb47a4ad/chrome/browser/ui/cocoa/autofill/autofill_tooltip_controller.mm
[modify] https://crrev.com/038300d654e5136892a1761b208fa48adb47a4ad/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_hover_state.h
[modify] https://crrev.com/038300d654e5136892a1761b208fa48adb47a4ad/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_hover_state.mm
[modify] https://crrev.com/038300d654e5136892a1761b208fa48adb47a4ad/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_hover_state_unittest.mm
[modify] https://crrev.com/038300d654e5136892a1761b208fa48adb47a4ad/chrome/browser/ui/cocoa/extensions/browser_actions_container_view.mm
[modify] https://crrev.com/038300d654e5136892a1761b208fa48adb47a4ad/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm
[modify] https://crrev.com/038300d654e5136892a1761b208fa48adb47a4ad/chrome/browser/ui/cocoa/extensions/media_gallery_list_entry_view.mm
[modify] https://crrev.com/038300d654e5136892a1761b208fa48adb47a4ad/chrome/browser/ui/cocoa/harmony_button.mm
[modify] https://crrev.com/038300d654e5136892a1761b208fa48adb47a4ad/chrome/browser/ui/cocoa/hover_close_button.h
[modify] https://crrev.com/038300d654e5136892a1761b208fa48adb47a4ad/chrome/browser/ui/cocoa/hover_close_button.mm
[modify] https://crrev.com/038300d654e5136892a1761b208fa48adb47a4ad/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm
[modify] https://crrev.com/038300d654e5136892a1761b208fa48adb47a4ad/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm
[modify] https://crrev.com/038300d654e5136892a1761b208fa48adb47a4ad/chrome/browser/ui/cocoa/md_hover_button.mm
[modify] https://crrev.com/038300d654e5136892a1761b208fa48adb47a4ad/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.mm
[modify] https://crrev.com/038300d654e5136892a1761b208fa48adb47a4ad/chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm
[modify] https://crrev.com/038300d654e5136892a1761b208fa48adb47a4ad/chrome/browser/ui/cocoa/status_bubble_mac.mm
[modify] https://crrev.com/038300d654e5136892a1761b208fa48adb47a4ad/chrome/browser/ui/cocoa/tab_contents/sad_tab_view_cocoa.mm
[modify] https://crrev.com/038300d654e5136892a1761b208fa48adb47a4ad/chrome/browser/ui/cocoa/translate/translate_bubble_controller.mm
[modify] https://crrev.com/038300d654e5136892a1761b208fa48adb47a4ad/chrome/browser/ui/sad_tab.cc
[modify] https://crrev.com/038300d654e5136892a1761b208fa48adb47a4ad/chrome/browser/ui/sad_tab.h
[modify] https://crrev.com/038300d654e5136892a1761b208fa48adb47a4ad/chrome/browser/ui/views/sad_tab_view.cc
[modify] https://crrev.com/038300d654e5136892a1761b208fa48adb47a4ad/ui/base/cocoa/controls/blue_label_button.mm
[modify] https://crrev.com/038300d654e5136892a1761b208fa48adb47a4ad/ui/base/cocoa/hover_button.h
[modify] https://crrev.com/038300d654e5136892a1761b208fa48adb47a4ad/ui/base/cocoa/hover_button.mm
[modify] https://crrev.com/038300d654e5136892a1761b208fa48adb47a4ad/ui/base/cocoa/hover_button_unittest.mm
Project Member

Comment 21 by bugdroid1@chromium.org, Jul 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72b1dbe982d6f066238f636c286d17eadb23d33f

commit 72b1dbe982d6f066238f636c286d17eadb23d33f
Author: Oscar Johansson <oscarj@opera.com>
Date: Thu Jul 19 15:19:13 2018

Move functions and constants to util files (mac)

When building using jumbo, files gets merged and functions and
constants with the same name may end up in the same scope.
This commits moves such functions and constants to shared
util files.

Bug:  803406 
Change-Id: I3a0d763741c3d6b631539fdfe51f8fddc0b255a0
Reviewed-on: https://chromium-review.googlesource.com/1141865
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Commit-Queue: Oscar Johansson <oscarj@opera.com>
Cr-Commit-Position: refs/heads/master@{#576502}
[modify] https://crrev.com/72b1dbe982d6f066238f636c286d17eadb23d33f/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/72b1dbe982d6f066238f636c286d17eadb23d33f/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
[modify] https://crrev.com/72b1dbe982d6f066238f636c286d17eadb23d33f/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm
[add] https://crrev.com/72b1dbe982d6f066238f636c286d17eadb23d33f/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_util.h
[add] https://crrev.com/72b1dbe982d6f066238f636c286d17eadb23d33f/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_util.mm
[modify] https://crrev.com/72b1dbe982d6f066238f636c286d17eadb23d33f/chrome/browser/ui/cocoa/bubble_sync_promo_controller.mm
[add] https://crrev.com/72b1dbe982d6f066238f636c286d17eadb23d33f/chrome/browser/ui/cocoa/cocoa_util.h
[add] https://crrev.com/72b1dbe982d6f066238f636c286d17eadb23d33f/chrome/browser/ui/cocoa/cocoa_util.mm
[modify] https://crrev.com/72b1dbe982d6f066238f636c286d17eadb23d33f/chrome/browser/ui/cocoa/info_bubble_window.mm
[modify] https://crrev.com/72b1dbe982d6f066238f636c286d17eadb23d33f/chrome/browser/ui/cocoa/new_tab_button_cocoa.mm
[modify] https://crrev.com/72b1dbe982d6f066238f636c286d17eadb23d33f/chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_view_controller.mm
[add] https://crrev.com/72b1dbe982d6f066238f636c286d17eadb23d33f/chrome/browser/ui/cocoa/spinner_util.h
[modify] https://crrev.com/72b1dbe982d6f066238f636c286d17eadb23d33f/chrome/browser/ui/cocoa/spinner_view.mm
[modify] https://crrev.com/72b1dbe982d6f066238f636c286d17eadb23d33f/chrome/browser/ui/cocoa/status_bubble_mac.mm
[modify] https://crrev.com/72b1dbe982d6f066238f636c286d17eadb23d33f/chrome/browser/ui/cocoa/tabbed_browser_window.mm
[modify] https://crrev.com/72b1dbe982d6f066238f636c286d17eadb23d33f/chrome/browser/ui/cocoa/tabs/tab_spinner_view.mm
[modify] https://crrev.com/72b1dbe982d6f066238f636c286d17eadb23d33f/chrome/browser/ui/views/frame/browser_native_widget_window_mac.mm
[modify] https://crrev.com/72b1dbe982d6f066238f636c286d17eadb23d33f/chrome/browser/ui/webui/flash_ui.cc
[modify] https://crrev.com/72b1dbe982d6f066238f636c286d17eadb23d33f/chrome/browser/ui/webui/nacl_ui.cc
[add] https://crrev.com/72b1dbe982d6f066238f636c286d17eadb23d33f/chrome/browser/ui/webui/webui_util.cc
[add] https://crrev.com/72b1dbe982d6f066238f636c286d17eadb23d33f/chrome/browser/ui/webui/webui_util.h
[modify] https://crrev.com/72b1dbe982d6f066238f636c286d17eadb23d33f/ui/views/BUILD.gn
[modify] https://crrev.com/72b1dbe982d6f066238f636c286d17eadb23d33f/ui/views/cocoa/native_widget_mac_nswindow.h
[add] https://crrev.com/72b1dbe982d6f066238f636c286d17eadb23d33f/ui/views/widget/util_mac.h
Project Member

Comment 22 by bugdroid1@chromium.org, Jul 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6b665da72203227eb29486c6643a5acb3684db4

commit a6b665da72203227eb29486c6643a5acb3684db4
Author: Oscar Johansson <oscarj@opera.com>
Date: Thu Jul 19 15:55:13 2018

Rename constants to be unique (mac)

When building using jumbo, files gets merged and constants
with the same name may end up in the same scope and conflict.

This commit solves the issue by renaming the constants to
something more file specific.

Bug:  803406 
Change-Id: I70976f012e9be6f395d4bfcc43e785515071ebb3
Reviewed-on: https://chromium-review.googlesource.com/1142783
Commit-Queue: Oscar Johansson <oscarj@opera.com>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576511}
[modify] https://crrev.com/a6b665da72203227eb29486c6643a5acb3684db4/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm
[modify] https://crrev.com/a6b665da72203227eb29486c6643a5acb3684db4/chrome/browser/ui/cocoa/browser/zoom_bubble_controller.mm
[modify] https://crrev.com/a6b665da72203227eb29486c6643a5acb3684db4/chrome/browser/ui/cocoa/bubble_sync_promo_controller.mm
[modify] https://crrev.com/a6b665da72203227eb29486c6643a5acb3684db4/chrome/browser/ui/cocoa/constrained_window/constrained_window_alert.mm
[modify] https://crrev.com/a6b665da72203227eb29486c6643a5acb3684db4/chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_sheet.mm
[modify] https://crrev.com/a6b665da72203227eb29486c6643a5acb3684db4/chrome/browser/ui/cocoa/download/download_item_cell.mm
[modify] https://crrev.com/a6b665da72203227eb29486c6643a5acb3684db4/chrome/browser/ui/cocoa/download/download_show_all_cell.mm
[modify] https://crrev.com/a6b665da72203227eb29486c6643a5acb3684db4/chrome/browser/ui/cocoa/extensions/browser_action_button.mm
[modify] https://crrev.com/a6b665da72203227eb29486c6643a5acb3684db4/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm
[modify] https://crrev.com/a6b665da72203227eb29486c6643a5acb3684db4/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm
[modify] https://crrev.com/a6b665da72203227eb29486c6643a5acb3684db4/chrome/browser/ui/cocoa/tabs/tab_view.mm
Project Member

Comment 23 by bugdroid1@chromium.org, Jul 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce028a038e1bc0308a317d6362a4bb2f2df8b885

commit ce028a038e1bc0308a317d6362a4bb2f2df8b885
Author: Oscar Johansson <oscarj@opera.com>
Date: Mon Jul 23 08:15:38 2018

Resolve include and define issues for jumbo (mac)

When building using jumbo, files get merged and variables,
functions and defines could end up in the same scope and
conflict. This commit solves issues with includes and defines
for the mac specific part of chrome/browser/ui.

Bug:  803406 
Change-Id: I55d1f6110a6144bc7ee3037a374d3e33c36a9879
Reviewed-on: https://chromium-review.googlesource.com/1144928
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Oscar Johansson <oscarj@opera.com>
Cr-Commit-Position: refs/heads/master@{#577121}
[modify] https://crrev.com/ce028a038e1bc0308a317d6362a4bb2f2df8b885/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/ce028a038e1bc0308a317d6362a4bb2f2df8b885/chrome/browser/ui/cocoa/spinner_view.mm
[modify] https://crrev.com/ce028a038e1bc0308a317d6362a4bb2f2df8b885/chrome/browser/ui/cocoa/tabs/tab_view.mm
[modify] https://crrev.com/ce028a038e1bc0308a317d6362a4bb2f2df8b885/ui/views/widget/widget.h
Project Member

Comment 24 by bugdroid1@chromium.org, Jul 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c9b30bf8b3af452a36f77d8d4005b3bd9c7f0b0

commit 9c9b30bf8b3af452a36f77d8d4005b3bd9c7f0b0
Author: Oscar Johansson <oscarj@opera.com>
Date: Mon Jul 23 19:03:36 2018

Enable jumbo for chrome/browser/ui

This commit will enable jumbo for chrome/browser/ui. This will
reduce the build time by approximately 90 CPU minutes (more
than 10 % of the total jumbo build time for chromium), compared to
building without jumbo.

Bug:  803406 
Change-Id: I7774bd55378ea88dadcbf452679686e383bb15a2
Reviewed-on: https://chromium-review.googlesource.com/1143269
Commit-Queue: Oscar Johansson <oscarj@opera.com>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577213}
[modify] https://crrev.com/9c9b30bf8b3af452a36f77d8d4005b3bd9c7f0b0/chrome/browser/ui/BUILD.gn

Comment 25 by brat...@opera.com, Jul 27

Status: Fixed (was: Started)
It worked. Closing as fixed.
Project Member

Comment 26 by bugdroid1@chromium.org, Aug 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/455c1e882bb4e454bfd20afca4b7a8920121b44e

commit 455c1e882bb4e454bfd20afca4b7a8920121b44e
Author: Greg Thompson <grt@chromium.org>
Date: Wed Aug 29 22:43:23 2018

Fix jumbo build break for Chrome-branded builds.

In Google Chrome builds, cast_toolbar_button.cc may be built in the same
unit as cast_dialog_sink_button.cc. The latter includes a Google
Chrome-only header that declares some vector icons in the
::media_router::vector_icons namespace. As a result, the icons used in
cast_toolbar_button.cc can't be found because the points of use are in
the ::media_router namespace. Fix this by explicitly looking in
::vector_icons for the desired icons. This has no change for non-jumbo
builds, and fixes the world for jumbo builds.

BUG= 803406 
R=ellyjones@chromium.org
CC=oscarj@opera.com

Change-Id: I6af8e2593b20e1b674e8045fc406f12b9664fcb4
Reviewed-on: https://chromium-review.googlesource.com/1195885
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587345}
[modify] https://crrev.com/455c1e882bb4e454bfd20afca4b7a8920121b44e/chrome/browser/ui/views/media_router/cast_toolbar_button.cc
►

Sign in to add a comment