New issue
Advanced search Search tips

Issue 803399 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression : [Devtools] Upper border of Expression text field appears faint.

Reported by avsha...@etouch.net, Jan 18 2018

Issue description

Chrome Version : 65.0.3324.0 (Official Build) 07b221a26af55a4c3e7e375c629eb8474247f691-refs/heads/master@{#530027} 32/64-bit
OS : Windows(7,8,8.1,10), Linux(14.04 LTS), Mac(10.12.6, 10.13.1, 10.13.3)

What steps will reproduce the problem?
1. Launch chrome, open devtools on NTP and navigate to ’Sources’ tab.
2. Go to ‘Watch’ tab and click on ‘Add Expression’(+) icon.
3. Observe the upper border of text field.

Actual Result : Upper border of Expression text field appears faint.

Expected Result : Upper border of Expression text field should be clearly visible.

This is a regression issue broken in ‘M-65’ and using per-revision bisect providing the bisect results,
Good Build : 65.0.3294.0 (Revision : 523977)
Bad Build : 65.0.3295.0 (Revision : 524284)

You are probably looking for a change made after 524196 (known good), but no later than 524197 (first known bad).

CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/0adf6dfe8242c546ebe2b66f838b5fd89834901d..fe33e303b2618fb2c98e987a8c97fd58b5adeb2d

Suspect : https://chromium.googlesource.com/chromium/src/+/fe33e303b2618fb2c98e987a8c97fd58b5adeb2d

@alph : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Note : 
1. This issue can be clearly observed on Windows desktops with 1280 x 1024 screen resolution.
2. Issue is reproducible on latest Dev build #65.0.3322.3
 
Act_Exp_Textfield.png
15.0 KB View Download
Actual_devtools.mov
2.4 MB Download
Expected_devtools.mov
2.7 MB Download
Labels: RegressedIn-65 Target-65 FoundIn-65
Labels: ET-MUM-Reported
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9cf21e0c6801d09032574ea225958fd1a34ad5c9

commit 9cf21e0c6801d09032574ea225958fd1a34ad5c9
Author: Alexei Filippov <alph@chromium.org>
Date: Tue Jul 10 15:11:54 2018

DevTools: Fix watch expressions editor margins

NOTRY=true
BUG= 803399 

Change-Id: If3bab9284ae13a97d8f3f84b10dc971da8f228fb
Reviewed-on: https://chromium-review.googlesource.com/1129462
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573728}
[modify] https://crrev.com/9cf21e0c6801d09032574ea225958fd1a34ad5c9/third_party/blink/renderer/devtools/front_end/sources/watchExpressionsSidebarPane.css

Labels: -Pri-1 Pri-2
Status: Fixed (was: Assigned)
Labels: TE-Verified-M69 TE-Verified-69.0.3488.0
Update :
Tested above issue in latest Canary build #69.0.3488.0 on Windows (7, 8, 8.1, 10), Mac(10.12.6, 10.13.1, 10.14, 10.13.6) & Linux(14.04 LTS) OS and the issue is fixed. Upper border of Expression text field now appears properly in devtools in latest Canary build. Kindly review an attached screen-cast for reference.

Thank you..!
Latest_behaviour.mp4
1.0 MB View Download

Sign in to add a comment