DismissSyncConfirmationDialog sometimes never returns in tests |
||
Issue descriptionIn CL https://chromium-review.googlesource.com/c/chromium/src/+/857467 I hit this issue. I found a fix for most cases, but it kept failing on windows and the CL was reverted. One issue is that the javascript execution sometimes never returns, which is presumably because the web_contents is destroyed while the javascript is executing, which is not supported and the test hangs. Fixing this (by replacing the javascript synchronous call by an asynchronous call) did not solve the issue completely though, so either there is something else or maybe my fix was incorrect.
,
Jan 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e1a170e8fae2f895b0aedf1e06fa4e29ca6da96 commit 1e1a170e8fae2f895b0aedf1e06fa4e29ca6da96 Author: David Roger <droger@chromium.org> Date: Thu Jan 18 16:24:03 2018 [Dice] Refactor signin confirmation. This CL moves away from OneClickSinginSyncStarter when using Dice. OneClickSinginSyncStarter is now deprecated and will be removed once Dice is fully enabled. All the relevant code is now in DiceTurnSyncOnHelper, and is simpler than the previous code. As part of this change, the token is now correctly removed when the signin flow is aborted, and the call to merge session has been removed. Bug: 799880, 797342, 803395 Change-Id: I87355331d81fa11c81b9ed3e3765f617a10c8613 Reviewed-on: https://chromium-review.googlesource.com/873070 Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#530159} [modify] https://crrev.com/1e1a170e8fae2f895b0aedf1e06fa4e29ca6da96/chrome/browser/signin/dice_browsertest.cc [modify] https://crrev.com/1e1a170e8fae2f895b0aedf1e06fa4e29ca6da96/chrome/browser/ui/sync/one_click_signin_sync_starter.cc [modify] https://crrev.com/1e1a170e8fae2f895b0aedf1e06fa4e29ca6da96/chrome/browser/ui/sync/one_click_signin_sync_starter.h [modify] https://crrev.com/1e1a170e8fae2f895b0aedf1e06fa4e29ca6da96/chrome/browser/ui/sync/one_click_signin_sync_starter_unittest.cc [modify] https://crrev.com/1e1a170e8fae2f895b0aedf1e06fa4e29ca6da96/chrome/browser/ui/webui/signin/dice_turn_sync_on_helper.cc [modify] https://crrev.com/1e1a170e8fae2f895b0aedf1e06fa4e29ca6da96/chrome/browser/ui/webui/signin/dice_turn_sync_on_helper.h [modify] https://crrev.com/1e1a170e8fae2f895b0aedf1e06fa4e29ca6da96/chrome/browser/ui/webui/signin/login_ui_test_utils.cc [modify] https://crrev.com/1e1a170e8fae2f895b0aedf1e06fa4e29ca6da96/chrome/browser/ui/webui/signin/sync_confirmation_handler.cc
,
Jan 19 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by droger@chromium.org
, Jan 18 2018