New issue
Advanced search Search tips

Issue 803387 link

Starred by 1 user
Status: Archived
Owner: ----
Closed: Sep 13
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
ellyjo...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression:Focus ring overlap on folder icon after adding 'new folder' in edit bookmark overlay.

Reported by vku...@etouch.net, Jan 18 2018 
Chrome Version:65.0.3324.0 (Official Build)Revision 07b221a26af55a4c3e7e375c629eb8474247f691-refs/heads/master@{#530027} (32/64-bit). 
OS:Mac(10.12.6, 10.13.1, 10.13.3)

What steps will reproduce the problem?
(1)Launch chrome and open any webpage, click on star icon > edit
(2)Click on 'New folder' from edit bookmark overlay and observe the focus ring and folder icon.

Actual: Focus ring overlap on folder icon after adding new folder.

Expected: Focus ring should not overlap on folder icon after adding new folder.

This is a regression issue broken in 'M65' and below is the manual regression range
Good Build: 65.0.3322.3(Revision:529188)
Bad Build:  65.0.3324.0(Revision:530027)

Note: Issue is not seen on Win(7,8,8.1,10) & Linux(14.04 LTS)OS.
Actual_Bookmark.mov
1022 KB Download
Expected_Bookmark.mov
929 KB Download
Actual.png
808 KB View Download

Comment 1 by vku...@etouch.net, Jan 18 2018

Labels: hasbisect-per-revision
Owner: ellyjo...@chromium.org
Status: Assigned (was: Unconfirmed)
You are probably looking for a change made after 529860 (known good), but no later than 529861 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/029769170f4a879fee9014782ad4e72987bddd4d..f81dbbb30c4b054059502682325551d278b251be

Suspecting: https://chromium.googlesource.com/chromium/src/+/f81dbbb30c4b054059502682325551d278b251be

@ellyjones: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Comment 2 by rbasuvula@chromium.org, Jan 18 2018

Labels: RegressedIn-65 Target-65 FoundIn-65

Comment 3 by ellyjo...@chromium.org, Jan 26 2018

Cc: ellyjo...@chromium.org
Components: Internals>Views
Labels: -Pri-1 -hasbisect-per-revision -Target-65 Pri-2
Owner: ----
Status: Available (was: Assigned)
Okay, I had a look at this. There is no real way around this issue that I can see - we have to either have the text move when editing starts, to leave room for the focus ring, or leave an unsightly large gap between the icon and the text to avoid having to do that.

It's possible there is some cleverer fix that one could do for this, but I think the thin focus ring mitigates a lot of the ugliness. For now I'm going to drop the priority on this and mark it Available, pending a UX redesign of treeview.

Comment 4 by nyerramilli@chromium.org, Feb 2 2018

Labels: ET-MUM-Reported

Comment 5 by robliao@chromium.org, Sep 13

Status: Archived (was: Available)
Archiving old bugs that haven't been actively assigned in over 180 days.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!

Comment 6 by robliao@chromium.org, Sep 13 

Archiving old bugs that haven't been actively assigned in over 180 days.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!
►

Sign in to add a comment