New issue
Advanced search Search tips

Issue 803386 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task

Blocked on:
issue 803383



Sign in to add a comment

Check if we can get rid of the updateToolbarState method

Project Member Reported by gambard@chromium.org, Jan 18 2018

Issue description

The updateToolbarState method is here because the it doesn't get update on interstitials (issue 795947).

We should see if it is possible to have the toolbar working with interstitials without it.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cdf7c4503a2e6e7222da0fa3d9b1f25fd829779b

commit cdf7c4503a2e6e7222da0fa3d9b1f25fd829779b
Author: Gauthier Ambard <gambard@chromium.org>
Date: Mon Jan 22 16:51:07 2018

Removes updates of the toolbar triggered by BVC

This CL removes the update of the toolbar view triggered by
-updateToolbarState, called by BVC. This call is not needed as the
callbacks are done in the ToolbarMediator.
It allows us to remove this method once the updates of the omnibox are
moved to the locationBarCoordinator.

Bug:  803386 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: If4d9d5340329f3a2f9e14fce75e83597463864e5
Reviewed-on: https://chromium-review.googlesource.com/878331
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530887}
[modify] https://crrev.com/cdf7c4503a2e6e7222da0fa3d9b1f25fd829779b/ios/chrome/browser/ui/toolbar/clean/toolbar_coordinator.mm
[modify] https://crrev.com/cdf7c4503a2e6e7222da0fa3d9b1f25fd829779b/ios/chrome/browser/ui/toolbar/clean/toolbar_mediator.mm
[modify] https://crrev.com/cdf7c4503a2e6e7222da0fa3d9b1f25fd829779b/ios/chrome/browser/ui/toolbar/clean/toolbar_mediator_unittest.mm

Blockedon: 803383
Status: Fixed (was: Assigned)

Sign in to add a comment