New issue
Advanced search Search tips

Issue 803383 link

Starred by 1 user
Status: Fixed
Owner:
gambard@chromium.org
Closed: Jan 2018
Cc:
stkhapugin@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task

Blocking:
issue 803386



Sign in to add a comment

Location Bar: The location should update the state of the omnibox by itself

Project Member Reported by gambard@chromium.org, Jan 18 2018 
For now the Toolbar is triggering the updates of the omnibox state in the location bar.

This update should be triggered by the location bar itself, probably by having a mediator observing the active WebState.

Assigning to stk@ as owner of LocationBar.

Comment 1 by gambard@chromium.org, Jan 22 2018

Blocking: 803386

Comment 2 by stkhapugin@chromium.org, Jan 24 2018

Cc: -gambard@chromium.org stkhapugin@chromium.org
Owner: gambard@chromium.org
I don't see how this can be done, because updateToolbarState should probably be doing something except updating omnibox.
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/642e8a6a7b68087f6fd4a50709d0fbc0f1059010

commit 642e8a6a7b68087f6fd4a50709d0fbc0f1059010
Author: Gauthier Ambard <gambard@chromium.org>
Date: Thu Jan 25 14:52:42 2018

Have the LocationBar observing the WebState

This CL changes the location bar such as its mediator is observing the
currently active WebState and update the omnibox state accordingly.
This is done so the BVC doesn't have to send update commands to the
location bar through the toolbar.

Bug:  803383 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Id1ba13fc1c37e7c1a5a351dbd52c6859b44ce80c
Reviewed-on: https://chromium-review.googlesource.com/883444
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531899}
[modify] https://crrev.com/642e8a6a7b68087f6fd4a50709d0fbc0f1059010/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/642e8a6a7b68087f6fd4a50709d0fbc0f1059010/ios/chrome/browser/ui/location_bar/BUILD.gn
[add] https://crrev.com/642e8a6a7b68087f6fd4a50709d0fbc0f1059010/ios/chrome/browser/ui/location_bar/location_bar_consumer.h
[modify] https://crrev.com/642e8a6a7b68087f6fd4a50709d0fbc0f1059010/ios/chrome/browser/ui/location_bar/location_bar_coordinator.h
[modify] https://crrev.com/642e8a6a7b68087f6fd4a50709d0fbc0f1059010/ios/chrome/browser/ui/location_bar/location_bar_coordinator.mm
[modify] https://crrev.com/642e8a6a7b68087f6fd4a50709d0fbc0f1059010/ios/chrome/browser/ui/location_bar/location_bar_coordinator_unittest.mm
[modify] https://crrev.com/642e8a6a7b68087f6fd4a50709d0fbc0f1059010/ios/chrome/browser/ui/location_bar/location_bar_mediator.h
[modify] https://crrev.com/642e8a6a7b68087f6fd4a50709d0fbc0f1059010/ios/chrome/browser/ui/location_bar/location_bar_mediator.mm
[add] https://crrev.com/642e8a6a7b68087f6fd4a50709d0fbc0f1059010/ios/chrome/browser/ui/location_bar/location_bar_mediator_unittest.mm
[modify] https://crrev.com/642e8a6a7b68087f6fd4a50709d0fbc0f1059010/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_coordinator.mm
[modify] https://crrev.com/642e8a6a7b68087f6fd4a50709d0fbc0f1059010/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_coordinator.mm
[modify] https://crrev.com/642e8a6a7b68087f6fd4a50709d0fbc0f1059010/ios/chrome/browser/ui/toolbar/adaptive/toolbar_coordinator_adaptor.mm
[modify] https://crrev.com/642e8a6a7b68087f6fd4a50709d0fbc0f1059010/ios/chrome/browser/ui/toolbar/clean/toolbar_coordinator.h
[modify] https://crrev.com/642e8a6a7b68087f6fd4a50709d0fbc0f1059010/ios/chrome/browser/ui/toolbar/clean/toolbar_coordinator.mm
[modify] https://crrev.com/642e8a6a7b68087f6fd4a50709d0fbc0f1059010/ios/chrome/browser/ui/toolbar/public/legacy_toolbar_coordinator.h
[modify] https://crrev.com/642e8a6a7b68087f6fd4a50709d0fbc0f1059010/ios/chrome/browser/ui/toolbar/public/toolbar_coordinating.h
[modify] https://crrev.com/642e8a6a7b68087f6fd4a50709d0fbc0f1059010/ios/chrome/browser/ui/toolbar/toolbar_adapter.mm

Comment 4 by gambard@chromium.org, Jan 25 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment