Adaptive Toolbar: Change background color on incognito NTP's scroll events |
||||||||
Issue descriptionWhen scrolling the incognito NTP, the toolbar background is supposed to change its color. Assigning to Justin as you are working on the NTP for the new UI. This bug is for tracking purpose (TODO in the AdaptiveToolbar coordinator).
,
Jan 23 2018
Assigning to Rohit as you are working on the incognito NTP.
,
Jan 23 2018
Please add the user story label here. It should starts with "S-"
,
Jan 23 2018
Please also add the size of this task: small, medium, or large?
,
Jan 24 2018
,
Jan 26 2018
,
Jan 27 2018
,
Apr 5 2018
,
May 9 2018
,
May 31 2018
Per https://bugs.chromium.org/p/chromium/issues/detail?id=805524#c6: Working as intended in current canary ... no change needed (i.e. no toolbar color change based on scroll offset change).,
,
May 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9dc4043d02659d0966bc936e67f3c72e9eeff89c commit 9dc4043d02659d0966bc936e67f3c72e9eeff89c Author: Justin Cohen <justincohen@google.com> Date: Thu May 31 17:45:53 2018 [ios] Remove unused incognito NTP toolbar methods and comments. Bug: 803379 , 804850 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I27d18de9a813cf4a333d6330d42e314b4f124989 Reviewed-on: https://chromium-review.googlesource.com/1080249 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#563304} [modify] https://crrev.com/9dc4043d02659d0966bc936e67f3c72e9eeff89c/ios/chrome/browser/ui/ntp/new_tab_page_controller_delegate.h [modify] https://crrev.com/9dc4043d02659d0966bc936e67f3c72e9eeff89c/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_coordinator.mm [modify] https://crrev.com/9dc4043d02659d0966bc936e67f3c72e9eeff89c/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_view_controller.mm [modify] https://crrev.com/9dc4043d02659d0966bc936e67f3c72e9eeff89c/ios/chrome/browser/ui/toolbar/adaptive/toolbar_coordinator_adaptor.mm |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by fhorschig@chromium.org
, Jan 18 2018