New issue
Advanced search Search tips

Issue 803376 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task



Sign in to add a comment

Adaptive Toolbar: The activity popup should be anchored to the correct button

Project Member Reported by gambard@chromium.org, Jan 18 2018

Issue description

When presented on iPad, the popup for the activity service should be anchored to the share button.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d665c92a8aac55d966283bb1db1007b586bcf8d6

commit d665c92a8aac55d966283bb1db1007b586bcf8d6
Author: Gauthier Ambard <gambard@chromium.org>
Date: Tue Jan 23 12:28:16 2018

Add activity service position to adaptive toolbar

This CL makes the AdaptiveToolbar VC return the share button view
for positioning the activity service.

Bug:  803376 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I5701f16c2209cbc76d7190d23c24a939d3722c32
Reviewed-on: https://chromium-review.googlesource.com/878643
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531213}
[modify] https://crrev.com/d665c92a8aac55d966283bb1db1007b586bcf8d6/ios/chrome/browser/ui/toolbar/adaptive/BUILD.gn
[modify] https://crrev.com/d665c92a8aac55d966283bb1db1007b586bcf8d6/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_coordinator.mm
[modify] https://crrev.com/d665c92a8aac55d966283bb1db1007b586bcf8d6/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view_controller.h
[modify] https://crrev.com/d665c92a8aac55d966283bb1db1007b586bcf8d6/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view_controller.mm

Status: Fixed (was: Assigned)

Sign in to add a comment