New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 803372 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 30
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task



Sign in to add a comment

Adaptive Toolbar: Manage the NTP's fakebox tap

Project Member Reported by gambard@chromium.org, Jan 18 2018

Issue description

The Adaptive Toolbar should be able to manage tap on the NTP's fakebox.

Assigning to Justin as you are working on the NTP for the new UI. This bug is for tracking purpose (TODO in the FakeboxFocuser protocol implementation).
 
Labels: zine-triaged
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fc6a61d1e5f1efda1fafee49f00d070ff4afd0e

commit 7fc6a61d1e5f1efda1fafee49f00d070ff4afd0e
Author: Justin Cohen <justincohen@google.com>
Date: Wed Jan 31 17:11:49 2018

[ios] Manage adaptive primary toolbar's fakebox tap

Bug:  803372 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Icdfc2ee6450ab03cf357792cc3ad6d0060baf58e
Reviewed-on: https://chromium-review.googlesource.com/891518
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533303}
[modify] https://crrev.com/7fc6a61d1e5f1efda1fafee49f00d070ff4afd0e/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_view_controller.mm
[modify] https://crrev.com/7fc6a61d1e5f1efda1fafee49f00d070ff4afd0e/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_coordinator.mm
[modify] https://crrev.com/7fc6a61d1e5f1efda1fafee49f00d070ff4afd0e/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view_controller.mm

Status: Fixed (was: Assigned)

Sign in to add a comment