New issue
Advanced search Search tips

Issue 803371 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task



Sign in to add a comment

Adaptive Toolbar: Add Side Swipe capability

Project Member Reported by gambard@chromium.org, Jan 18 2018

Issue description

The Adaptive toolbar should be able to handle the side swipes to change tabs.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8fd74b75d51701dac0823f323654443a6bf1e8f4

commit 8fd74b75d51701dac0823f323654443a6bf1e8f4
Author: Gauthier Ambard <gambard@chromium.org>
Date: Thu Jan 25 18:02:14 2018

Add Side Swipe to the Adaptive Toolbar

This CL adds the side swipe capability to the Adaptive Toolbar.

Bug:  803371 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ie87d1955a81151f06bc5339c655746863b829b58
Reviewed-on: https://chromium-review.googlesource.com/881441
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531940}
[modify] https://crrev.com/8fd74b75d51701dac0823f323654443a6bf1e8f4/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/8fd74b75d51701dac0823f323654443a6bf1e8f4/ios/chrome/browser/ui/ntp/BUILD.gn
[add] https://crrev.com/8fd74b75d51701dac0823f323654443a6bf1e8f4/ios/chrome/browser/ui/ntp/ntp_util.h
[add] https://crrev.com/8fd74b75d51701dac0823f323654443a6bf1e8f4/ios/chrome/browser/ui/ntp/ntp_util.mm
[modify] https://crrev.com/8fd74b75d51701dac0823f323654443a6bf1e8f4/ios/chrome/browser/ui/side_swipe/card_side_swipe_view.h
[modify] https://crrev.com/8fd74b75d51701dac0823f323654443a6bf1e8f4/ios/chrome/browser/ui/side_swipe/card_side_swipe_view.mm
[modify] https://crrev.com/8fd74b75d51701dac0823f323654443a6bf1e8f4/ios/chrome/browser/ui/side_swipe/side_swipe_controller.h
[modify] https://crrev.com/8fd74b75d51701dac0823f323654443a6bf1e8f4/ios/chrome/browser/ui/side_swipe/side_swipe_controller.mm
[modify] https://crrev.com/8fd74b75d51701dac0823f323654443a6bf1e8f4/ios/chrome/browser/ui/toolbar/adaptive/BUILD.gn
[modify] https://crrev.com/8fd74b75d51701dac0823f323654443a6bf1e8f4/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_coordinator+subclassing.h
[modify] https://crrev.com/8fd74b75d51701dac0823f323654443a6bf1e8f4/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_coordinator.h
[modify] https://crrev.com/8fd74b75d51701dac0823f323654443a6bf1e8f4/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_coordinator.mm
[modify] https://crrev.com/8fd74b75d51701dac0823f323654443a6bf1e8f4/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_view_controller.h
[modify] https://crrev.com/8fd74b75d51701dac0823f323654443a6bf1e8f4/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_view_controller.mm
[modify] https://crrev.com/8fd74b75d51701dac0823f323654443a6bf1e8f4/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_coordinator.mm
[modify] https://crrev.com/8fd74b75d51701dac0823f323654443a6bf1e8f4/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view.h
[modify] https://crrev.com/8fd74b75d51701dac0823f323654443a6bf1e8f4/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view.mm
[modify] https://crrev.com/8fd74b75d51701dac0823f323654443a6bf1e8f4/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view_controller.mm
[modify] https://crrev.com/8fd74b75d51701dac0823f323654443a6bf1e8f4/ios/chrome/browser/ui/toolbar/clean/BUILD.gn
[modify] https://crrev.com/8fd74b75d51701dac0823f323654443a6bf1e8f4/ios/chrome/browser/ui/toolbar/clean/toolbar_coordinator.mm
[modify] https://crrev.com/8fd74b75d51701dac0823f323654443a6bf1e8f4/ios/chrome/browser/ui/toolbar/clean/toolbar_mediator.mm
[modify] https://crrev.com/8fd74b75d51701dac0823f323654443a6bf1e8f4/ios/chrome/browser/ui/toolbar/clean/toolbar_mediator_unittest.mm
[modify] https://crrev.com/8fd74b75d51701dac0823f323654443a6bf1e8f4/ios/chrome/browser/ui/toolbar/public/BUILD.gn
[modify] https://crrev.com/8fd74b75d51701dac0823f323654443a6bf1e8f4/ios/chrome/browser/ui/toolbar/public/primary_toolbar_coordinator.h
[modify] https://crrev.com/8fd74b75d51701dac0823f323654443a6bf1e8f4/ios/chrome/browser/ui/toolbar/public/side_swipe_toolbar_interacting.h
[add] https://crrev.com/8fd74b75d51701dac0823f323654443a6bf1e8f4/ios/chrome/browser/ui/toolbar/public/side_swipe_toolbar_snapshot_providing.h
[modify] https://crrev.com/8fd74b75d51701dac0823f323654443a6bf1e8f4/ios/chrome/browser/ui/ui_util.mm

Status: Fixed (was: Assigned)

Sign in to add a comment