New issue
Advanced search Search tips

Issue 803354 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug

Blocking:
issue 798927



Sign in to add a comment

CanvasTestMac.StringSizeIdenticalForSkia in gfx_unittests failing on chromium.mac/Mac10.10 Tests

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Jan 18 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of tapted@chromium.org

CanvasTestMac.StringSizeIdenticalForSkia in gfx_unittests failing on chromium.mac/Mac10.10 Tests

Builders failed on: 
- Mac10.10 Tests: 
  https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests


 

Comment 1 by tapted@chromium.org, Jan 18 2018

Labels: Type-Bug
Owner: tapted@chromium.org
Status: Started (was: Available)
These are all tests using the wrong typesetter in the test now for testing Cocoa UI, rather than Harfbuzz. I'll disable on Mac while I update the tests.

gfx_unittests
 - CanvasTestMac.StringSizeIdenticalForSkia 10.10, 10.11

components_unittests
 - TextEliderTest.TestElisionParsingAdjustments 10.11
 - TextEliderTest.TestFileURLEliding 10.10, 10.11, 10.12
 - TextEliderTest.TestGeneralEliding 10.10, 10.11, 10.12
 - TextEliderTest.TestSimpleElisionMethod 10.10, 10.11, 10.12

unit_tests
 - DownloadItemModelTest.InterruptTooltip 10.11, 10.12

10.9 is happy
 

Comment 2 by tapted@chromium.org, Jan 18 2018

-- 10.12 --

[ RUN      ] DownloadItemModelTest.InterruptTooltip
../../chrome/browser/download/download_item_model_unittest.cc:294: Failure
Expected: (kSmallTooltipWidth) >= (gfx::GetStringWidth(line, font_list)), actual: 40 vs 41
[  FAILED  ] DownloadItemModelTest.InterruptTooltip (63 ms)

[ RUN      ] TextEliderTest.TestFileURLEliding
../../components/url_formatter/elide_url_unittest.cc:156: Failure
Expected equality of these values:
  expected_utf16
    Which is: filer?
  elided
    Which is: filer/foo?
Google Test trace:
../../components/url_formatter/elide_url_unittest.cc:127: Eliding file://filer/foo/bar/file
[  FAILED  ] TextEliderTest.TestFileURLEliding (15 ms)

[ RUN      ] TextEliderTest.TestGeneralEliding
../../components/url_formatter/elide_url_unittest.cc:156: Failure
Expected equality of these values:
  expected_utf16
    Which is: xyz.google.com/fo?
  elided
    Which is: xyz.google.com/foo?bar
Google Test trace:
../../components/url_formatter/elide_url_unittest.cc:127: Eliding http://xyz.google.com/foo?bar
../../components/url_formatter/elide_url_unittest.cc:156: Failure
Expected equality of these values:
  expected_utf16
    Which is: google.com/?/ad?
  elided
    Which is: www.google.com/intl/en/ads/
Google Test trace:
../../components/url_formatter/elide_url_unittest.cc:127: Eliding http://www.google.com/intl/en/ads/
../../components/url_formatter/elide_url_unittest.cc:156: Failure
Expected equality of these values:
  expected_utf16
    Which is: ?foo.com/?/filename.html
  elided
    Which is: https://subdomain.foo.com/bar/filename.html
Google Test trace:
../../components/url_formatter/elide_url_unittest.cc:127: Eliding https://subdomain.foo.com/bar/filename.html
../../components/url_formatter/elide_url_unittest.cc:156: Failure
Expected equality of these values:
  expected_utf16
    Which is: www.g.com/subdir/ads/??
  elided
    Which is: www.g.com/subdir/ads/?query
Google Test trace:
../../components/url_formatter/elide_url_unittest.cc:127: Eliding http://www.g.com/subdir/ads/?query
[  FAILED  ] TextEliderTest.TestGeneralEliding (33 ms)

[ RUN      ] TextEliderTest.TestSimpleElisionMethod
../../components/url_formatter/elide_url_unittest.cc:156: Failure
Expected equality of these values:
  expected_utf16
    Which is: www.abc.com/d?
  elided
    Which is: https://www.abc.com/def/
Google Test trace:
../../components/url_formatter/elide_url_unittest.cc:127: Eliding https://www.abc.com/def/
../../components/url_formatter/elide_url_unittest.cc:156: Failure
Expected equality of these values:
  expected_utf16
    Which is: file://?
  elided
    Which is: file://fs/f?
Google Test trace:
../../components/url_formatter/elide_url_unittest.cc:127: Eliding file://fs/file
[  FAILED  ] TextEliderTest.TestSimpleElisionMethod (19 ms)


-- 10.11 --

[ RUN      ] TextEliderTest.TestElisionParsingAdjustments
../../components/url_formatter/elide_url_unittest.cc:811: Failure
Expected equality of these values:
  base::UTF8ToUTF16(testcase.output)
    Which is: https://www.google.com/?
  elided
    Which is: https://www.google.com/i?
Google Test trace:
../../components/url_formatter/elide_url_unittest.cc:802: https://www.google.com/intl/en/ads/ to https://www.google.com/?
../../components/url_formatter/elide_url_unittest.cc:831: Failure
Expected equality of these values:
  GetComponent(&expected, type)->len
    Which is: 2
  GetComponent(&parsed, type)->len
    Which is: 3
 in component 5
Google Test trace:
../../components/url_formatter/elide_url_unittest.cc:802: https://www.google.com/intl/en/ads/ to https://www.google.com/?
[  FAILED  ] TextEliderTest.TestElisionParsingAdjustments (62 ms)

[ RUN      ] CanvasTestMac.StringSizeIdenticalForSkia
../../ui/gfx/canvas_unittest_mac.mm:57: Failure
Expected equality of these values:
  mac_width
    Which is: 22.5723
  canvas_width
    Which is: 22.8008
 width for Foo
../../ui/gfx/canvas_unittest_mac.mm:57: Failure
Expected equality of these values:
  mac_width
    Which is: 59.8838
  canvas_width
    Which is: 60.4932
 width for Longword
../../ui/gfx/canvas_unittest_mac.mm:57: Failure
Expected equality of these values:
  mac_width
    Which is: 172.644
  canvas_width
    Which is: 174.776
 width for This is a complete sentence.
[  FAILED  ] CanvasTestMac.StringSizeIdenticalForSkia (6 ms)
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e409e122d710ae95712529b36d3e5cd95ab4ac26

commit e409e122d710ae95712529b36d3e5cd95ab4ac26
Author: Trent Apted <tapted@chromium.org>
Date: Thu Jan 18 08:57:40 2018

Disable some tests on Mac that need their test logic updated to specify a CoreText typsetter.

These failures started in r530064 on various permutations of macOS versions.
The test logic now defaults to using the harfbuzz typsetter, but these are
testing Cocoa UI, so they need to be updated. The non-test code should be fine.

TBR=msw@chromium.org

Bug:  803354 
Change-Id: I678004cd88e53a5c7bf044002506580bd058975f
Reviewed-on: https://chromium-review.googlesource.com/872812
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530093}
[modify] https://crrev.com/e409e122d710ae95712529b36d3e5cd95ab4ac26/chrome/browser/download/download_item_model_unittest.cc
[modify] https://crrev.com/e409e122d710ae95712529b36d3e5cd95ab4ac26/components/url_formatter/elide_url_unittest.cc
[modify] https://crrev.com/e409e122d710ae95712529b36d3e5cd95ab4ac26/ui/gfx/canvas_unittest_mac.mm

Comment 5 by shrike@chromium.org, Jan 18 2018

Labels: OS-Mac
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4de9656f3804756923df93751e8991a0167cd3ad

commit 4de9656f3804756923df93751e8991a0167cd3ad
Author: Trent Apted <tapted@chromium.org>
Date: Tue Jan 23 00:13:18 2018

Re-enable some tests that are testing the native typesetter on Mac (CoreText)

r530064 made the default typesetter Harfbuzz.

 - CanvasTestMac.StringSizeIdenticalForSkia compares against the width
of an NSAttributedString, so must use the native typesetter.
 - DownloadItemModelTest.InterruptTooltip measuresa tooltip which is
always typeset with the native typesetter.

Looked around for other tests using Canvas::SizeString or gfx::GetStringWidth*
and they are all Harfbuzz. (i.e. I don't think there are potentially
flaky tests that just happen to be typeset the same for now).

Bug:  803354 
Change-Id: I3e3e1e3663a95ad9e35debb1f9e80138f67c5fdf
Reviewed-on: https://chromium-review.googlesource.com/877363
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531073}
[modify] https://crrev.com/4de9656f3804756923df93751e8991a0167cd3ad/chrome/browser/download/download_item_model_unittest.cc
[modify] https://crrev.com/4de9656f3804756923df93751e8991a0167cd3ad/ui/gfx/canvas_unittest_mac.mm

Project Member

Comment 7 by bugdroid1@chromium.org, Jan 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3bef7a39a3c9c896b957290175701cc1e5423a42

commit 3bef7a39a3c9c896b957290175701cc1e5423a42
Author: Trent Apted <tapted@chromium.org>
Date: Tue Jan 23 05:39:07 2018

Use a consistent typesetter in TextEliderTest after r530064

Although some functions in elide_url.h are not used in release
code on Mac, this CL updates them all to be consistent with passing
through a |typesetter| argument to anonymous functions. This makes
it easier troubleshoot. Re-enable the tests that started failing
when the default typesetter was switched to Harfbuzz in r530064
and fix the inconsistencies.

Bug:  803354 
Change-Id: I641f15783f1e22bed93db4efae03cb3373665a13
Reviewed-on: https://chromium-review.googlesource.com/878102
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531162}
[modify] https://crrev.com/3bef7a39a3c9c896b957290175701cc1e5423a42/chrome/browser/ui/cocoa/status_bubble_mac.mm
[modify] https://crrev.com/3bef7a39a3c9c896b957290175701cc1e5423a42/components/url_formatter/elide_url.cc
[modify] https://crrev.com/3bef7a39a3c9c896b957290175701cc1e5423a42/components/url_formatter/elide_url.h
[modify] https://crrev.com/3bef7a39a3c9c896b957290175701cc1e5423a42/components/url_formatter/elide_url_unittest.cc

Comment 8 by tapted@chromium.org, Jan 30 2018

Status: Fixed (was: Started)

Sign in to add a comment