I don't know what the reason to pass base::TimeTicks::Now() through AutofillDriver::FormSubmitted(), as dcheng@ pointed out in https://chromium-review.googlesource.com/c/chromium/src/+/821610 , we might just call base::TimeTicks::Now() in browser side.
Assigning to time-keeping expert sebsg@
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b2020be37605f4679d73f6cbd37f929249ae0fc0 commit b2020be37605f4679d73f6cbd37f929249ae0fc0 Author: Sebastien Lalancette <seblalancette@chromium.org> Date: Tue Jan 08 15:17:59 2019 [AF] Removed timestamp parameter from OnFormSubmit functions. Remove the timestamp as a parameter as it was only being used to pass "now" timestamps; now generating that timestamp within the function instead. Bug: 803333 Change-Id: I180bbc965b5f49913e600cab57473dd9b5a4dcd9 Reviewed-on: https://chromium-review.googlesource.com/c/1388111 Reviewed-by: Emily Stark <estark@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#620726} [modify] https://crrev.com/b2020be37605f4679d73f6cbd37f929249ae0fc0/chrome/browser/autofill/autofill_provider_browsertest.cc [modify] https://crrev.com/b2020be37605f4679d73f6cbd37f929249ae0fc0/chrome/renderer/autofill/autofill_renderer_browsertest.cc [modify] https://crrev.com/b2020be37605f4679d73f6cbd37f929249ae0fc0/chrome/renderer/autofill/form_autocomplete_browsertest.cc [modify] https://crrev.com/b2020be37605f4679d73f6cbd37f929249ae0fc0/components/autofill/android/autofill_provider_android.cc [modify] https://crrev.com/b2020be37605f4679d73f6cbd37f929249ae0fc0/components/autofill/android/autofill_provider_android.h [modify] https://crrev.com/b2020be37605f4679d73f6cbd37f929249ae0fc0/components/autofill/content/browser/content_autofill_driver.cc [modify] https://crrev.com/b2020be37605f4679d73f6cbd37f929249ae0fc0/components/autofill/content/browser/content_autofill_driver.h [modify] https://crrev.com/b2020be37605f4679d73f6cbd37f929249ae0fc0/components/autofill/content/common/autofill_driver.mojom [modify] https://crrev.com/b2020be37605f4679d73f6cbd37f929249ae0fc0/components/autofill/content/renderer/autofill_agent.cc [modify] https://crrev.com/b2020be37605f4679d73f6cbd37f929249ae0fc0/components/autofill/core/browser/autofill_handler.cc [modify] https://crrev.com/b2020be37605f4679d73f6cbd37f929249ae0fc0/components/autofill/core/browser/autofill_handler.h [modify] https://crrev.com/b2020be37605f4679d73f6cbd37f929249ae0fc0/components/autofill/core/browser/autofill_handler_proxy.cc [modify] https://crrev.com/b2020be37605f4679d73f6cbd37f929249ae0fc0/components/autofill/core/browser/autofill_handler_proxy.h [modify] https://crrev.com/b2020be37605f4679d73f6cbd37f929249ae0fc0/components/autofill/core/browser/autofill_manager.cc [modify] https://crrev.com/b2020be37605f4679d73f6cbd37f929249ae0fc0/components/autofill/core/browser/autofill_manager.h [modify] https://crrev.com/b2020be37605f4679d73f6cbd37f929249ae0fc0/components/autofill/core/browser/autofill_manager_unittest.cc [modify] https://crrev.com/b2020be37605f4679d73f6cbd37f929249ae0fc0/components/autofill/core/browser/autofill_metrics_unittest.cc [modify] https://crrev.com/b2020be37605f4679d73f6cbd37f929249ae0fc0/components/autofill/core/browser/autofill_provider.h [modify] https://crrev.com/b2020be37605f4679d73f6cbd37f929249ae0fc0/components/autofill/core/browser/credit_card_save_manager_unittest.cc [modify] https://crrev.com/b2020be37605f4679d73f6cbd37f929249ae0fc0/components/autofill/core/browser/local_card_migration_manager_unittest.cc [modify] https://crrev.com/b2020be37605f4679d73f6cbd37f929249ae0fc0/components/autofill/core/browser/test_autofill_manager.cc [modify] https://crrev.com/b2020be37605f4679d73f6cbd37f929249ae0fc0/components/autofill/core/browser/test_autofill_manager.h [modify] https://crrev.com/b2020be37605f4679d73f6cbd37f929249ae0fc0/components/autofill/core/browser/test_autofill_provider.h [modify] https://crrev.com/b2020be37605f4679d73f6cbd37f929249ae0fc0/components/autofill/ios/browser/autofill_agent.mm [modify] https://crrev.com/b2020be37605f4679d73f6cbd37f929249ae0fc0/components/password_manager/core/browser/password_form_manager_unittest.cc
Fixed - feature should behave as usual.
Comment 1 by ma...@chromium.org
, Jul 17Status: Assigned (was: Untriaged)