Site isolation flag metrics should be recorded periodically and not just at startup |
||||||||
Issue descriptionCurrently, SiteIsolation.Flags.SitePerProcess and SiteIsolation.Flags.IsolateOrigins are recorded once on browser startup. While this gives us some idea of how widespread the usage of these flags is, it doesn't tell how many users have these flags enabled on any given day, and aggregating these metrics across multiple days while restricting to unique users doesn't seem to work properly. It would be more useful if those metrics were also recorded once per day, so that it's easy to know how many users are running with those flags enabled on any given day. For enterprise policies, Enterprise.Policies.IsolateOrigins and Enterprise.Policies.SitePerProcess do this by scheduling metrics updates every 24 hours - see PolicyStatisticsCollector::ScheduleUpdate(). We should do something similar for Siteisolation.Flags.* (the overall flag usage metrics) as well.
,
Jan 19 2018
Requesting merge of #1 to M64 - this is a low-risk, metrics-only change which will give us more accurate estimates for site isolation usage on M64. It's in the latest canary and not causing any problems AFAICT - the metrics still get recorded on startup, and I can verify in 24 hours that they get rerecorded as expected in chrome://histograms.
,
Jan 19 2018
This bug requires manual review: We are only 3 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 19 2018
Approving the merge for M64. Branch:3282
,
Jan 19 2018
I'll help with the merge (I am currently working on resolving the merge conflict and making sure things build fine on 3282, so taking lunch into account it will probably be 1-2h before I finish the merge).
,
Jan 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a0014a0b267107e69382fc510de03a8c195f9f0d commit a0014a0b267107e69382fc510de03a8c195f9f0d Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Fri Jan 19 21:36:50 2018 Record site isolation flag usage metrics once every 24 hours. TBR=lukasza@chromium.org, holte@chromium.org (cherry picked from commit fd2d98026b00486acbf27629ead11dbad90724f6) Bug: 803322 Change-Id: I01ed6b51bedcfb1c40ee3aea79a2a14122f1a0c9 Reviewed-on: https://chromium-review.googlesource.com/872269 Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Original-Original-Commit-Position: refs/heads/master@{#530242} Reviewed-on: https://chromium-review.googlesource.com/876950 Cr-Commit-Position: refs/branch-heads/3282@{#553} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/a0014a0b267107e69382fc510de03a8c195f9f0d/content/browser/browser_main_loop.cc [modify] https://crrev.com/a0014a0b267107e69382fc510de03a8c195f9f0d/content/common/site_isolation_policy.cc [modify] https://crrev.com/a0014a0b267107e69382fc510de03a8c195f9f0d/content/common/site_isolation_policy.h [modify] https://crrev.com/a0014a0b267107e69382fc510de03a8c195f9f0d/tools/metrics/histograms/histograms.xml
,
Jan 19 2018
,
Jan 23 2018
lukasza@ Could you please help us with the repro steps to verify this fix from TE-End. Thank You...
,
Jan 23 2018
I am not sure if these test steps can be used in practice, but one way to test would be to: 1. Launch Chrome with --site-per-process flag 2. Navigate to chrome://histograms and verify that SiteIsolation.Flags.SitePerProcess has been logged with a value of 1 3. Leave Chrome running for 24 hours 4. Navigate to chrome://histograms and verify that SiteIsolation.Flags.SitePerProcess has been logged with a value of 1 *two* times
,
Jan 24 2018
As per comment #9, started testing this feature on Windows 7 and Ubuntu 16.10, will update the behavior the behavior after 24 hrs
,
Jan 24 2018
FWIW, I left Win beta 64.0.3282.113 (which has the merge from #6) running for 24 hours and verified that chrome://histograms shows that both SiteIsolation.Flags.SitePerProcess and SiteIsolation.Flags.IsolateOrigins have been logged *two* times each with their appropriate values.
,
Feb 1 2018
Apologies for delay response. Tested this issue on Windows 7 with chrome beta #64.0.3282.119 and verified that chrome://histograms shows that both SiteIsolation.Flags.SitePerProcess and SiteIsolation.Flags.IsolateOrigins have been logged 2 times each with their appropriate values. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bugdroid1@chromium.org
, Jan 18 2018