detection of npot texture on desktop |
||
Issue descriptionIn ScopedRenderPassTexture::ScopedRenderPassTexture, context_provider_->ContextCapabilities().texture_npot always return false on Ubuntu 16.04. As hinted by reveman at https://chromium-review.googlesource.com/c/chromium/src/+/869952/6//COMMIT_MSG#10, this suggests "Our npot texture check is probably failing on desktop GL", and we need a fix for this.
,
Jan 18 2018
We detect npot texture support here: https://cs.chromium.org/chromium/src/gpu/command_buffer/service/feature_info.cc?l=880
,
Jan 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb62c05b0122953851fb4b0bb4b46734b8e537d0 commit bb62c05b0122953851fb4b0bb4b46734b8e537d0 Author: Xu Xing <xing.xu@intel.com> Date: Fri Jan 19 03:04:05 2018 [viz] Apply mipmap filter on local resource TODO(crbug.com/803286): npot texture always return false on ubuntu desktop. The npot texture check is probably failing on desktop GL. BUG= 802924 , 803286 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I8f2dc179f065f1fa59650184c59d6184e293fbfd Reviewed-on: https://chromium-review.googlesource.com/869952 Reviewed-by: David Reveman <reveman@chromium.org> Commit-Queue: Xing Xu <xing.xu@intel.com> Cr-Commit-Position: refs/heads/master@{#530409} [modify] https://crrev.com/bb62c05b0122953851fb4b0bb4b46734b8e537d0/cc/test/test_web_graphics_context_3d.h [modify] https://crrev.com/bb62c05b0122953851fb4b0bb4b46734b8e537d0/components/viz/service/display/gl_renderer.cc [modify] https://crrev.com/bb62c05b0122953851fb4b0bb4b46734b8e537d0/components/viz/service/display/gl_renderer_unittest.cc [modify] https://crrev.com/bb62c05b0122953851fb4b0bb4b46734b8e537d0/components/viz/service/display/scoped_render_pass_texture.cc [modify] https://crrev.com/bb62c05b0122953851fb4b0bb4b46734b8e537d0/components/viz/service/display/scoped_render_pass_texture.h
,
Jan 19 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by xing...@intel.com
, Jan 18 2018